From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2/2] arch/arc: arc7x0 always needs -matomic
Date: Sat, 1 Jun 2019 22:50:46 +0200 [thread overview]
Message-ID: <20190601205046.GI3407@scaer> (raw)
In-Reply-To: <20190601223735.4057b840@windsurf>
Thomas, All,
On 2019-06-01 22:37 +0200, Thomas Petazzoni spake thusly:
> On Sat, 1 Jun 2019 22:33:51 +0200
> "Yann E. MORIN" <yann.morin.1998@free.fr> wrote:
> > diff --git a/arch/arch.mk.arc b/arch/arch.mk.arc
> > new file mode 100644
> > index 0000000000..d324e5c1e1
> > --- /dev/null
> > +++ b/arch/arch.mk.arc
> > @@ -0,0 +1,4 @@
> > +# ARC7x0 needs -matomic, always
> > +ifeq ($(BR2_arc750d)$(BR2_arc770d),y)
> > +ARCH_TOOLCHAIN_WRAPPER_OPTS = -matomic
> > +endif
> So can we drop
> TARGET_ABI += -matomic
> from package/Makefile.in ?
Ah, I see that the condition there is not the same as the one I wrote.
Alexey, last time I asked [0], you did not reply, so here goes again: what
variants of ARC really require -matomic, as you reported on [2] [3].
From [1], I understood that only arc700 was impacted, but the existing
condition to add -matomic for arc [4] is not the same.
So, quid?
[0] https://patchwork.ozlabs.org/comment/2169504/
[1] https://patchwork.ozlabs.org/comment/2159927/
[2] https://patchwork.ozlabs.org/patch/1087471/
[3] https://patchwork.ozlabs.org/patch/1087480/
[4] https://git.buildroot.org/buildroot/tree/package/Makefile.in#n106
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2019-06-01 20:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-01 20:33 [Buildroot] [PATCH 0/2] arch: allow passing compile flags (branch yem/arc-atomic) Yann E. MORIN
2019-06-01 20:33 ` [Buildroot] [PATCH 1/2] toolchain: allow architectures to enforce compilation flags Yann E. MORIN
2019-06-01 20:33 ` [Buildroot] [PATCH 2/2] arch/arc: arc7x0 always needs -matomic Yann E. MORIN
2019-06-01 20:37 ` Thomas Petazzoni
2019-06-01 20:50 ` Yann E. MORIN [this message]
2019-06-03 5:42 ` Alexey Brodkin
2019-07-14 14:21 ` Yann E. MORIN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190601205046.GI3407@scaer \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.