From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sasha Levin Date: Sun, 02 Jun 2019 14:11:35 +0000 Subject: Re: [PATCH AUTOSEL 4.4 44/56] video: imsttfb: fix potential NULL pointer dereferences Message-Id: <20190602141135.GP12898@sasha-vm> List-Id: References: <20190601132600.27427-1-sashal@kernel.org> <20190601132600.27427-44-sashal@kernel.org> <20190601161929.GA5028@kroah.com> In-Reply-To: <20190601161929.GA5028@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Greg Kroah-Hartman Cc: linux-fbdev@vger.kernel.org, Bartlomiej Zolnierkiewicz , dri-devel@lists.freedesktop.org, Kangjie Lu , linux-kernel@vger.kernel.org, Finn Thain , stable@vger.kernel.org, Aditya Pakki On Sat, Jun 01, 2019 at 09:19:29AM -0700, Greg Kroah-Hartman wrote: >On Sat, Jun 01, 2019 at 09:25:48AM -0400, Sasha Levin wrote: >> From: Kangjie Lu >> >> [ Upstream commit 1d84353d205a953e2381044953b7fa31c8c9702d ] >> >> In case ioremap fails, the fix releases resources and returns >> -ENOMEM to avoid NULL pointer dereferences. >> >> Signed-off-by: Kangjie Lu >> Cc: Aditya Pakki >> Cc: Finn Thain >> Cc: Rob Herring >> Cc: Greg Kroah-Hartman >> [b.zolnierkie: minor patch summary fixup] >> Signed-off-by: Bartlomiej Zolnierkiewicz >> Signed-off-by: Sasha Levin >> --- >> drivers/video/fbdev/imsttfb.c | 5 +++++ >> 1 file changed, 5 insertions(+) > >Why only 4.4.y? Shouldn't this be queued up for everything or none? It's on all branches. Something weird happened with git-send-email and mail.kernel.org, and apparently the rest of the branches didn't get all their mails sent out. Sadly I don't have the logs for that :( -- Thanks, Sasha From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sasha Levin Subject: Re: [PATCH AUTOSEL 4.4 44/56] video: imsttfb: fix potential NULL pointer dereferences Date: Sun, 2 Jun 2019 10:11:35 -0400 Message-ID: <20190602141135.GP12898@sasha-vm> References: <20190601132600.27427-1-sashal@kernel.org> <20190601132600.27427-44-sashal@kernel.org> <20190601161929.GA5028@kroah.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by gabe.freedesktop.org (Postfix) with ESMTPS id 42CBD892FB for ; Sun, 2 Jun 2019 14:11:37 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20190601161929.GA5028@kroah.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Greg Kroah-Hartman Cc: linux-fbdev@vger.kernel.org, Bartlomiej Zolnierkiewicz , dri-devel@lists.freedesktop.org, Kangjie Lu , linux-kernel@vger.kernel.org, Finn Thain , stable@vger.kernel.org, Aditya Pakki List-Id: dri-devel@lists.freedesktop.org T24gU2F0LCBKdW4gMDEsIDIwMTkgYXQgMDk6MTk6MjlBTSAtMDcwMCwgR3JlZyBLcm9haC1IYXJ0 bWFuIHdyb3RlOgo+T24gU2F0LCBKdW4gMDEsIDIwMTkgYXQgMDk6MjU6NDhBTSAtMDQwMCwgU2Fz aGEgTGV2aW4gd3JvdGU6Cj4+IEZyb206IEthbmdqaWUgTHUgPGtqbHVAdW1uLmVkdT4KPj4KPj4g WyBVcHN0cmVhbSBjb21taXQgMWQ4NDM1M2QyMDVhOTUzZTIzODEwNDQ5NTNiN2ZhMzFjOGM5NzAy ZCBdCj4+Cj4+IEluIGNhc2UgaW9yZW1hcCBmYWlscywgdGhlIGZpeCByZWxlYXNlcyByZXNvdXJj ZXMgYW5kIHJldHVybnMKPj4gLUVOT01FTSB0byBhdm9pZCBOVUxMIHBvaW50ZXIgZGVyZWZlcmVu Y2VzLgo+Pgo+PiBTaWduZWQtb2ZmLWJ5OiBLYW5namllIEx1IDxramx1QHVtbi5lZHU+Cj4+IENj OiBBZGl0eWEgUGFra2kgPHBha2tpMDAxQHVtbi5lZHU+Cj4+IENjOiBGaW5uIFRoYWluIDxmdGhh aW5AdGVsZWdyYXBoaWNzLmNvbS5hdT4KPj4gQ2M6IFJvYiBIZXJyaW5nIDxyb2JoQGtlcm5lbC5v cmc+Cj4+IENjOiBHcmVnIEtyb2FoLUhhcnRtYW4gPGdyZWdraEBsaW51eGZvdW5kYXRpb24ub3Jn Pgo+PiBbYi56b2xuaWVya2llOiBtaW5vciBwYXRjaCBzdW1tYXJ5IGZpeHVwXQo+PiBTaWduZWQt b2ZmLWJ5OiBCYXJ0bG9taWVqIFpvbG5pZXJraWV3aWN6IDxiLnpvbG5pZXJraWVAc2Ftc3VuZy5j b20+Cj4+IFNpZ25lZC1vZmYtYnk6IFNhc2hhIExldmluIDxzYXNoYWxAa2VybmVsLm9yZz4KPj4g LS0tCj4+ICBkcml2ZXJzL3ZpZGVvL2ZiZGV2L2ltc3R0ZmIuYyB8IDUgKysrKysKPj4gIDEgZmls ZSBjaGFuZ2VkLCA1IGluc2VydGlvbnMoKykKPgo+V2h5IG9ubHkgNC40Lnk/ICBTaG91bGRuJ3Qg dGhpcyBiZSBxdWV1ZWQgdXAgZm9yIGV2ZXJ5dGhpbmcgb3Igbm9uZT8KCkl0J3Mgb24gYWxsIGJy YW5jaGVzLiBTb21ldGhpbmcgd2VpcmQgaGFwcGVuZWQgd2l0aCBnaXQtc2VuZC1lbWFpbCBhbmQK bWFpbC5rZXJuZWwub3JnLCBhbmQgYXBwYXJlbnRseSB0aGUgcmVzdCBvZiB0aGUgYnJhbmNoZXMg ZGlkbid0IGdldCBhbGwKdGhlaXIgbWFpbHMgc2VudCBvdXQuIFNhZGx5IEkgZG9uJ3QgaGF2ZSB0 aGUgbG9ncyBmb3IgdGhhdCA6KAoKLS0KVGhhbmtzLApTYXNoYQpfX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1k ZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcv bWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWw= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, T_DKIMWL_WL_HIGH,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5F15CC282DC for ; Sun, 2 Jun 2019 14:11:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 282062793B for ; Sun, 2 Jun 2019 14:11:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1559484699; bh=XWIQtRm3YBgJzMgx47r1GeU6a0hziX3Bayzxz7HYHDU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=wXrOJ0y9Yn0dzv8xlkeFLywQVepyl6cVTf8wqT28tmax4XFcFswr7wZUojR/cXjv2 tWTealiqCzt1T99GtaGu8yXK1OGtGwHhW5GmfHtoPD8IZ9IexPwHq/yPbMOK5PigVP BViKUpIcKW7TgC1IqzeEbm/tZrH6Yy1dkpg0FozM= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726587AbfFBOLi (ORCPT ); Sun, 2 Jun 2019 10:11:38 -0400 Received: from mail.kernel.org ([198.145.29.99]:45226 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725939AbfFBOLh (ORCPT ); Sun, 2 Jun 2019 10:11:37 -0400 Received: from localhost (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id BFB5827939; Sun, 2 Jun 2019 14:11:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1559484697; bh=XWIQtRm3YBgJzMgx47r1GeU6a0hziX3Bayzxz7HYHDU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=2C6Lsyqjl1lq8cMl5HmJSDmhu68WMgHeXo8d7wvsyLcWYJhTi3LKPzGrDF2N57jni RNWBGChMzbkjHSvYFxIzqNjCcgNBi4laBkGooBA61hNXEU13ngYQSa7o5xsteZNDwV 8n+4BWuAsTcEVS99GcQHNLzJgFGdsGYaHTIessyE= Date: Sun, 2 Jun 2019 10:11:35 -0400 From: Sasha Levin To: Greg Kroah-Hartman Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, Kangjie Lu , Aditya Pakki , Finn Thain , Rob Herring , Bartlomiej Zolnierkiewicz , linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: Re: [PATCH AUTOSEL 4.4 44/56] video: imsttfb: fix potential NULL pointer dereferences Message-ID: <20190602141135.GP12898@sasha-vm> References: <20190601132600.27427-1-sashal@kernel.org> <20190601132600.27427-44-sashal@kernel.org> <20190601161929.GA5028@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20190601161929.GA5028@kroah.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Jun 01, 2019 at 09:19:29AM -0700, Greg Kroah-Hartman wrote: >On Sat, Jun 01, 2019 at 09:25:48AM -0400, Sasha Levin wrote: >> From: Kangjie Lu >> >> [ Upstream commit 1d84353d205a953e2381044953b7fa31c8c9702d ] >> >> In case ioremap fails, the fix releases resources and returns >> -ENOMEM to avoid NULL pointer dereferences. >> >> Signed-off-by: Kangjie Lu >> Cc: Aditya Pakki >> Cc: Finn Thain >> Cc: Rob Herring >> Cc: Greg Kroah-Hartman >> [b.zolnierkie: minor patch summary fixup] >> Signed-off-by: Bartlomiej Zolnierkiewicz >> Signed-off-by: Sasha Levin >> --- >> drivers/video/fbdev/imsttfb.c | 5 +++++ >> 1 file changed, 5 insertions(+) > >Why only 4.4.y? Shouldn't this be queued up for everything or none? It's on all branches. Something weird happened with git-send-email and mail.kernel.org, and apparently the rest of the branches didn't get all their mails sent out. Sadly I don't have the logs for that :( -- Thanks, Sasha