From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v6 1/2] OVL_MNT: add helpers to setup overlayfs mountpoint
Date: Mon, 3 Jun 2019 07:06:55 +0200 [thread overview]
Message-ID: <20190603050655.GA27243@dell5510> (raw)
In-Reply-To: <20190530025301.9616-1-xzhou@redhat.com>
Hi Murphy,
> Define constraints of needed overlayfs dirs;
> create_overlay_dirs() to create lower/upper/work dirs;
> mount_overlay() to mount overlayfs;
> SAFE_MOUNT_OVERLAY macro to mount overlayfs safely, tst_brk TCONF
> if mount fail with errno ENODEV;
> TST_MOUNT_OVERLAY macro to mount overlayfs and return 0 if succeeds;
> Suggested-by: Petr Vorel <pvorel@suse.cz>
> Suggested-by: Amir Goldstein <amir73il@gmail.com>
> Reviewed-by: Amir Goldstein <amir73il@gmail.com>
> Signed-off-by: Murphy Zhou <xzhou@redhat.com>
Acked-by: Petr Vorel <pvorel@suse.cz>
with tiny change not initialize ret (no need as it's initialized by mount()).
Kind regards,
Petr
diff --git lib/tst_fs_setup.c lib/tst_fs_setup.c
index 32a6218e3..54ea37077 100644
--- lib/tst_fs_setup.c
+++ lib/tst_fs_setup.c
@@ -26,7 +26,7 @@ void create_overlay_dirs(void)
int mount_overlay(const char *file, const int lineno, int skip)
{
- int ret = 0;
+ int ret;
create_overlay_dirs();
ret = mount("overlay", OVL_MNT, "overlay", 0,
next prev parent reply other threads:[~2019-06-03 5:06 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-30 4:39 [LTP] [PATCH] OVL_MNT: put overlayfs lower, upper, work, mnt dir in separated mountpoint Murphy Zhou
2019-04-30 8:18 ` Li Wang
2019-05-03 21:00 ` Petr Vorel
2019-05-15 9:21 ` [LTP] [PATCH v2 1/2] OVL_MNT: add setup_overlay helper Murphy Zhou
2019-05-15 9:21 ` [LTP] [PATCH v2 2/2] OVL_MNT: put overlayfs lower, upper, work, mnt dir in a separated mountpoint Murphy Zhou
2019-05-15 13:39 ` Petr Vorel
2019-05-16 9:14 ` Murphy Zhou
2019-05-15 13:31 ` [LTP] [PATCH v2 1/2] OVL_MNT: add setup_overlay helper Petr Vorel
2019-05-15 13:42 ` Petr Vorel
2019-05-15 14:30 ` Amir Goldstein
2019-05-15 18:20 ` Petr Vorel
2019-05-16 9:15 ` Murphy Zhou
2019-05-24 4:48 ` Murphy Zhou
2019-05-24 7:30 ` Petr Vorel
2019-05-24 9:04 ` [LTP] [PATCH v3 1/2] OVL_MNT: add helpers to setup overlayfs mountpoint Murphy Zhou
2019-05-24 9:04 ` [LTP] [PATCH v3 2/2] OVL_MNT: setup overlayfs dirs and mount in a separated mountpoint Murphy Zhou
2019-05-24 4:32 ` [LTP] [PATCH v2 1/2] OVL_MNT: add setup_overlay helper Murphy Zhou
2019-05-24 8:54 ` Petr Vorel
2019-05-24 11:24 ` Amir Goldstein
2019-05-24 12:23 ` Petr Vorel
2019-05-24 13:44 ` Murphy Zhou
2019-05-25 11:51 ` [LTP] [PATCH v4 1/2] OVL_MNT: add helpers to setup overlayfs mountpoint Murphy Zhou
2019-05-25 11:51 ` [LTP] [PATCH v4 2/2] OVL_MNT: setup overlayfs dirs and mount in a separated mountpoint Murphy Zhou
2019-05-27 12:09 ` [LTP] [PATCH v4 1/2] OVL_MNT: add helpers to setup overlayfs mountpoint Petr Vorel
2019-05-27 13:17 ` Amir Goldstein
2019-05-27 15:27 ` Petr Vorel
2019-05-27 13:38 ` Murphy Zhou
2019-05-27 15:36 ` Petr Vorel
2019-05-29 7:49 ` Murphy Zhou
2019-05-29 10:18 ` [LTP] [PATCH v5 " Murphy Zhou
2019-05-29 10:18 ` [LTP] [PATCH v5 2/2] OVL_MNT: setup overlayfs dirs and mount in a separated mountpoint Murphy Zhou
2019-05-29 10:55 ` Amir Goldstein
2019-05-29 10:59 ` [LTP] [PATCH v5 1/2] OVL_MNT: add helpers to setup overlayfs mountpoint Amir Goldstein
2019-05-30 2:41 ` Murphy Zhou
2019-05-30 2:53 ` [LTP] [PATCH v6 " Murphy Zhou
2019-05-30 2:53 ` [LTP] [PATCH v6 2/2] OVL_MNT: setup overlayfs dirs and mount in a separated mountpoint Murphy Zhou
2019-06-03 7:12 ` Petr Vorel
2019-06-03 5:06 ` Petr Vorel [this message]
2019-05-24 13:36 ` [LTP] [PATCH v2 1/2] OVL_MNT: add setup_overlay helper Murphy Zhou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190603050655.GA27243@dell5510 \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.