From: Sam Ravnborg <sam@ravnborg.org>
To: Masahiro Yamada <yamada.masahiro@socionext.com>
Cc: Jani Nikula <jani.nikula@intel.com>,
Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
intel-gfx@lists.freedesktop.org,
Chris Wilson <chris@chris-wilson.co.uk>,
Michal Marek <michal.lkml@markovi.net>
Subject: Re: [RFC 1/3] kbuild: add support for ensuring headers are self-contained
Date: Mon, 3 Jun 2019 19:33:28 +0200 [thread overview]
Message-ID: <20190603173328.GA11045@ravnborg.org> (raw)
In-Reply-To: <CAK7LNARY_L3Oyi7hhCZXVwNRAsf6ceSarTNDrzdfXQGj1tDFJw@mail.gmail.com>
Hi Masahiro/Jani.
>
> Following the obj-y pattern,
> I want to make header-test-y relative to $(obj).
I also considered this and agree this is better.
Otherwise we end up with a spaghetti of dependencies across the tree.
What I made just fit the purpose I had that day,
which is no excuse for bad design.
> I prefer this:
>
> quiet_cmd_header_test = HDRTEST $@
> cmd_header_test = echo "\#include \"$*.h\"" > $@
>
> $(obj)/%.header_test.c:
> $(call cmd,header_test)
Even better - good.
We call it HDRTEST - so why not just go for that name:
hdrtest-y += headerfile.h
??
The current proposal with "header-test-y" hurts the eye a little with
two '-', and all other variables uses only one '-' as is today.
(generic-y, obj-y etc).
This is bikeshedding but is was itcing me a little.
Sam
next prev parent reply other threads:[~2019-06-03 17:33 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-16 19:48 [RFC 1/3] kbuild: add support for ensuring headers are self-contained Jani Nikula
2019-05-16 19:48 ` Jani Nikula
2019-05-16 19:48 ` [RFC 2/3] drm/i915: ensure headers remain self-contained Jani Nikula
2019-05-16 19:48 ` Jani Nikula
2019-05-16 19:48 ` [RFC 3/3] DO NOT MERGE: drm/i915: add failing header to header-test-y Jani Nikula
2019-05-16 20:12 ` ✗ Fi.CI.SPARSE: warning for series starting with [RFC,1/3] kbuild: add support for ensuring headers are self-contained Patchwork
2019-05-16 20:31 ` ✓ Fi.CI.BAT: success " Patchwork
2019-05-17 3:54 ` ✓ Fi.CI.IGT: " Patchwork
2019-05-17 8:35 ` [RFC 1/3] " Chris Wilson
2019-05-17 8:35 ` Chris Wilson
2019-05-17 8:35 ` Chris Wilson
2019-05-18 5:29 ` Masahiro Yamada
2019-05-18 5:16 ` Masahiro Yamada
2019-05-20 9:20 ` [Intel-gfx] " Jani Nikula
2019-06-03 17:16 ` Masahiro Yamada
2019-05-24 17:40 ` Sam Ravnborg
2019-06-03 17:05 ` Masahiro Yamada
2019-06-03 17:05 ` Masahiro Yamada
2019-06-03 17:33 ` Sam Ravnborg [this message]
2019-06-04 0:20 ` Masahiro Yamada
2019-06-04 0:20 ` Masahiro Yamada
2019-05-26 14:01 ` ✗ Fi.CI.BAT: failure for series starting with [RFC,1/3] kbuild: add support for ensuring headers are self-contained (rev2) Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190603173328.GA11045@ravnborg.org \
--to=sam@ravnborg.org \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.lkml@markovi.net \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.