From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6C95FC04AB5 for ; Tue, 4 Jun 2019 02:34:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 394032639E for ; Tue, 4 Jun 2019 02:34:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="uaLC1fQ5" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726343AbfFDCer (ORCPT ); Mon, 3 Jun 2019 22:34:47 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:52874 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726179AbfFDCer (ORCPT ); Mon, 3 Jun 2019 22:34:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=W4Nd3rZa8hbiXCs8eXcQdSzCJyL5prZ2g7Cam2r7J5s=; b=uaLC1fQ5rJeQnPyBDN2o2DZYYQ fsmmxIbE8DdoyK3ynku4Zc0sKI3RZL+GWsj4VzWi3qSOJK6tbROk3u41NagD40keWc8d1aLgc/JaR mHodr6Z7eBV4kL5ISC02NgRgVZGP+Q40m0ivKOK7njknQQXhDBFcy2qt8bJWJVbgfwa4=; Received: from andrew by vps0.lunn.ch with local (Exim 4.89) (envelope-from ) id 1hXzHh-0001aZ-Qi; Tue, 04 Jun 2019 04:34:45 +0200 Date: Tue, 4 Jun 2019 04:34:45 +0200 From: Andrew Lunn To: Robert Hancock Cc: netdev@vger.kernel.org, anirudh@xilinx.com, John.Linn@xilinx.com Subject: Re: [PATCH net-next 06/18] net: axienet: fix teardown order of MDIO bus Message-ID: <20190604023445.GL17267@lunn.ch> References: <1559599037-8514-1-git-send-email-hancock@sedsystems.ca> <1559599037-8514-7-git-send-email-hancock@sedsystems.ca> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1559599037-8514-7-git-send-email-hancock@sedsystems.ca> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, Jun 03, 2019 at 03:57:05PM -0600, Robert Hancock wrote: > Since the MDIO is is brought up before the netdev is registered, it > should be torn down after the netdev is removed. Otherwise, PHY accesses > can potentially access freed MDIO bus references and cause a crash. > > Signed-off-by: Robert Hancock Reviewed-by: Andrew Lunn Andrew