From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9B439C282CE for ; Tue, 4 Jun 2019 05:48:55 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6CC6E2064A for ; Tue, 4 Jun 2019 05:48:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=kroah.com header.i=@kroah.com header.b="oaHBm6XD"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="GZ1FyG62" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6CC6E2064A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kroah.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1hY2J1-0003e1-4U; Tue, 04 Jun 2019 05:48:19 +0000 Received: from us1-rack-dfw2.inumbo.com ([104.130.134.6]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1hY2Iz-0003dw-GL for xen-devel@lists.xenproject.org; Tue, 04 Jun 2019 05:48:17 +0000 X-Inumbo-ID: 581d8a84-868c-11e9-8980-bc764e045a96 Received: from wout1-smtp.messagingengine.com (unknown [64.147.123.24]) by us1-rack-dfw2.inumbo.com (Halon) with ESMTPS id 581d8a84-868c-11e9-8980-bc764e045a96; Tue, 04 Jun 2019 05:48:14 +0000 (UTC) Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.west.internal (Postfix) with ESMTP id 5BA42543; Tue, 4 Jun 2019 01:48:13 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute6.internal (MEProxy); Tue, 04 Jun 2019 01:48:13 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kroah.com; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:content-transfer-encoding:in-reply-to; s=fm3; bh=T CaT+Fn47+ujhoKgN9BqRZfA99WODN1m/1NIm/vdRH8=; b=oaHBm6XDYjYnIR1+T tDP6lz3rPXXNul0GO6vfZa9L/L0jmBs0+qYGxIQnA08yiWcMtzGgEJlXssupUOWk IXiXTc7PRBQRY8LN2/u5T9nI1Gc58f2Y+HocDeVesocNpudlktWBKYFqrc8DWBYQ 5T8byHPpvDvi0U/aqtts5/dEkHgnDE6uwCEI8NtaEUsa7dzTm8LdHXXccCSo5DJd DcpcQZug2TO0gunHcVwPYJBuXCyAEerKpju7cSNY+oK7yNc4D5DLNb/9D9OUB9Lq FvPKvahrP7eOBp/EexPhywS/N8HhKe1+bohaYPKCBirPf/w19szbXlsmREwh9Nik wyn9g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=TCaT+Fn47+ujhoKgN9BqRZfA99WODN1m/1NIm/vdR H8=; b=GZ1FyG62s1xexwpPe4FC5Q62hK982P/nBwXKoBo/2LnNCaW3a8jrInxUP ARtfThVhX0ddEKj/QQTMSwRy92rmVXFTbqKE7t82LRu10VAo7CZXphwOTw+DW8Rd Ff6DUipkbo5YI4EQOUfzQcWI4d535crAFOp8aLrTINByquHyunwRESbSU+2uFB6k cgSLpRmIDnk+c5uygok/Yf8oWKKuoDv/JTrXuiKjQr4PaI9BFWtBeHsGJu3b/aWO UgINRDDsf1Kww2ql/jndm+FpH1YxGFGlisyuif+OBKgGDDSxBc5DuVD4lSuucuys kJBI0TTvpvIIHNOT32o5xgvUhsrBg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduuddrudefkedguddttdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpeffhffvuffkfhggtggugfgjfgesthekredttderudenucfhrhhomhepifhr vghgucfmjfcuoehgrhgvgheskhhrohgrhhdrtghomheqnecukfhppeekfedrkeeirdekle druddtjeenucfrrghrrghmpehmrghilhhfrhhomhepghhrvghgsehkrhhorghhrdgtohhm necuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) by mail.messagingengine.com (Postfix) with ESMTPA id CEBED380083; Tue, 4 Jun 2019 01:48:11 -0400 (EDT) Date: Tue, 4 Jun 2019 07:48:09 +0200 From: Greg KH To: Juergen Gross Message-ID: <20190604054809.GA16504@kroah.com> References: <1559229415.24330.2.camel@codethink.co.uk> <0e6ebb5c-ff43-6d65-bcba-6ac5e60aa472@oracle.com> <20190603080036.GF7814@kroah.com> <1559563359.24330.8.camel@codethink.co.uk> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.12.0 (2019-05-25) Subject: Re: [Xen-devel] [stable] xen/pciback: Don't disable PCI_COMMAND on PCI device reset. X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Prarit Bhargava , xen-devel@lists.xenproject.org, Ben Hutchings , stable , Konrad Rzeszutek Wilk Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" T24gTW9uLCBKdW4gMDMsIDIwMTkgYXQgMDM6MTA6NTVQTSArMDIwMCwgSnVlcmdlbiBHcm9zcyB3 cm90ZToKPiBPbiAwMy8wNi8yMDE5IDE0OjAyLCBCZW4gSHV0Y2hpbmdzIHdyb3RlOgo+ID4gT24g TW9uLCAyMDE5LTA2LTAzIGF0IDEwOjAwICswMjAwLCBHcmVnIEtIIHdyb3RlOgo+ID4+IE9uIFRo dSwgTWF5IDMwLCAyMDE5IGF0IDA3OjAyOjM0UE0gLTA3MDAsIEtvbnJhZCBSemVzenV0ZWsgV2ls ayB3cm90ZToKPiA+Pj4gT24gNS8zMC8xOSA4OjE2IEFNLCBCZW4gSHV0Y2hpbmdzIHdyb3RlOgo+ ID4+Pj4gSSdtIGxvb2tpbmcgYXQgQ1ZFLTIwMTUtODU1MyB3aGljaCBpcyBmaXhlZCBieToKPiA+ Pj4+Cj4gPj4+PiBjb21taXQgNzY4MWYzMWVjOWNkYWNhYjRmZDEwNTcwYmU5MjRmMmNlZjY2Njli YQo+ID4+Pj4gQXV0aG9yOiBLb25yYWQgUnplc3p1dGVrIFdpbGsgPGtvbnJhZC53aWxrQG9yYWNs ZS5jb20+Cj4gPj4+PiBEYXRlOsKgwqDCoFdlZCBGZWIgMTMgMTg6MjE6MzEgMjAxOSAtMDUwMAo+ ID4+Pj4KPiA+Pj4+IMKgwqDCoMKgwqB4ZW4vcGNpYmFjazogRG9uJ3QgZGlzYWJsZSBQQ0lfQ09N TUFORCBvbiBQQ0kgZGV2aWNlIHJlc2V0Lgo+ID4+Pj4KPiA+Pj4+IEknbSBhd2FyZSB0aGF0IHRo aXMgY2hhbmdlIGlzIGluY29tcGF0aWJsZSB3aXRoIHFlbXUgPCAyLjUsIGJ1dCB0aGF0J3MKPiA+ Pj4+IG5vdyBxdWl0ZSBvbGQuwqDCoERvIHlvdSB0aGluayBpdCBtYWtlcyBzZW5zZSB0byBhcHBs eSB0aGlzIGNoYW5nZSB0bwo+ID4+Pj4gc29tZSBzdGFibGUgYnJhbmNoZXM/Cj4gPj4+Pgo+ID4+ Pj4gQmVuLgo+ID4+Pj4KPiA+Pj4KPiA+Pj4gSGV5IEJlbiwKPiA+Pj4KPiA+Pj4gPHNocnVncz4g TXkgb3BpbmlvbiBpcyB0byBkcm9wIGl0LCBidXQgaWYgSnVlcmdlbiB0aGlua3MgaXQgbWFrZXMg c2Vuc2UgdG8KPiA+Pj4gYmFja3BvcnQgSSBhbSBub3QgZ29pbmcgdG8gYXJndWUuCj4gPj4KPiA+ PiBPaywgSSd2ZSBxdWV1ZWQgdGhpcyB1cCBub3csIHRoYW5rcy4KPiA+IAo+ID4gSnVlcmdlbiBz YWlkOgo+ID4gCj4gPj4gSSdtIHdpdGggS29ucmFkIGhlcmUuCj4gPiAKPiA+IHNvIHVubGVzcyBJ J20gdmVyeSBjb25mdXNlZCB0aGlzIHNob3VsZCAqbm90KiBiZSBhcHBsaWVkIHRvIHN0YWJsZQo+ ID4gYnJhbmNoZXMuCj4gCj4gInNob3VsZCBub3QiIGlzIGEgbGl0dGxlIGJpdCBoYXJkLiBJIGRp ZG4ndCBvcHQgZm9yIGFkZGluZyBpdCwgYnV0IEkKPiBkb24ndCBvYmplY3QgdG8gYWRkIGl0IGVp dGhlciAobGlrZSBLb25yYWQgOi0pICkuCgpPaywgSSd2ZSBhZGRlZCBpdCBhcyBpdCBkb2VzIGZp eCBhIENWRSwgYW5kIGlmIEkgZG9uJ3QsIEknbGwgZ2V0IG9kZAplbWFpbHMgNiBtb250aHMgZnJv bSBub3cgYXNraW5nIHdoeSBJIGRpZG4ndCBpbmNsdWRlIGl0Li4uCgp0aGFua3MsCgpncmVnIGst aAoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRl dmVsIG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVucHJvamVjdC5vcmcKaHR0cHM6Ly9s aXN0cy54ZW5wcm9qZWN0Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL3hlbi1kZXZlbA== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C99C2C282CE for ; Tue, 4 Jun 2019 05:48:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 91A342064A for ; Tue, 4 Jun 2019 05:48:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=kroah.com header.i=@kroah.com header.b="oaHBm6XD"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="GZ1FyG62" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726528AbfFDFsO (ORCPT ); Tue, 4 Jun 2019 01:48:14 -0400 Received: from wout1-smtp.messagingengine.com ([64.147.123.24]:45249 "EHLO wout1-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726488AbfFDFsO (ORCPT ); Tue, 4 Jun 2019 01:48:14 -0400 Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.west.internal (Postfix) with ESMTP id 5BA42543; Tue, 4 Jun 2019 01:48:13 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute6.internal (MEProxy); Tue, 04 Jun 2019 01:48:13 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kroah.com; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:content-transfer-encoding:in-reply-to; s=fm3; bh=T CaT+Fn47+ujhoKgN9BqRZfA99WODN1m/1NIm/vdRH8=; b=oaHBm6XDYjYnIR1+T tDP6lz3rPXXNul0GO6vfZa9L/L0jmBs0+qYGxIQnA08yiWcMtzGgEJlXssupUOWk IXiXTc7PRBQRY8LN2/u5T9nI1Gc58f2Y+HocDeVesocNpudlktWBKYFqrc8DWBYQ 5T8byHPpvDvi0U/aqtts5/dEkHgnDE6uwCEI8NtaEUsa7dzTm8LdHXXccCSo5DJd DcpcQZug2TO0gunHcVwPYJBuXCyAEerKpju7cSNY+oK7yNc4D5DLNb/9D9OUB9Lq FvPKvahrP7eOBp/EexPhywS/N8HhKe1+bohaYPKCBirPf/w19szbXlsmREwh9Nik wyn9g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=TCaT+Fn47+ujhoKgN9BqRZfA99WODN1m/1NIm/vdR H8=; b=GZ1FyG62s1xexwpPe4FC5Q62hK982P/nBwXKoBo/2LnNCaW3a8jrInxUP ARtfThVhX0ddEKj/QQTMSwRy92rmVXFTbqKE7t82LRu10VAo7CZXphwOTw+DW8Rd Ff6DUipkbo5YI4EQOUfzQcWI4d535crAFOp8aLrTINByquHyunwRESbSU+2uFB6k cgSLpRmIDnk+c5uygok/Yf8oWKKuoDv/JTrXuiKjQr4PaI9BFWtBeHsGJu3b/aWO UgINRDDsf1Kww2ql/jndm+FpH1YxGFGlisyuif+OBKgGDDSxBc5DuVD4lSuucuys kJBI0TTvpvIIHNOT32o5xgvUhsrBg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduuddrudefkedguddttdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpeffhffvuffkfhggtggugfgjfgesthekredttderudenucfhrhhomhepifhr vghgucfmjfcuoehgrhgvgheskhhrohgrhhdrtghomheqnecukfhppeekfedrkeeirdekle druddtjeenucfrrghrrghmpehmrghilhhfrhhomhepghhrvghgsehkrhhorghhrdgtohhm necuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) by mail.messagingengine.com (Postfix) with ESMTPA id CEBED380083; Tue, 4 Jun 2019 01:48:11 -0400 (EDT) Date: Tue, 4 Jun 2019 07:48:09 +0200 From: Greg KH To: Juergen Gross Cc: Ben Hutchings , Prarit Bhargava , xen-devel@lists.xenproject.org, stable , Konrad Rzeszutek Wilk Subject: Re: [stable] xen/pciback: Don't disable PCI_COMMAND on PCI device reset. Message-ID: <20190604054809.GA16504@kroah.com> References: <1559229415.24330.2.camel@codethink.co.uk> <0e6ebb5c-ff43-6d65-bcba-6ac5e60aa472@oracle.com> <20190603080036.GF7814@kroah.com> <1559563359.24330.8.camel@codethink.co.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.12.0 (2019-05-25) Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Mon, Jun 03, 2019 at 03:10:55PM +0200, Juergen Gross wrote: > On 03/06/2019 14:02, Ben Hutchings wrote: > > On Mon, 2019-06-03 at 10:00 +0200, Greg KH wrote: > >> On Thu, May 30, 2019 at 07:02:34PM -0700, Konrad Rzeszutek Wilk wrote: > >>> On 5/30/19 8:16 AM, Ben Hutchings wrote: > >>>> I'm looking at CVE-2015-8553 which is fixed by: > >>>> > >>>> commit 7681f31ec9cdacab4fd10570be924f2cef6669ba > >>>> Author: Konrad Rzeszutek Wilk > >>>> Date:   Wed Feb 13 18:21:31 2019 -0500 > >>>> > >>>>      xen/pciback: Don't disable PCI_COMMAND on PCI device reset. > >>>> > >>>> I'm aware that this change is incompatible with qemu < 2.5, but that's > >>>> now quite old.  Do you think it makes sense to apply this change to > >>>> some stable branches? > >>>> > >>>> Ben. > >>>> > >>> > >>> Hey Ben, > >>> > >>> My opinion is to drop it, but if Juergen thinks it makes sense to > >>> backport I am not going to argue. > >> > >> Ok, I've queued this up now, thanks. > > > > Juergen said: > > > >> I'm with Konrad here. > > > > so unless I'm very confused this should *not* be applied to stable > > branches. > > "should not" is a little bit hard. I didn't opt for adding it, but I > don't object to add it either (like Konrad :-) ). Ok, I've added it as it does fix a CVE, and if I don't, I'll get odd emails 6 months from now asking why I didn't include it... thanks, greg k-h