From: Christoph Hellwig <hch@infradead.org>
To: Pingfan Liu <kernelfans@gmail.com>
Cc: Christoph Hellwig <hch@infradead.org>,
linux-mm@kvack.org, Ira Weiny <ira.weiny@intel.com>,
Andrew Morton <akpm@linux-foundation.org>,
Mike Rapoport <rppt@linux.ibm.com>,
Dan Williams <dan.j.williams@intel.com>,
Matthew Wilcox <willy@infradead.org>,
John Hubbard <jhubbard@nvidia.com>,
"Aneesh Kumar K.V" <aneesh.kumar@linux.ibm.com>,
Keith Busch <keith.busch@intel.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCHv2 1/2] mm/gup: fix omission of check on FOLL_LONGTERM in get_user_pages_fast()
Date: Tue, 4 Jun 2019 00:17:31 -0700 [thread overview]
Message-ID: <20190604071731.GA10044@infradead.org> (raw)
In-Reply-To: <CAFgQCTtUdeq=M=SrVwvggR15Yk+i=ndLkhkw1dxJa7miuDp_AA@mail.gmail.com>
On Tue, Jun 04, 2019 at 03:13:21PM +0800, Pingfan Liu wrote:
> Is it a convention? scripts/checkpatch.pl can not detect it. Could you
> show me some light so later I can avoid it?
If you look at most kernel code you can see two conventions:
- double tabe indent
- indent to the start of the first agument line
Everything else is rather unusual.
next prev parent reply other threads:[~2019-06-04 7:17 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-03 6:34 [PATCHv2 1/2] mm/gup: fix omission of check on FOLL_LONGTERM in get_user_pages_fast() Pingfan Liu
2019-06-03 6:34 ` [PATCHv2 2/2] mm/gup: rename nr as nr_pinned " Pingfan Liu
2019-06-03 15:02 ` Ira Weiny
2019-06-03 15:00 ` [PATCHv2 1/2] mm/gup: fix omission of check on FOLL_LONGTERM " Ira Weiny
2019-06-03 16:42 ` Christoph Hellwig
2019-06-03 18:43 ` John Hubbard
2019-06-03 23:56 ` Ira Weiny
2019-06-04 7:08 ` Christoph Hellwig
2019-06-04 7:24 ` Pingfan Liu
2019-06-04 16:55 ` Ira Weiny
2019-06-04 19:38 ` John Hubbard
2019-06-04 19:29 ` John Hubbard
2019-06-04 7:13 ` Pingfan Liu
2019-06-04 7:17 ` Christoph Hellwig [this message]
2019-06-04 7:20 ` Pingfan Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190604071731.GA10044@infradead.org \
--to=hch@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=aneesh.kumar@linux.ibm.com \
--cc=dan.j.williams@intel.com \
--cc=ira.weiny@intel.com \
--cc=jhubbard@nvidia.com \
--cc=keith.busch@intel.com \
--cc=kernelfans@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=rppt@linux.ibm.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.