From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg Kroah-Hartman Subject: Re: [PATCH v4] usb: create usb_debug_root for gadget only Date: Tue, 4 Jun 2019 10:24:07 +0200 Message-ID: <20190604082407.GA3783@kroah.com> References: <1559633647-29040-1-git-send-email-chunfeng.yun@mediatek.com> <20190604073706.GA25045@kroah.com> <87k1e123mc.fsf@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <87k1e123mc.fsf@linux.intel.com> Sender: linux-kernel-owner@vger.kernel.org To: Felipe Balbi Cc: Chunfeng Yun , Matthias Brugger , linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org List-Id: linux-mediatek@lists.infradead.org On Tue, Jun 04, 2019 at 10:47:55AM +0300, Felipe Balbi wrote: > > Hi, > > Greg Kroah-Hartman writes: > >> +struct dentry *usb_debugfs_init(void) > >> +{ > >> + if (!usb_debug_root) > >> + usb_debug_root = debugfs_create_dir("usb", NULL); > >> + > >> + atomic_inc(&usb_debug_root_refcnt); > >> + > >> + return usb_debug_root; > >> +} > >> +EXPORT_SYMBOL_GPL(usb_debugfs_init); > >> + > >> +void usb_debugfs_cleanup(void) > >> +{ > >> + if (atomic_dec_and_test(&usb_debug_root_refcnt)) { > >> + debugfs_remove_recursive(usb_debug_root); > >> + usb_debug_root = NULL; > >> + } > >> +} > >> +EXPORT_SYMBOL_GPL(usb_debugfs_cleanup); > > > > Only remove the debugfs subdir if the usbcore module is removed. Create > > the debugfs subdir when the usbcore module is loaded. No need for any > > reference counting of any sort at all. No need to overthink this :) > > There is a slight need to overthink. He wants to use the same directory > for gadget-only builds too :-) Again, that's fine, this file will be loaded for those builds as well, right? Otherwise, how would this code even be present? :) thanks, greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, T_DKIMWL_WL_HIGH,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8364DC282CE for ; Tue, 4 Jun 2019 08:24:18 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5882323E3B for ; Tue, 4 Jun 2019 08:24:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="LVHjnrQN"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="pw0FhfzT" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5882323E3B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=dR7niWG/CmJrhp7tsqmaFdHBjhtv8LZwNOgyI1UeNcY=; b=LVHjnrQN7EQnGd Aa5aYQCms62k3AQJHFYH3+nw0fAYVWVS/kYr99rxdBXuIVng5kSrsgMv6WtIhMzVPpgoDQVRLMwur IxeX+fnK22YZ7YaHR0ihTb3xOS0gkhFCMS+UK8i7BORCrnljBaDIskX9HKqA2dN5UenC1aJMReQUa cUYnEWg4D0MvA3vZ6rGK2aHoZ+LmTnEcsIjUEr0HbqNHbEYSLygXgtrNA+hY0OhX6J01KCQb7zJv2 Iy4dc+Bj91nrUdITxBlxMplRDR1xYCxwtJjT2Z9YqsXWDTAlmCvWYKo0VbkRrHCwiOXUT+waqFYz2 v0gSXsC4LE3pBGt8Swiw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hY4jt-0006Dc-Rw; Tue, 04 Jun 2019 08:24:13 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hY4jq-0006DG-9B; Tue, 04 Jun 2019 08:24:11 +0000 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5C76423CCA; Tue, 4 Jun 2019 08:24:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1559636649; bh=6slerfuNDoj7Is3gV1c++tUMoScJL8Np9rrWGf3bwEA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=pw0FhfzT3SowGqAs0l+j0iJWvItPv9FKYOSML2mpYzvbDof5UrR+5denSGgQQVuki fFuryBzfBU4uCZOyvIOnnbCd5c6MKY9rHsQvHf9KfeS8aq2Sn6NX0RYuYn/x3dQDcF yDZh82G+aEB+uVzt6qhfr5ir0z309DLzk/ERXiMU= Date: Tue, 4 Jun 2019 10:24:07 +0200 From: Greg Kroah-Hartman To: Felipe Balbi Subject: Re: [PATCH v4] usb: create usb_debug_root for gadget only Message-ID: <20190604082407.GA3783@kroah.com> References: <1559633647-29040-1-git-send-email-chunfeng.yun@mediatek.com> <20190604073706.GA25045@kroah.com> <87k1e123mc.fsf@linux.intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <87k1e123mc.fsf@linux.intel.com> User-Agent: Mutt/1.12.0 (2019-05-25) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190604_012410_529379_9EC043D7 X-CRM114-Status: GOOD ( 12.68 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Matthias Brugger , linux-mediatek@lists.infradead.org, Chunfeng Yun , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Jun 04, 2019 at 10:47:55AM +0300, Felipe Balbi wrote: > > Hi, > > Greg Kroah-Hartman writes: > >> +struct dentry *usb_debugfs_init(void) > >> +{ > >> + if (!usb_debug_root) > >> + usb_debug_root = debugfs_create_dir("usb", NULL); > >> + > >> + atomic_inc(&usb_debug_root_refcnt); > >> + > >> + return usb_debug_root; > >> +} > >> +EXPORT_SYMBOL_GPL(usb_debugfs_init); > >> + > >> +void usb_debugfs_cleanup(void) > >> +{ > >> + if (atomic_dec_and_test(&usb_debug_root_refcnt)) { > >> + debugfs_remove_recursive(usb_debug_root); > >> + usb_debug_root = NULL; > >> + } > >> +} > >> +EXPORT_SYMBOL_GPL(usb_debugfs_cleanup); > > > > Only remove the debugfs subdir if the usbcore module is removed. Create > > the debugfs subdir when the usbcore module is loaded. No need for any > > reference counting of any sort at all. No need to overthink this :) > > There is a slight need to overthink. He wants to use the same directory > for gadget-only builds too :-) Again, that's fine, this file will be loaded for those builds as well, right? Otherwise, how would this code even be present? :) thanks, greg k-h _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel