From: Jesse Brandeburg <jesse.brandeburg@intel.com>
To: Xue Chaojing <xuechaojing@huawei.com>
Cc: <davem@davemloft.net>, <linux-kernel@vger.kernel.org>,
<netdev@vger.kernel.org>, <luoshaokai@huawei.com>,
<cloud.wangxiaoyun@huawei.com>, <chiqijun@huawei.com>,
<wulike1@huawei.com>
Subject: Re: [PATCH net-next v4] hinic: add LRO support
Date: Tue, 4 Jun 2019 09:08:41 -0700 [thread overview]
Message-ID: <20190604090841.00007d28@intel.com> (raw)
In-Reply-To: <20190604011608.26485-1-xuechaojing@huawei.com>
On Tue, 4 Jun 2019 01:16:08 +0000 Xue wrote:
> This patch adds LRO support for the HiNIC driver.
>
> Reported-by: kbuild test robot <lkp@intel.com>
> Reviewed-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
> Signed-off-by: Xue Chaojing <xuechaojing@huawei.com>
Hm, you added my reviewed-by tag, but I didn't add it myself, I
only commented on your code. This is a no-no. You don't add tags with
other people's names just because you think you can/should.
If someone EXPLICITLY says: "go ahead and add my reviewed-by after these
changes" then you can add it yourself.
Also, what did you change in v1:v4? There should be a summary somewhere
in the commit log (usually after a ---)
FWIW, I looked over the code and my concerns were addressed.
Reviewed-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
next prev parent reply other threads:[~2019-06-04 16:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-04 1:16 [PATCH net-next v4] hinic: add LRO support Xue Chaojing
2019-06-04 16:08 ` Jesse Brandeburg [this message]
2019-06-04 21:52 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190604090841.00007d28@intel.com \
--to=jesse.brandeburg@intel.com \
--cc=chiqijun@huawei.com \
--cc=cloud.wangxiaoyun@huawei.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=luoshaokai@huawei.com \
--cc=netdev@vger.kernel.org \
--cc=wulike1@huawei.com \
--cc=xuechaojing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.