From mboxrd@z Thu Jan 1 00:00:00 1970 From: Boris Brezillon Subject: Re: [PATCH v4 0/5] drm: Fix fb changes for async updates Date: Tue, 4 Jun 2019 10:32:11 +0200 Message-ID: <20190604103211.7a42be9b@collabora.com> References: <20190603165610.24614-1-helen.koike@collabora.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20190603165610.24614-1-helen.koike@collabora.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Helen Koike Cc: Sean Paul , Christian =?UTF-8?B?S8O2bmln?= , David Airlie , daniel.vetter@ffwll.ch, dri-devel@lists.freedesktop.org, Mamta Shukla , kernel@collabora.com, Anthony Koo , Bhawanpreet Lakha , David Francis , amd-gfx@lists.freedesktop.org, linux-rockchip@lists.infradead.org, Leo Li , linux-arm-msm@vger.kernel.org, Maxime Ripard , Sean Paul , linux-arm-kernel@lists.infradead.org, =?UTF-8?B?U3TDqXBoYW5l?= Marchesin , linux-kernel@vger.kernel.org, Tomasz Figa , Thomas Zimmermann , Alex Deucher , freedreno@lists.freedesktop.org, nicholas.kazlauskas@amd.com List-Id: amd-gfx.lists.freedesktop.org T24gTW9uLCAgMyBKdW4gMjAxOSAxMzo1NjowNSAtMDMwMApIZWxlbiBLb2lrZSA8aGVsZW4ua29p a2VAY29sbGFib3JhLmNvbT4gd3JvdGU6Cgo+IEhlbGxvLAo+IAo+IEknbSByZS1zZW5kaW5nIHRo aXMgc2VyaWVzIHdpdGggdGhlIGFja2VkIGJ5IGluIHRoZSBtc20gcGF0Y2ggYW5kCj4gdXBkYXRp bmcgdGhlIGRvY3MgaW4gdGhlIGxhc3QgcGF0Y2gsIHRoZSByZXN0IGlzIHRoZSBzYW1lLgo+IAo+ IHYzIGxpbms6IGh0dHBzOi8vcGF0Y2h3b3JrLmtlcm5lbC5vcmcvcHJvamVjdC9kcmktZGV2ZWwv bGlzdC8/c2VyaWVzPTkxMzUzCgpTZXJpZXMgcXVldWVkIHRvIGRybS1taXNjLWZpeGVzLgoKPiAK PiBUaGFua3MhCj4gSGVsZW4KPiAKPiBDaGFuZ2VzIGluIHY0Ogo+IC0gYWRkIGFja2VkIGJ5IHRh Zwo+IC0gdXBkYXRlIGRvY3MgaW4gYXRvbWljX2FzeW5jX3VwZGF0ZSBjYWxsYmFjawo+IAo+IENo YW5nZXMgaW4gdjM6Cj4gLSB1c2Ugc3dhcCgpIHRvIHN3YXAgb2xkIGFuZCBuZXcgZnJhbWVidWZm ZXJzIGluIGFzeW5jX3VwZGF0ZQo+IC0gZ2V0IHRoZSByZWZlcmVuY2UgdG8gb2xkX2ZiIGFuZCBz ZXQgdGhlIHdvcmtlciBhZnRlciB2b3BfcGxhbmVfYXRvbWljX3VwZGF0ZSgpCj4gLSBhZGQgYSBG SVhNRSB0YWcgZm9yIHdoZW4gd2UgaGF2ZSBtdWx0aXBsZSBmYnMgdG8gYmUgcmVsZWFzZWQgd2hl bgo+IHZibGFuayBoYXBwZW5zLgo+IC0gdXBkYXRlIGNvbW1pdCBtZXNzYWdlCj4gLSBBZGQgUmV2 aWV3ZWQtYnkgdGFncwo+IC0gQWRkIFRPRE8gaW4gZHJtX2F0b21pY19oZWxwZXJfYXN5bmNfY29t bWl0KCkKPiAKPiBDaGFuZ2VzIGluIHYyOgo+IC0gYWRkZWQgcmV2aWV3ZWQtYnkgdGFnCj4gLSB1 cGRhdGUgQ0Mgc3RhYmxlIGFuZCBGaXhlcyB0YWcKPiAtIEFkZGVkIHJldmlld2VkLWJ5IHRhZwo+ IC0gdXBkYXRlZCBDQyBzdGFibGUgYW5kIEZpeGVzIHRhZwo+IC0gQ2hhbmdlIHRoZSBvcmRlciBv ZiB0aGUgcGF0Y2ggaW4gdGhlIHNlcmllcywgYWRkIHRoaXMgYXMgdGhlIGxhc3Qgb25lLgo+IC0g QWRkIGRvY3VtZW50YXRpb24KPiAtIHMvYmFsbGFuY2VkL2JhbGFuY2VkCj4gCj4gSGVsZW4gS29p a2UgKDUpOgo+ICAgZHJtL3JvY2tjaGlwOiBmaXggZmIgcmVmZXJlbmNlcyBpbiBhc3luYyB1cGRh dGUKPiAgIGRybS9hbWQ6IGZpeCBmYiByZWZlcmVuY2VzIGluIGFzeW5jIHVwZGF0ZQo+ICAgZHJt L21zbTogZml4IGZiIHJlZmVyZW5jZXMgaW4gYXN5bmMgdXBkYXRlCj4gICBkcm0vdmM0OiBmaXgg ZmIgcmVmZXJlbmNlcyBpbiBhc3luYyB1cGRhdGUKPiAgIGRybTogZG9uJ3QgYmxvY2sgZmIgY2hh bmdlcyBmb3IgYXN5bmMgcGxhbmUgdXBkYXRlcwo+IAo+ICAuLi4vZ3B1L2RybS9hbWQvZGlzcGxh eS9hbWRncHVfZG0vYW1kZ3B1X2RtLmMgfCAgMyArLQo+ICBkcml2ZXJzL2dwdS9kcm0vZHJtX2F0 b21pY19oZWxwZXIuYyAgICAgICAgICAgfCAyMiArKysrLS0tLQo+ICBkcml2ZXJzL2dwdS9kcm0v bXNtL2Rpc3AvbWRwNS9tZHA1X3BsYW5lLmMgICAgfCAgNCArKwo+ICBkcml2ZXJzL2dwdS9kcm0v cm9ja2NoaXAvcm9ja2NoaXBfZHJtX3ZvcC5jICAgfCA1MSArKysrKysrKysrLS0tLS0tLS0tCj4g IGRyaXZlcnMvZ3B1L2RybS92YzQvdmM0X3BsYW5lLmMgICAgICAgICAgICAgICB8ICAyICstCj4g IGluY2x1ZGUvZHJtL2RybV9tb2Rlc2V0X2hlbHBlcl92dGFibGVzLmggICAgICB8ICA4ICsrKwo+ ICA2IGZpbGVzIGNoYW5nZWQsIDUyIGluc2VydGlvbnMoKyksIDM4IGRlbGV0aW9ucygtKQo+IAoK X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVs From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C686FC282CE for ; Tue, 4 Jun 2019 08:32:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 99E3A24A57 for ; Tue, 4 Jun 2019 08:32:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726840AbfFDIcT (ORCPT ); Tue, 4 Jun 2019 04:32:19 -0400 Received: from bhuna.collabora.co.uk ([46.235.227.227]:40654 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726828AbfFDIcT (ORCPT ); Tue, 4 Jun 2019 04:32:19 -0400 Received: from localhost (unknown [IPv6:2a01:e0a:2c:6930:5cf4:84a1:2763:fe0d]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: bbrezillon) by bhuna.collabora.co.uk (Postfix) with ESMTPSA id 8C467260E1F; Tue, 4 Jun 2019 09:32:15 +0100 (BST) Date: Tue, 4 Jun 2019 10:32:11 +0200 From: Boris Brezillon To: Helen Koike Cc: dri-devel@lists.freedesktop.org, nicholas.kazlauskas@amd.com, andrey.grodzovsky@amd.com, daniel.vetter@ffwll.ch, linux-kernel@vger.kernel.org, Tomasz Figa , David Airlie , Sean Paul , kernel@collabora.com, harry.wentland@amd.com, =?UTF-8?B?U3TDqXBoYW5l?= Marchesin , Sean Paul , Sandy Huang , Thomas Zimmermann , eric@anholt.net, Alex Deucher , Bhawanpreet Lakha , "David (ChunMing) Zhou" , Anthony Koo , amd-gfx@lists.freedesktop.org, linux-rockchip@lists.infradead.org, Ville =?UTF-8?B?U3lyasOkbMOk?= , Rob Clark , Christian =?UTF-8?B?S8O2bmln?= , Leo Li , linux-arm-msm@vger.kernel.org, Jeykumar Sankaran , Heiko =?UTF-8?B?U3TDvGJuZXI=?= , Maarten Lankhorst , linux-arm-kernel@lists.infradead.org, David Francis , Mario Kleiner , Maxime Ripard , freedreno@lists.freedesktop.org, Mamta Shukla , Daniel Vetter Subject: Re: [PATCH v4 0/5] drm: Fix fb changes for async updates Message-ID: <20190604103211.7a42be9b@collabora.com> In-Reply-To: <20190603165610.24614-1-helen.koike@collabora.com> References: <20190603165610.24614-1-helen.koike@collabora.com> Organization: Collabora X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Mon, 3 Jun 2019 13:56:05 -0300 Helen Koike wrote: > Hello, > > I'm re-sending this series with the acked by in the msm patch and > updating the docs in the last patch, the rest is the same. > > v3 link: https://patchwork.kernel.org/project/dri-devel/list/?series=91353 Series queued to drm-misc-fixes. > > Thanks! > Helen > > Changes in v4: > - add acked by tag > - update docs in atomic_async_update callback > > Changes in v3: > - use swap() to swap old and new framebuffers in async_update > - get the reference to old_fb and set the worker after vop_plane_atomic_update() > - add a FIXME tag for when we have multiple fbs to be released when > vblank happens. > - update commit message > - Add Reviewed-by tags > - Add TODO in drm_atomic_helper_async_commit() > > Changes in v2: > - added reviewed-by tag > - update CC stable and Fixes tag > - Added reviewed-by tag > - updated CC stable and Fixes tag > - Change the order of the patch in the series, add this as the last one. > - Add documentation > - s/ballanced/balanced > > Helen Koike (5): > drm/rockchip: fix fb references in async update > drm/amd: fix fb references in async update > drm/msm: fix fb references in async update > drm/vc4: fix fb references in async update > drm: don't block fb changes for async plane updates > > .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 3 +- > drivers/gpu/drm/drm_atomic_helper.c | 22 ++++---- > drivers/gpu/drm/msm/disp/mdp5/mdp5_plane.c | 4 ++ > drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 51 ++++++++++--------- > drivers/gpu/drm/vc4/vc4_plane.c | 2 +- > include/drm/drm_modeset_helper_vtables.h | 8 +++ > 6 files changed, 52 insertions(+), 38 deletions(-) > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, T_DKIMWL_WL_HIGH,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 81AD6C282CE for ; Tue, 4 Jun 2019 08:32:26 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 584CA23C07 for ; Tue, 4 Jun 2019 08:32:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="HRCR6njx" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 584CA23C07 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=collabora.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=LFDIXHRLM24VHKHBIXZOwc5cjMwqgxAk12WSR0Hp2NU=; b=HRCR6njxqDEgzO TTKUuAS1T8I3k7Np4KAo6H5jf0W6K/Ny0RodG19P+/NUL2/7Hju9SffruMS6stqnaQe9A3Za79yth oEds2AsRuGhkHfQfzPVjiqUag4vLDD29GP5nh4pwiDPFAEaB1GjZWYbUy2LSGG0oFmR6U+jOt+wGB Kud/FLh67efnSuHiH/Kq67WaIDcDBHBVLcEU3ksBH8xJ4QRXaIISod1lUf4qbujbNh0KYzn0zEuSA ZVCDNeqFadTjtAOzV9kkT5DzLJsyKMNHnQghX+0OlqojuDsltVHKz0EnkIQKqPywHP50PEOe89JHO iLhC8ULZy/l8D03c1CLQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hY4rm-0001gh-0k; Tue, 04 Jun 2019 08:32:22 +0000 Received: from bhuna.collabora.co.uk ([46.235.227.227]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hY4ri-0001gJ-B5; Tue, 04 Jun 2019 08:32:20 +0000 Received: from localhost (unknown [IPv6:2a01:e0a:2c:6930:5cf4:84a1:2763:fe0d]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: bbrezillon) by bhuna.collabora.co.uk (Postfix) with ESMTPSA id 8C467260E1F; Tue, 4 Jun 2019 09:32:15 +0100 (BST) Date: Tue, 4 Jun 2019 10:32:11 +0200 From: Boris Brezillon To: Helen Koike Subject: Re: [PATCH v4 0/5] drm: Fix fb changes for async updates Message-ID: <20190604103211.7a42be9b@collabora.com> In-Reply-To: <20190603165610.24614-1-helen.koike@collabora.com> References: <20190603165610.24614-1-helen.koike@collabora.com> Organization: Collabora X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190604_013218_640125_243F3E2D X-CRM114-Status: GOOD ( 15.86 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Heiko =?UTF-8?B?U3TDvGJuZXI=?= , Sean Paul , Christian =?UTF-8?B?S8O2bmln?= , David Airlie , daniel.vetter@ffwll.ch, dri-devel@lists.freedesktop.org, Sandy Huang , eric@anholt.net, Mamta Shukla , kernel@collabora.com, Anthony Koo , Ville =?UTF-8?B?U3lyasOkbMOk?= , "David \(ChunMing\) Zhou" , Mario Kleiner , Bhawanpreet Lakha , David Francis , amd-gfx@lists.freedesktop.org, linux-rockchip@lists.infradead.org, harry.wentland@amd.com, andrey.grodzovsky@amd.com, Daniel Vetter , Leo Li , linux-arm-msm@vger.kernel.org, Maarten Lankhorst , Maxime Ripard , Jeykumar Sankaran , Sean Paul , linux-arm-kernel@lists.infradead.org, =?UTF-8?B?U3TDqXBoYW5l?= Marchesin , linux-kernel@vger.kernel.org, Tomasz Figa , Rob Clark , Thomas Zimmermann , Alex Deucher , freedreno@lists.freedesktop.org, nicholas.kazlauskas@amd.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, 3 Jun 2019 13:56:05 -0300 Helen Koike wrote: > Hello, > > I'm re-sending this series with the acked by in the msm patch and > updating the docs in the last patch, the rest is the same. > > v3 link: https://patchwork.kernel.org/project/dri-devel/list/?series=91353 Series queued to drm-misc-fixes. > > Thanks! > Helen > > Changes in v4: > - add acked by tag > - update docs in atomic_async_update callback > > Changes in v3: > - use swap() to swap old and new framebuffers in async_update > - get the reference to old_fb and set the worker after vop_plane_atomic_update() > - add a FIXME tag for when we have multiple fbs to be released when > vblank happens. > - update commit message > - Add Reviewed-by tags > - Add TODO in drm_atomic_helper_async_commit() > > Changes in v2: > - added reviewed-by tag > - update CC stable and Fixes tag > - Added reviewed-by tag > - updated CC stable and Fixes tag > - Change the order of the patch in the series, add this as the last one. > - Add documentation > - s/ballanced/balanced > > Helen Koike (5): > drm/rockchip: fix fb references in async update > drm/amd: fix fb references in async update > drm/msm: fix fb references in async update > drm/vc4: fix fb references in async update > drm: don't block fb changes for async plane updates > > .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 3 +- > drivers/gpu/drm/drm_atomic_helper.c | 22 ++++---- > drivers/gpu/drm/msm/disp/mdp5/mdp5_plane.c | 4 ++ > drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 51 ++++++++++--------- > drivers/gpu/drm/vc4/vc4_plane.c | 2 +- > include/drm/drm_modeset_helper_vtables.h | 8 +++ > 6 files changed, 52 insertions(+), 38 deletions(-) > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel