From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= <ville.syrjala@linux.intel.com>
Subject: Re: [PATCH 2/4] drm/i915/dsi: Move logging of DSI VBT
 parameters to a helper function
Date: Tue, 4 Jun 2019 20:36:32 +0300
Message-ID: <20190604173632.GJ5942@intel.com>
References: <20190524163020.17099-1-hdegoede@redhat.com>
 <20190524163020.17099-3-hdegoede@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Content-Disposition: inline
In-Reply-To: <20190524163020.17099-3-hdegoede@redhat.com>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Hans de Goede <hdegoede@redhat.com>
Cc: intel-gfx <intel-gfx@lists.freedesktop.org>, dri-devel@lists.freedesktop.org, Daniel Vetter <daniel.vetter@intel.com>
List-Id: dri-devel@lists.freedesktop.org

T24gRnJpLCBNYXkgMjQsIDIwMTkgYXQgMDY6MzA6MThQTSArMDIwMCwgSGFucyBkZSBHb2VkZSB3
cm90ZToKPiBUaGlzIGlzIGEgcHJlcGFyYXRpb24gcGF0Y2ggZm9yIG1vdmluZyB0aGUgY2FsbGlu
ZyBvZiAqX2RwaHlfcGFyYW1faW5pdCgpCj4gb3V0IG9mIGludGVsX2RzaV92YnRfaW5pdC4KPiAK
PiBTaWduZWQtb2ZmLWJ5OiBIYW5zIGRlIEdvZWRlIDxoZGVnb2VkZUByZWRoYXQuY29tPgoKUmV2
aWV3ZWQtYnk6IFZpbGxlIFN5cmrDpGzDpCA8dmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20+
Cgo+IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kc2lfdmJ0LmMgfCA3NyArKysr
KysrKysrKysrKystLS0tLS0tLS0tLS0tCj4gIDEgZmlsZSBjaGFuZ2VkLCA0MiBpbnNlcnRpb25z
KCspLCAzNSBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5
MTUvaW50ZWxfZHNpX3ZidC5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHNpX3ZidC5j
Cj4gaW5kZXggMzA3NDQ0ODQ0NmJjLi4zNDQ4ZThkNTEwNTcgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVy
cy9ncHUvZHJtL2k5MTUvaW50ZWxfZHNpX3ZidC5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5
MTUvaW50ZWxfZHNpX3ZidC5jCj4gQEAgLTUzMiw2ICs1MzIsNDQgQEAgdm9pZCBpbnRlbF9kc2lf
bXNsZWVwKHN0cnVjdCBpbnRlbF9kc2kgKmludGVsX2RzaSwgaW50IG1zZWMpCj4gIAltc2xlZXAo
bXNlYyk7Cj4gIH0KPiAgCj4gK3N0YXRpYyB2b2lkIGludGVsX2RzaV9sb2dfcGFyYW1zKHN0cnVj
dCBpbnRlbF9kc2kgKmludGVsX2RzaSkKPiArewo+ICsJRFJNX0RFQlVHX0tNUygiUGNsayAlZFxu
IiwgaW50ZWxfZHNpLT5wY2xrKTsKPiArCURSTV9ERUJVR19LTVMoIlBpeGVsIG92ZXJsYXAgJWRc
biIsIGludGVsX2RzaS0+cGl4ZWxfb3ZlcmxhcCk7Cj4gKwlEUk1fREVCVUdfS01TKCJMYW5lIGNv
dW50ICVkXG4iLCBpbnRlbF9kc2ktPmxhbmVfY291bnQpOwo+ICsJRFJNX0RFQlVHX0tNUygiRFBI
WSBwYXJhbSByZWcgMHgleFxuIiwgaW50ZWxfZHNpLT5kcGh5X3JlZyk7Cj4gKwlEUk1fREVCVUdf
S01TKCJWaWRlbyBtb2RlIGZvcm1hdCAlc1xuIiwKPiArCQkgICAgICBpbnRlbF9kc2ktPnZpZGVv
X21vZGVfZm9ybWF0ID09IFZJREVPX01PREVfTk9OX0JVUlNUX1dJVEhfU1lOQ19QVUxTRSA/Cj4g
KwkJICAgICAgIm5vbi1idXJzdCB3aXRoIHN5bmMgcHVsc2UiIDoKPiArCQkgICAgICBpbnRlbF9k
c2ktPnZpZGVvX21vZGVfZm9ybWF0ID09IFZJREVPX01PREVfTk9OX0JVUlNUX1dJVEhfU1lOQ19F
VkVOVFMgPwo+ICsJCSAgICAgICJub24tYnVyc3Qgd2l0aCBzeW5jIGV2ZW50cyIgOgo+ICsJCSAg
ICAgIGludGVsX2RzaS0+dmlkZW9fbW9kZV9mb3JtYXQgPT0gVklERU9fTU9ERV9CVVJTVCA/Cj4g
KwkJICAgICAgImJ1cnN0IiA6ICI8dW5rbm93bj4iKTsKPiArCURSTV9ERUJVR19LTVMoIkJ1cnN0
IG1vZGUgcmF0aW8gJWRcbiIsIGludGVsX2RzaS0+YnVyc3RfbW9kZV9yYXRpbyk7Cj4gKwlEUk1f
REVCVUdfS01TKCJSZXNldCB0aW1lciAlZFxuIiwgaW50ZWxfZHNpLT5yc3RfdGltZXJfdmFsKTsK
PiArCURSTV9ERUJVR19LTVMoIkVvdCAlc1xuIiwgZW5hYmxlZGRpc2FibGVkKGludGVsX2RzaS0+
ZW90cF9wa3QpKTsKPiArCURSTV9ERUJVR19LTVMoIkNsb2Nrc3RvcCAlc1xuIiwgZW5hYmxlZGRp
c2FibGVkKCFpbnRlbF9kc2ktPmNsb2NrX3N0b3ApKTsKPiArCURSTV9ERUJVR19LTVMoIk1vZGUg
JXNcbiIsIGludGVsX2RzaS0+b3BlcmF0aW9uX21vZGUgPyAiY29tbWFuZCIgOiAidmlkZW8iKTsK
PiArCWlmIChpbnRlbF9kc2ktPmR1YWxfbGluayA9PSBEU0lfRFVBTF9MSU5LX0ZST05UX0JBQ0sp
Cj4gKwkJRFJNX0RFQlVHX0tNUygiRHVhbCBsaW5rOiBEU0lfRFVBTF9MSU5LX0ZST05UX0JBQ0tc
biIpOwo+ICsJZWxzZSBpZiAoaW50ZWxfZHNpLT5kdWFsX2xpbmsgPT0gRFNJX0RVQUxfTElOS19Q
SVhFTF9BTFQpCj4gKwkJRFJNX0RFQlVHX0tNUygiRHVhbCBsaW5rOiBEU0lfRFVBTF9MSU5LX1BJ
WEVMX0FMVFxuIik7Cj4gKwllbHNlCj4gKwkJRFJNX0RFQlVHX0tNUygiRHVhbCBsaW5rOiBOT05F
XG4iKTsKPiArCURSTV9ERUJVR19LTVMoIlBpeGVsIEZvcm1hdCAlZFxuIiwgaW50ZWxfZHNpLT5w
aXhlbF9mb3JtYXQpOwo+ICsJRFJNX0RFQlVHX0tNUygiVExQWCAlZFxuIiwgaW50ZWxfZHNpLT5l
c2NhcGVfY2xrX2Rpdik7Cj4gKwlEUk1fREVCVUdfS01TKCJMUCBSWCBUaW1lb3V0IDB4JXhcbiIs
IGludGVsX2RzaS0+bHBfcnhfdGltZW91dCk7Cj4gKwlEUk1fREVCVUdfS01TKCJUdXJuYXJvdW5k
IFRpbWVvdXQgMHgleFxuIiwgaW50ZWxfZHNpLT50dXJuX2FybmRfdmFsKTsKPiArCURSTV9ERUJV
R19LTVMoIkluaXQgQ291bnQgMHgleFxuIiwgaW50ZWxfZHNpLT5pbml0X2NvdW50KTsKPiArCURS
TV9ERUJVR19LTVMoIkhTIHRvIExQIENvdW50IDB4JXhcbiIsIGludGVsX2RzaS0+aHNfdG9fbHBf
Y291bnQpOwo+ICsJRFJNX0RFQlVHX0tNUygiTFAgQnl0ZSBDbG9jayAlZFxuIiwgaW50ZWxfZHNp
LT5scF9ieXRlX2Nsayk7Cj4gKwlEUk1fREVCVUdfS01TKCJEQkkgQlcgVGltZXIgMHgleFxuIiwg
aW50ZWxfZHNpLT5id190aW1lcik7Cj4gKwlEUk1fREVCVUdfS01TKCJMUCB0byBIUyBDbG9jayBD
b3VudCAweCV4XG4iLCBpbnRlbF9kc2ktPmNsa19scF90b19oc19jb3VudCk7Cj4gKwlEUk1fREVC
VUdfS01TKCJIUyB0byBMUCBDbG9jayBDb3VudCAweCV4XG4iLCBpbnRlbF9kc2ktPmNsa19oc190
b19scF9jb3VudCk7Cj4gKwlEUk1fREVCVUdfS01TKCJCVEEgJXNcbiIsCj4gKwkJCWVuYWJsZWRk
aXNhYmxlZCghKGludGVsX2RzaS0+dmlkZW9fZnJtdF9jZmdfYml0cyAmIERJU0FCTEVfVklERU9f
QlRBKSkpOwo+ICt9Cj4gKwo+ICAjZGVmaW5lIElDTF9QUkVQQVJFX0NOVF9NQVgJMHg3Cj4gICNk
ZWZpbmUgSUNMX0NMS19aRVJPX0NOVF9NQVgJMHhmCj4gICNkZWZpbmUgSUNMX1RSQUlMX0NOVF9N
QVgJMHg3Cj4gQEAgLTYzNSw2ICs2NzMsOCBAQCBzdGF0aWMgdm9pZCBpY2xfZHBoeV9wYXJhbV9p
bml0KHN0cnVjdCBpbnRlbF9kc2kgKmludGVsX2RzaSkKPiAgCQkJCQkgSFNfVFJBSUwodHJhaWxf
Y250KSB8Cj4gIAkJCQkJIEhTX0VYSVRfT1ZFUlJJREUgfAo+ICAJCQkJCSBIU19FWElUKGV4aXRf
emVyb19jbnQpKTsKPiArCj4gKwlpbnRlbF9kc2lfbG9nX3BhcmFtcyhpbnRlbF9kc2kpOwo+ICB9
Cj4gIAo+ICBzdGF0aWMgdm9pZCB2bHZfZHBoeV9wYXJhbV9pbml0KHN0cnVjdCBpbnRlbF9kc2kg
KmludGVsX2RzaSkKPiBAQCAtNzk0LDYgKzgzNCw4IEBAIHN0YXRpYyB2b2lkIHZsdl9kcGh5X3Bh
cmFtX2luaXQoc3RydWN0IGludGVsX2RzaSAqaW50ZWxfZHNpKQo+ICAJCURJVl9ST1VORF9VUCgy
ICogdGxweF91aSArIHRyYWlsX2NudCAqIDIgKyA4LAo+ICAJCQk4KTsKPiAgCWludGVsX2RzaS0+
Y2xrX2hzX3RvX2xwX2NvdW50ICs9IGV4dHJhX2J5dGVfY291bnQ7Cj4gKwo+ICsJaW50ZWxfZHNp
X2xvZ19wYXJhbXMoaW50ZWxfZHNpKTsKPiAgfQo+ICAKPiAgYm9vbCBpbnRlbF9kc2lfdmJ0X2lu
aXQoc3RydWN0IGludGVsX2RzaSAqaW50ZWxfZHNpLCB1MTYgcGFuZWxfaWQpCj4gQEAgLTg3Nyw0
MSArOTE5LDYgQEAgYm9vbCBpbnRlbF9kc2lfdmJ0X2luaXQoc3RydWN0IGludGVsX2RzaSAqaW50
ZWxfZHNpLCB1MTYgcGFuZWxfaWQpCj4gIAllbHNlCj4gIAkJdmx2X2RwaHlfcGFyYW1faW5pdChp
bnRlbF9kc2kpOwo+ICAKPiAtCURSTV9ERUJVR19LTVMoIlBjbGsgJWRcbiIsIGludGVsX2RzaS0+
cGNsayk7Cj4gLQlEUk1fREVCVUdfS01TKCJQaXhlbCBvdmVybGFwICVkXG4iLCBpbnRlbF9kc2kt
PnBpeGVsX292ZXJsYXApOwo+IC0JRFJNX0RFQlVHX0tNUygiTGFuZSBjb3VudCAlZFxuIiwgaW50
ZWxfZHNpLT5sYW5lX2NvdW50KTsKPiAtCURSTV9ERUJVR19LTVMoIkRQSFkgcGFyYW0gcmVnIDB4
JXhcbiIsIGludGVsX2RzaS0+ZHBoeV9yZWcpOwo+IC0JRFJNX0RFQlVHX0tNUygiVmlkZW8gbW9k
ZSBmb3JtYXQgJXNcbiIsCj4gLQkJICAgICAgaW50ZWxfZHNpLT52aWRlb19tb2RlX2Zvcm1hdCA9
PSBWSURFT19NT0RFX05PTl9CVVJTVF9XSVRIX1NZTkNfUFVMU0UgPwo+IC0JCSAgICAgICJub24t
YnVyc3Qgd2l0aCBzeW5jIHB1bHNlIiA6Cj4gLQkJICAgICAgaW50ZWxfZHNpLT52aWRlb19tb2Rl
X2Zvcm1hdCA9PSBWSURFT19NT0RFX05PTl9CVVJTVF9XSVRIX1NZTkNfRVZFTlRTID8KPiAtCQkg
ICAgICAibm9uLWJ1cnN0IHdpdGggc3luYyBldmVudHMiIDoKPiAtCQkgICAgICBpbnRlbF9kc2kt
PnZpZGVvX21vZGVfZm9ybWF0ID09IFZJREVPX01PREVfQlVSU1QgPwo+IC0JCSAgICAgICJidXJz
dCIgOiAiPHVua25vd24+Iik7Cj4gLQlEUk1fREVCVUdfS01TKCJCdXJzdCBtb2RlIHJhdGlvICVk
XG4iLCBpbnRlbF9kc2ktPmJ1cnN0X21vZGVfcmF0aW8pOwo+IC0JRFJNX0RFQlVHX0tNUygiUmVz
ZXQgdGltZXIgJWRcbiIsIGludGVsX2RzaS0+cnN0X3RpbWVyX3ZhbCk7Cj4gLQlEUk1fREVCVUdf
S01TKCJFb3QgJXNcbiIsIGVuYWJsZWRkaXNhYmxlZChpbnRlbF9kc2ktPmVvdHBfcGt0KSk7Cj4g
LQlEUk1fREVCVUdfS01TKCJDbG9ja3N0b3AgJXNcbiIsIGVuYWJsZWRkaXNhYmxlZCghaW50ZWxf
ZHNpLT5jbG9ja19zdG9wKSk7Cj4gLQlEUk1fREVCVUdfS01TKCJNb2RlICVzXG4iLCBpbnRlbF9k
c2ktPm9wZXJhdGlvbl9tb2RlID8gImNvbW1hbmQiIDogInZpZGVvIik7Cj4gLQlpZiAoaW50ZWxf
ZHNpLT5kdWFsX2xpbmsgPT0gRFNJX0RVQUxfTElOS19GUk9OVF9CQUNLKQo+IC0JCURSTV9ERUJV
R19LTVMoIkR1YWwgbGluazogRFNJX0RVQUxfTElOS19GUk9OVF9CQUNLXG4iKTsKPiAtCWVsc2Ug
aWYgKGludGVsX2RzaS0+ZHVhbF9saW5rID09IERTSV9EVUFMX0xJTktfUElYRUxfQUxUKQo+IC0J
CURSTV9ERUJVR19LTVMoIkR1YWwgbGluazogRFNJX0RVQUxfTElOS19QSVhFTF9BTFRcbiIpOwo+
IC0JZWxzZQo+IC0JCURSTV9ERUJVR19LTVMoIkR1YWwgbGluazogTk9ORVxuIik7Cj4gLQlEUk1f
REVCVUdfS01TKCJQaXhlbCBGb3JtYXQgJWRcbiIsIGludGVsX2RzaS0+cGl4ZWxfZm9ybWF0KTsK
PiAtCURSTV9ERUJVR19LTVMoIlRMUFggJWRcbiIsIGludGVsX2RzaS0+ZXNjYXBlX2Nsa19kaXYp
Owo+IC0JRFJNX0RFQlVHX0tNUygiTFAgUlggVGltZW91dCAweCV4XG4iLCBpbnRlbF9kc2ktPmxw
X3J4X3RpbWVvdXQpOwo+IC0JRFJNX0RFQlVHX0tNUygiVHVybmFyb3VuZCBUaW1lb3V0IDB4JXhc
biIsIGludGVsX2RzaS0+dHVybl9hcm5kX3ZhbCk7Cj4gLQlEUk1fREVCVUdfS01TKCJJbml0IENv
dW50IDB4JXhcbiIsIGludGVsX2RzaS0+aW5pdF9jb3VudCk7Cj4gLQlEUk1fREVCVUdfS01TKCJI
UyB0byBMUCBDb3VudCAweCV4XG4iLCBpbnRlbF9kc2ktPmhzX3RvX2xwX2NvdW50KTsKPiAtCURS
TV9ERUJVR19LTVMoIkxQIEJ5dGUgQ2xvY2sgJWRcbiIsIGludGVsX2RzaS0+bHBfYnl0ZV9jbGsp
Owo+IC0JRFJNX0RFQlVHX0tNUygiREJJIEJXIFRpbWVyIDB4JXhcbiIsIGludGVsX2RzaS0+Yndf
dGltZXIpOwo+IC0JRFJNX0RFQlVHX0tNUygiTFAgdG8gSFMgQ2xvY2sgQ291bnQgMHgleFxuIiwg
aW50ZWxfZHNpLT5jbGtfbHBfdG9faHNfY291bnQpOwo+IC0JRFJNX0RFQlVHX0tNUygiSFMgdG8g
TFAgQ2xvY2sgQ291bnQgMHgleFxuIiwgaW50ZWxfZHNpLT5jbGtfaHNfdG9fbHBfY291bnQpOwo+
IC0JRFJNX0RFQlVHX0tNUygiQlRBICVzXG4iLAo+IC0JCQllbmFibGVkZGlzYWJsZWQoIShpbnRl
bF9kc2ktPnZpZGVvX2ZybXRfY2ZnX2JpdHMgJiBESVNBQkxFX1ZJREVPX0JUQSkpKTsKPiAtCj4g
IAkvKiBkZWxheXMgaW4gVkJUIGFyZSBpbiB1bml0IG9mIDEwMHVzLCBzbyBuZWVkIHRvIGNvbnZl
cnQKPiAgCSAqIGhlcmUgaW4gbXMKPiAgCSAqIERlbGF5ICgxMDB1cykgKiAxMDAgLzEwMDAgPSBE
ZWxheSAvIDEwIChtcykgKi8KPiAtLSAKPiAyLjIxLjAKCi0tIApWaWxsZSBTeXJqw6Rsw6QKSW50
ZWwKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwt
Z2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8v
bGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4