From: Greg KH <gregkh@linuxfoundation.org>
To: Joe Perches <joe@perches.com>
Cc: Masahiro Yamada <yamada.masahiro@socionext.com>,
Arnd Bergmann <arnd@arndb.de>,
Linux Media Mailing List <linux-media@vger.kernel.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Randy Dunlap <rdunlap@infradead.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] media: do not use C++ style comments in uapi headers
Date: Wed, 5 Jun 2019 08:02:05 +0200 [thread overview]
Message-ID: <20190605060205.GA29484@kroah.com> (raw)
In-Reply-To: <b70cf8c1f901ea09abbdb22dd28244b18fd1a39d.camel@perches.com>
On Tue, Jun 04, 2019 at 10:22:05PM -0700, Joe Perches wrote:
> On Wed, 2019-06-05 at 07:10 +0200, Greg KH wrote:
> > On Wed, Jun 05, 2019 at 01:10:41PM +0900, Masahiro Yamada wrote:
> > > On Wed, Jun 5, 2019 at 3:21 AM Arnd Bergmann <arnd@arndb.de> wrote:
> []
> > > This means we cannot reliably use uint{8,16,32,64}_t in UAPI headers.
> >
> > We should not be doing that as they are in the userspace "namespace" of
> > variables, not in the kernel namespace. We've been over this many times
> > in the past :(
>
> Just not very successfully...
>
> $ git grep -w -P 'u?_?int(?:8|16|32|64)_t' include/uapi | wc -l
> 342
>
> $ git grep -w -P --name-only 'u?_?int(?:8|16|32|64)_t' include/uapi | wc -l
> 13
>
> Documentation helps a bit, checkpatch helps as well.
> Maintainer knowledge and vigilance probably helps the most.
Yes, it's not been a dedicated effort at all :(
But it needs to be resolved, if we want people to actually use our
kernel headers easily.
thanks,
greg k-h
next prev parent reply other threads:[~2019-06-05 6:02 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-04 11:13 [PATCH] media: do not use C++ style comments in uapi headers Masahiro Yamada
2019-06-04 11:23 ` Joe Perches
2019-06-04 11:48 ` Masahiro Yamada
2019-06-04 12:04 ` Joe Perches
2019-06-04 11:54 ` Arnd Bergmann
2019-06-04 12:48 ` Masahiro Yamada
2019-06-04 13:32 ` Masahiro Yamada
2019-06-04 13:42 ` Greg KH
2019-06-04 15:27 ` Masahiro Yamada
2019-06-04 18:20 ` Arnd Bergmann
2019-06-05 4:10 ` Masahiro Yamada
2019-06-05 5:10 ` Greg KH
2019-06-05 5:22 ` Joe Perches
2019-06-05 6:02 ` Greg KH [this message]
2019-06-05 10:08 ` Masahiro Yamada
2019-06-05 10:14 ` Mauro Carvalho Chehab
2019-06-05 17:03 ` Joe Perches
2019-06-09 7:14 ` Masahiro Yamada
2019-06-09 11:55 ` Joe Perches
2019-06-09 13:08 ` Masahiro Yamada
2019-06-09 13:35 ` Joe Perches
2019-06-09 17:19 ` Masahiro Yamada
2019-06-09 17:42 ` Pavel Machek
2019-06-16 15:48 ` Pavel Machek
2019-06-04 14:42 ` Mauro Carvalho Chehab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190605060205.GA29484@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=arnd@arndb.de \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=rdunlap@infradead.org \
--cc=tglx@linutronix.de \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.