From mboxrd@z Thu Jan 1 00:00:00 1970 From: Charles Keepax Subject: Re: [PATCH v2 3/6] ASoC: madera: Add common support for Cirrus Logic Madera codecs Date: Wed, 5 Jun 2019 11:17:40 +0100 Message-ID: <20190605101740.GN28362@ediswmail.ad.cirrus.com> References: <20190528154312.14435-1-ckeepax@opensource.cirrus.com> <20190528154312.14435-3-ckeepax@opensource.cirrus.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx0b-001ae601.pphosted.com (mx0a-001ae601.pphosted.com [67.231.149.25]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id F1083F808E7 for ; Wed, 5 Jun 2019 12:17:43 +0200 (CEST) Content-Disposition: inline In-Reply-To: <20190528154312.14435-3-ckeepax@opensource.cirrus.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" To: broonie@kernel.org Cc: mark.rutland@arm.com, devicetree@vger.kernel.org, alsa-devel@alsa-project.org, rafael@kernel.org, gregkh@linuxfoundation.org, lgirdwood@gmail.com, robh+dt@kernel.org, patches@opensource.cirrus.com, lee.jones@linaro.org List-Id: alsa-devel@alsa-project.org On Tue, May 28, 2019 at 04:43:09PM +0100, Charles Keepax wrote: > From: Richard Fitzgerald > > The Cirrus Logic Madera codecs are a family of related codecs with > extensive digital and analogue I/O, digital mixing and routing, > signal processing and programmable DSPs. This patch adds common > support code shared by all Madera codecs. > > This patch also adds the pdata to the parent mfd pdata struct. > Since there is a circular build dependency it's convenient to > patch them both atomically. > > Signed-off-by: Nariman Poushin > Signed-off-by: Nikesh Oswal > Signed-off-by: Piotr Stankiewicz > Signed-off-by: Ajit Pandey > Signed-off-by: Richard Fitzgerald > Signed-off-by: Charles Keepax > --- > +static int madera_inmux_put(struct snd_kcontrol *kcontrol, > + struct snd_ctl_elem_value *ucontrol) > +{ Looks like there are still some issues with the inmux handling here, afraid I will probably need to do a v3 to fix them up. Thanks, Charles