From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Olaf Hering <olaf@aepfle.de>
Cc: "Alex Bennée" <alex.bennee@linaro.org>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>,
qemu-devel@nongnu.org, "Gerd Hoffmann" <kraxel@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v1] Makefile: remove DESTDIR from firmware file content
Date: Wed, 5 Jun 2019 15:07:11 +0100 [thread overview]
Message-ID: <20190605140711.GA8956@redhat.com> (raw)
In-Reply-To: <20190530192812.17637-1-olaf@aepfle.de>
On Thu, May 30, 2019 at 09:28:11PM +0200, Olaf Hering wrote:
> The resulting firmware files should only contain the runtime path.
> Fixes commit 26ce90fde5c ("Makefile: install the edk2 firmware images
> and their descriptors")
>
> Signed-off-by: Olaf Hering <olaf@aepfle.de>
> ---
> Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Makefile b/Makefile
> index f0be624f47..61267bf1a4 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -844,7 +844,7 @@ ifneq ($(DESCS),)
> $(INSTALL_DIR) "$(DESTDIR)$(qemu_datadir)/firmware"
> set -e; tmpf=$$(mktemp); trap 'rm -f -- "$$tmpf"' EXIT; \
> for x in $(DESCS); do \
> - sed -e 's,@DATADIR@,$(DESTDIR)$(qemu_datadir),' \
> + sed -e 's,@DATADIR@,$(qemu_datadir),' \
> "$(SRC_PATH)/pc-bios/descriptors/$$x" > "$$tmpf"; \
> $(INSTALL_DATA) "$$tmpf" \
> "$(DESTDIR)$(qemu_datadir)/firmware/$$x"; \
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
next prev parent reply other threads:[~2019-06-05 14:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-30 19:28 [Qemu-devel] [PATCH v1] Makefile: remove DESTDIR from firmware file content Olaf Hering
2019-06-05 14:07 ` Daniel P. Berrangé [this message]
2019-06-05 14:46 ` Philippe Mathieu-Daudé
2019-06-05 16:31 ` Laszlo Ersek
2019-06-05 16:45 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190605140711.GA8956@redhat.com \
--to=berrange@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=kraxel@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=olaf@aepfle.de \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.