Re: [meta-oe][PATCH] protobuf: 3.6.1 -> 3.8.0

[Adrian Bunk <bunk@stusta.de>]

On Wed, Jun 05, 2019 at 04:11:14PM +0200, Pascal Bach wrote:
> Simple update to latest release
> 
> Signed-off-by: Pascal Bach <pascal.bach@siemens.com>
> ---
>  .../protobuf/{protobuf_3.6.1.bb => protobuf_3.8.0.bb}                 | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>  rename meta-oe/recipes-devtools/protobuf/{protobuf_3.6.1.bb => protobuf_3.8.0.bb} (96%)
> 
> diff --git a/meta-oe/recipes-devtools/protobuf/protobuf_3.6.1.bb b/meta-oe/recipes-devtools/protobuf/protobuf_3.8.0.bb
> similarity index 96%
> rename from meta-oe/recipes-devtools/protobuf/protobuf_3.6.1.bb
> rename to meta-oe/recipes-devtools/protobuf/protobuf_3.8.0.bb
> index cf72d9ca7..7148954ce 100644
> --- a/meta-oe/recipes-devtools/protobuf/protobuf_3.6.1.bb
> +++ b/meta-oe/recipes-devtools/protobuf/protobuf_3.8.0.bb
> @@ -12,9 +12,9 @@ DEPENDS_append_class-target = " protobuf-native"
>  
>  PV .= "+git${SRCPV}"

This is (and was previously) exactly the release,
so upgrading gives the opportunity to remove this
misleading +git addition.

> -SRCREV = "48cb18e5c419ddd23d9badcfe4e9df7bde1979b2"
> +SRCREV = "09745575a923640154bcf307fba8aedff47f240a"
>  
> -SRC_URI = "git://github.com/google/protobuf.git;branch=3.6.x \
> +SRC_URI = "git://github.com/google/protobuf.git;branch=master \
>...

branch=3.8.x would look more logical to me here.

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed