From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mauro Carvalho Chehab Subject: Re: [PATCH v5 2/3] media: uapi: Add MEDIA_BUS_FMT_RGB888_3X8 media bus format Date: Wed, 5 Jun 2019 20:41:52 -0300 Message-ID: <20190605204152.36f81ebd@coco.lan> References: <20190605222247.25657-1-paul@crapouillou.net> <20190605222247.25657-2-paul@crapouillou.net> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20190605222247.25657-2-paul@crapouillou.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Paul Cercueil Cc: devicetree@vger.kernel.org, od@zcrc.me, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Thierry Reding , Hans Verkuil , Sam Ravnborg , linux-media@vger.kernel.org List-Id: devicetree@vger.kernel.org RW0gVGh1LCAgNiBKdW4gMjAxOSAwMDoyMjo0NiArMDIwMApQYXVsIENlcmN1ZWlsIDxwYXVsQGNy YXBvdWlsbG91Lm5ldD4gZXNjcmV2ZXU6Cgo+IFRoaXMgcGF0Y2ggYWRkcyBNRURJQV9CVVNfRk1U X1JHQjg4OF8zWDgsIHVzZWQgZm9yIHRoZSBHaWFudFBsdXMKPiBHUE05NDBCMCAyNC1iaXQgVEZU IHBhbmVsLCB3aGVyZSB0aGUgUkdCIGNvbXBvbmVudHMgYXJlIHRyYW5zZmVycmVkCj4gc2VxdWVu dGlhbGx5IG9uIGEgOC1iaXQgYnVzLgo+IAo+IFNpZ25lZC1vZmYtYnk6IFBhdWwgQ2VyY3VlaWwg PHBhdWxAY3JhcG91aWxsb3UubmV0PgoKTG9va3Mgb2sgdG8gbWUuIEZlZWwgZnJlZSB0byBhcHBs eSB2aWEgRFJNIHRyZWUuCgpBY2tlZC1ieTogTWF1cm8gQ2FydmFsaG8gQ2hlaGFiIDxtY2hlaGFi K3NhbXN1bmdAa2VybmVsLm9yZz4KCj4gLS0tCj4gCj4gTm90ZXM6Cj4gICAgIHYyOiBOZXcgcGF0 Y2gKPiAgICAgCj4gICAgIHYzOiBObyBjaGFuZ2UKPiAgICAgCj4gICAgIHY0OiBBZGQgb25seSBN RURJQV9CVVNfRk1UX1JHQjg4OF8zWDgsIGFzIHdlIGRvbid0IGhhdmUgdG8gY2FyZSBhYm91dAo+ ICAgICAgICAgZW5kaWFubmVzcwo+ICAgICAKPiAgICAgdjU6IEFsc28gdXBkYXRlIERvY3VtZW50 YXRpb24vbWVkaWEvdWFwaS92NGwvc3ViZGV2LWZvcm1hdHMucnN0Cj4gCj4gIC4uLi9tZWRpYS91 YXBpL3Y0bC9zdWJkZXYtZm9ybWF0cy5yc3QgICAgICAgICB8IDEwNyArKysrKysrKysrKysrKysr KysKPiAgaW5jbHVkZS91YXBpL2xpbnV4L21lZGlhLWJ1cy1mb3JtYXQuaCAgICAgICAgIHwgICAz ICstCj4gIDIgZmlsZXMgY2hhbmdlZCwgMTA5IGluc2VydGlvbnMoKyksIDEgZGVsZXRpb24oLSkK PiAKPiBkaWZmIC0tZ2l0IGEvRG9jdW1lbnRhdGlvbi9tZWRpYS91YXBpL3Y0bC9zdWJkZXYtZm9y bWF0cy5yc3QgYi9Eb2N1bWVudGF0aW9uL21lZGlhL3VhcGkvdjRsL3N1YmRldi1mb3JtYXRzLnJz dAo+IGluZGV4IGFiMWE0OGE1YWU4MC4uZjRmOGRlMzFhYzYzIDEwMDY0NAo+IC0tLSBhL0RvY3Vt ZW50YXRpb24vbWVkaWEvdWFwaS92NGwvc3ViZGV2LWZvcm1hdHMucnN0Cj4gKysrIGIvRG9jdW1l bnRhdGlvbi9tZWRpYS91YXBpL3Y0bC9zdWJkZXYtZm9ybWF0cy5yc3QKPiBAQCAtMTMwNSw2ICsx MzA1LDExMyBAQCBUaGUgZm9sbG93aW5nIHRhYmxlcyBsaXN0IGV4aXN0aW5nIHBhY2tlZCBSR0Ig Zm9ybWF0cy4KPiAgICAgICAgLSBnXCA6c3ViOmA2YAo+ICAgICAgICAtIGdcIDpzdWI6YDVgCj4g ICAgICAgIC0gZ1wgOnN1YjpgNGAKPiArICAgICogLi4gX01FRElBLUJVUy1GTVQtUkdCODg4LTNY ODoKPiArCj4gKyAgICAgIC0gTUVESUFfQlVTX0ZNVF9SR0I4ODhfM1g4Cj4gKyAgICAgIC0gMHgx MDFjCj4gKyAgICAgIC0KPiArICAgICAgLQo+ICsgICAgICAtCj4gKyAgICAgIC0KPiArICAgICAg LQo+ICsgICAgICAtCj4gKyAgICAgIC0KPiArICAgICAgLQo+ICsgICAgICAtCj4gKyAgICAgIC0K PiArICAgICAgLQo+ICsgICAgICAtCj4gKyAgICAgIC0KPiArICAgICAgLQo+ICsgICAgICAtCj4g KyAgICAgIC0KPiArICAgICAgLQo+ICsgICAgICAtCj4gKyAgICAgIC0KPiArICAgICAgLQo+ICsg ICAgICAtCj4gKyAgICAgIC0KPiArICAgICAgLQo+ICsgICAgICAtCj4gKyAgICAgIC0KPiArICAg ICAgLSByXCA6c3ViOmA3YAo+ICsgICAgICAtIHJcIDpzdWI6YDZgCj4gKyAgICAgIC0gclwgOnN1 YjpgNWAKPiArICAgICAgLSByXCA6c3ViOmA0YAo+ICsgICAgICAtIHJcIDpzdWI6YDNgCj4gKyAg ICAgIC0gclwgOnN1YjpgMmAKPiArICAgICAgLSByXCA6c3ViOmAxYAo+ICsgICAgICAtIHJcIDpz dWI6YDBgCj4gKyAgICAqIC0KPiArICAgICAgLQo+ICsgICAgICAtCj4gKyAgICAgIC0KPiArICAg ICAgLQo+ICsgICAgICAtCj4gKyAgICAgIC0KPiArICAgICAgLQo+ICsgICAgICAtCj4gKyAgICAg IC0KPiArICAgICAgLQo+ICsgICAgICAtCj4gKyAgICAgIC0KPiArICAgICAgLQo+ICsgICAgICAt Cj4gKyAgICAgIC0KPiArICAgICAgLQo+ICsgICAgICAtCj4gKyAgICAgIC0KPiArICAgICAgLQo+ ICsgICAgICAtCj4gKyAgICAgIC0KPiArICAgICAgLQo+ICsgICAgICAtCj4gKyAgICAgIC0KPiAr ICAgICAgLQo+ICsgICAgICAtCj4gKyAgICAgIC0gZ1wgOnN1YjpgN2AKPiArICAgICAgLSBnXCA6 c3ViOmA2YAo+ICsgICAgICAtIGdcIDpzdWI6YDVgCj4gKyAgICAgIC0gZ1wgOnN1YjpgNGAKPiAr ICAgICAgLSBnXCA6c3ViOmAzYAo+ICsgICAgICAtIGdcIDpzdWI6YDJgCj4gKyAgICAgIC0gZ1wg OnN1YjpgMWAKPiArICAgICAgLSBnXCA6c3ViOmAwYAo+ICsgICAgKiAtCj4gKyAgICAgIC0KPiAr ICAgICAgLQo+ICsgICAgICAtCj4gKyAgICAgIC0KPiArICAgICAgLQo+ICsgICAgICAtCj4gKyAg ICAgIC0KPiArICAgICAgLQo+ICsgICAgICAtCj4gKyAgICAgIC0KPiArICAgICAgLQo+ICsgICAg ICAtCj4gKyAgICAgIC0KPiArICAgICAgLQo+ICsgICAgICAtCj4gKyAgICAgIC0KPiArICAgICAg LQo+ICsgICAgICAtCj4gKyAgICAgIC0KPiArICAgICAgLQo+ICsgICAgICAtCj4gKyAgICAgIC0K PiArICAgICAgLQo+ICsgICAgICAtCj4gKyAgICAgIC0KPiArICAgICAgLQo+ICsgICAgICAtIGJc IDpzdWI6YDdgCj4gKyAgICAgIC0gYlwgOnN1YjpgNmAKPiArICAgICAgLSBiXCA6c3ViOmA1YAo+ ICsgICAgICAtIGJcIDpzdWI6YDRgCj4gKyAgICAgIC0gYlwgOnN1YjpgM2AKPiArICAgICAgLSBi XCA6c3ViOmAyYAo+ICsgICAgICAtIGJcIDpzdWI6YDFgCj4gKyAgICAgIC0gYlwgOnN1YjpgMGAK PiAgICAgICogLi4gX01FRElBLUJVUy1GTVQtQVJHQjg4OC0xWDMyOgo+ICAKPiAgICAgICAgLSBN RURJQV9CVVNfRk1UX0FSR0I4ODhfMVgzMgo+IGRpZmYgLS1naXQgYS9pbmNsdWRlL3VhcGkvbGlu dXgvbWVkaWEtYnVzLWZvcm1hdC5oIGIvaW5jbHVkZS91YXBpL2xpbnV4L21lZGlhLWJ1cy1mb3Jt YXQuaAo+IGluZGV4IDJhNmIyNTNjZmIwNS4uMTZjMWZhMmQ4OWE0IDEwMDY0NAo+IC0tLSBhL2lu Y2x1ZGUvdWFwaS9saW51eC9tZWRpYS1idXMtZm9ybWF0LmgKPiArKysgYi9pbmNsdWRlL3VhcGkv bGludXgvbWVkaWEtYnVzLWZvcm1hdC5oCj4gQEAgLTM0LDcgKzM0LDcgQEAKPiAgCj4gICNkZWZp bmUgTUVESUFfQlVTX0ZNVF9GSVhFRAkJCTB4MDAwMQo+ICAKPiAtLyogUkdCIC0gbmV4dCBpcwkw eDEwMWMgKi8KPiArLyogUkdCIC0gbmV4dCBpcwkweDEwMWQgKi8KPiAgI2RlZmluZSBNRURJQV9C VVNfRk1UX1JHQjQ0NF8xWDEyCQkweDEwMTYKPiAgI2RlZmluZSBNRURJQV9CVVNfRk1UX1JHQjQ0 NF8yWDhfUEFESElfQkUJMHgxMDAxCj4gICNkZWZpbmUgTUVESUFfQlVTX0ZNVF9SR0I0NDRfMlg4 X1BBREhJX0xFCTB4MTAwMgo+IEBAIC01NSw2ICs1NSw3IEBACj4gICNkZWZpbmUgTUVESUFfQlVT X0ZNVF9SR0I4ODhfMVgyNAkJMHgxMDBhCj4gICNkZWZpbmUgTUVESUFfQlVTX0ZNVF9SR0I4ODhf MlgxMl9CRQkJMHgxMDBiCj4gICNkZWZpbmUgTUVESUFfQlVTX0ZNVF9SR0I4ODhfMlgxMl9MRQkJ MHgxMDBjCj4gKyNkZWZpbmUgTUVESUFfQlVTX0ZNVF9SR0I4ODhfM1g4CQkweDEwMWMKPiAgI2Rl ZmluZSBNRURJQV9CVVNfRk1UX1JHQjg4OF8xWDdYNF9TUFdHCQkweDEwMTEKPiAgI2RlZmluZSBN RURJQV9CVVNfRk1UX1JHQjg4OF8xWDdYNF9KRUlEQQkweDEwMTIKPiAgI2RlZmluZSBNRURJQV9C VVNfRk1UX0FSR0I4ODg4XzFYMzIJCTB4MTAwZAoKCgpUaGFua3MsCk1hdXJvCl9fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxp c3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNr dG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbA== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,T_DKIMWL_WL_HIGH autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E4DF8C28CC5 for ; Wed, 5 Jun 2019 23:42:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B99872070B for ; Wed, 5 Jun 2019 23:42:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1559778135; bh=Ty+IDfPl32At1TBBsThkdN3q4Gmgm0ckdjpO0uqs2CY=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=WEUeBQRtEqFduJW7uX/qj0vYRuvCoyXgf6MUQfAo8fT6Ar/7yQChSX8B06o1KdX0j 0JTFeXbZaZHTYNajpbsdfVm4+oev+6gxnSG7tUT+lZQPhB56A+b7tZQx5tUT1MOHgc pn3i3ukpGNaM0AquNSO+vNRiJKvZ2HOVmyYTYs24= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726734AbfFEXmK (ORCPT ); Wed, 5 Jun 2019 19:42:10 -0400 Received: from casper.infradead.org ([85.118.1.10]:48604 "EHLO casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726532AbfFEXmJ (ORCPT ); Wed, 5 Jun 2019 19:42:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:Content-Type: MIME-Version:References:In-Reply-To:Message-ID:Subject:Cc:To:From:Date:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=IllZgL/Tvx6ZdOkE8cT0VBvSJHPyC9Kw4E2FxJB9wHw=; b=bm2K2e36Q7ozSQDpAX71FjdUg5 t45M9rkJZI5xIcP2xoJLYpzZUzxXj5u12tnAWWX/54JMNifGsA3V/jP6Zrl1YcjUW2xd2uoS2797t rWjOKTkQkRR2q3GJokt0uftfimyVD9gZj99nAn+sKuqn/Lz+4J14aO/TTgBXbwebFpm1HG5ZbQc5r r+lJ//XEq817K3pBD3daHKUeJc6792qKmE1ORtKU5Pw6mhY47ZxiYcbQKWIuiC2FZ1ZTi/l3mQy7p JLKVZGXWt/OZJe8s1MBs5i/bBZYZEHgeKBqh22giDHB2znPppochw2XIRxntaEgnxgoiOUv181hH9 ff7H7oiQ==; Received: from [179.182.172.34] (helo=coco.lan) by casper.infradead.org with esmtpsa (Exim 4.90_1 #2 (Red Hat Linux)) id 1hYfXa-0004Gc-V0; Wed, 05 Jun 2019 23:41:59 +0000 Date: Wed, 5 Jun 2019 20:41:52 -0300 From: Mauro Carvalho Chehab To: Paul Cercueil Cc: Thierry Reding , Sam Ravnborg , Hans Verkuil , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, od@zcrc.me Subject: Re: [PATCH v5 2/3] media: uapi: Add MEDIA_BUS_FMT_RGB888_3X8 media bus format Message-ID: <20190605204152.36f81ebd@coco.lan> In-Reply-To: <20190605222247.25657-2-paul@crapouillou.net> References: <20190605222247.25657-1-paul@crapouillou.net> <20190605222247.25657-2-paul@crapouillou.net> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Em Thu, 6 Jun 2019 00:22:46 +0200 Paul Cercueil escreveu: > This patch adds MEDIA_BUS_FMT_RGB888_3X8, used for the GiantPlus > GPM940B0 24-bit TFT panel, where the RGB components are transferred > sequentially on a 8-bit bus. > > Signed-off-by: Paul Cercueil Looks ok to me. Feel free to apply via DRM tree. Acked-by: Mauro Carvalho Chehab > --- > > Notes: > v2: New patch > > v3: No change > > v4: Add only MEDIA_BUS_FMT_RGB888_3X8, as we don't have to care about > endianness > > v5: Also update Documentation/media/uapi/v4l/subdev-formats.rst > > .../media/uapi/v4l/subdev-formats.rst | 107 ++++++++++++++++++ > include/uapi/linux/media-bus-format.h | 3 +- > 2 files changed, 109 insertions(+), 1 deletion(-) > > diff --git a/Documentation/media/uapi/v4l/subdev-formats.rst b/Documentation/media/uapi/v4l/subdev-formats.rst > index ab1a48a5ae80..f4f8de31ac63 100644 > --- a/Documentation/media/uapi/v4l/subdev-formats.rst > +++ b/Documentation/media/uapi/v4l/subdev-formats.rst > @@ -1305,6 +1305,113 @@ The following tables list existing packed RGB formats. > - g\ :sub:`6` > - g\ :sub:`5` > - g\ :sub:`4` > + * .. _MEDIA-BUS-FMT-RGB888-3X8: > + > + - MEDIA_BUS_FMT_RGB888_3X8 > + - 0x101c > + - > + - > + - > + - > + - > + - > + - > + - > + - > + - > + - > + - > + - > + - > + - > + - > + - > + - > + - > + - > + - > + - > + - > + - > + - > + - r\ :sub:`7` > + - r\ :sub:`6` > + - r\ :sub:`5` > + - r\ :sub:`4` > + - r\ :sub:`3` > + - r\ :sub:`2` > + - r\ :sub:`1` > + - r\ :sub:`0` > + * - > + - > + - > + - > + - > + - > + - > + - > + - > + - > + - > + - > + - > + - > + - > + - > + - > + - > + - > + - > + - > + - > + - > + - > + - > + - > + - > + - g\ :sub:`7` > + - g\ :sub:`6` > + - g\ :sub:`5` > + - g\ :sub:`4` > + - g\ :sub:`3` > + - g\ :sub:`2` > + - g\ :sub:`1` > + - g\ :sub:`0` > + * - > + - > + - > + - > + - > + - > + - > + - > + - > + - > + - > + - > + - > + - > + - > + - > + - > + - > + - > + - > + - > + - > + - > + - > + - > + - > + - > + - b\ :sub:`7` > + - b\ :sub:`6` > + - b\ :sub:`5` > + - b\ :sub:`4` > + - b\ :sub:`3` > + - b\ :sub:`2` > + - b\ :sub:`1` > + - b\ :sub:`0` > * .. _MEDIA-BUS-FMT-ARGB888-1X32: > > - MEDIA_BUS_FMT_ARGB888_1X32 > diff --git a/include/uapi/linux/media-bus-format.h b/include/uapi/linux/media-bus-format.h > index 2a6b253cfb05..16c1fa2d89a4 100644 > --- a/include/uapi/linux/media-bus-format.h > +++ b/include/uapi/linux/media-bus-format.h > @@ -34,7 +34,7 @@ > > #define MEDIA_BUS_FMT_FIXED 0x0001 > > -/* RGB - next is 0x101c */ > +/* RGB - next is 0x101d */ > #define MEDIA_BUS_FMT_RGB444_1X12 0x1016 > #define MEDIA_BUS_FMT_RGB444_2X8_PADHI_BE 0x1001 > #define MEDIA_BUS_FMT_RGB444_2X8_PADHI_LE 0x1002 > @@ -55,6 +55,7 @@ > #define MEDIA_BUS_FMT_RGB888_1X24 0x100a > #define MEDIA_BUS_FMT_RGB888_2X12_BE 0x100b > #define MEDIA_BUS_FMT_RGB888_2X12_LE 0x100c > +#define MEDIA_BUS_FMT_RGB888_3X8 0x101c > #define MEDIA_BUS_FMT_RGB888_1X7X4_SPWG 0x1011 > #define MEDIA_BUS_FMT_RGB888_1X7X4_JEIDA 0x1012 > #define MEDIA_BUS_FMT_ARGB8888_1X32 0x100d Thanks, Mauro