All of lore.kernel.org
 help / color / mirror / Atom feed
From: Omar Sandoval <osandov@osandov.com>
To: Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>
Cc: linux-block@vger.kernel.org, Omar Sandoval <osandov@fb.com>,
	Masato Suzuki <masato.suzuki@wdc.com>,
	Damien Le Moal <Damien.LeMoal@wdc.com>,
	Chaitanya Kulkarni <Chaitanya.Kulkarni@wdc.com>
Subject: Re: [PATCH blktests v2 1/2] zbd/rc: Introduce helper functions for zone mapping test
Date: Wed, 5 Jun 2019 14:52:47 -0700	[thread overview]
Message-ID: <20190605215247.GA21734@vader> (raw)
In-Reply-To: <20190531015913.5560-2-shinichiro.kawasaki@wdc.com>

On Fri, May 31, 2019 at 10:59:12AM +0900, Shin'ichiro Kawasaki wrote:
> As a preparation for the zone mapping test case, add several helper
> functions. _find_last_sequential_zone() and
> _find_sequential_zone_in_middle() help to select test target zones.
> _test_dev_is_logical() checks TEST_DEV is the valid test target.
> _test_dev_has_dm_map() helps to check that the dm target is linear or
> flakey. _get_dev_container_and_sector() helps to get the container device
> and sector mappings.

This has a few shellcheck warnings:

tests/zbd/rc:221:4: error: Remove '$' or use '_=$((expr))' to avoid executing output. [SC2084]
tests/zbd/rc:223:4: error: Remove '$' or use '_=$((expr))' to avoid executing output. [SC2084]
tests/zbd/rc:225:3: error: Remove '$' or use '_=$((expr))' to avoid executing output. [SC2084]

And it's missing your Signed-off-by.

Thanks!

  parent reply	other threads:[~2019-06-05 21:52 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-31  1:59 [PATCH blktests v2 0/2] Test zone mapping of logical devices Shin'ichiro Kawasaki
2019-05-31  1:59 ` [PATCH blktests v2 1/2] zbd/rc: Introduce helper functions for zone mapping test Shin'ichiro Kawasaki
2019-06-04 22:12   ` Chaitanya Kulkarni
2019-06-06  7:52     ` Shinichiro Kawasaki
2019-06-05 21:52   ` Omar Sandoval [this message]
2019-06-06  8:07     ` Shinichiro Kawasaki
2019-05-31  1:59 ` [PATCH blktests v2 2/2] zbd/007: Add zone mapping test for logical devices Shin'ichiro Kawasaki
2019-06-04 22:13   ` Chaitanya Kulkarni
2019-06-05 21:53   ` Omar Sandoval
2019-06-07  5:04     ` Shinichiro Kawasaki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190605215247.GA21734@vader \
    --to=osandov@osandov.com \
    --cc=Chaitanya.Kulkarni@wdc.com \
    --cc=Damien.LeMoal@wdc.com \
    --cc=linux-block@vger.kernel.org \
    --cc=masato.suzuki@wdc.com \
    --cc=osandov@fb.com \
    --cc=shinichiro.kawasaki@wdc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.