From: kbuild test robot <lkp@intel.com>
To: Oleg Nesterov <oleg@redhat.com>
Cc: kbuild-all@01.org, Andrew Morton <akpm@linux-foundation.org>,
Deepa Dinamani <deepa.kernel@gmail.com>,
linux-kernel@vger.kernel.org, arnd@arndb.de, dbueso@suse.de,
axboe@kernel.dk, dave@stgolabs.net, e@80x24.org,
jbaron@akamai.com, linux-fsdevel@vger.kernel.org,
linux-aio@kvack.org, omar.kilani@gmail.com, tglx@linutronix.de,
stable@vger.kernel.org, Al Viro <viro@ZenIV.linux.org.uk>,
"Eric W. Biederman" <ebiederm@xmission.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
David Laight <David.Laight@ACULAB.COM>
Subject: Re: [PATCH -mm 1/1] signal: simplify set_user_sigmask/restore_user_sigmask
Date: Thu, 6 Jun 2019 08:14:26 +0800 [thread overview]
Message-ID: <201906060849.y7IR5OFp%lkp@intel.com> (raw)
In-Reply-To: <20190605155833.GB25165@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 6048 bytes --]
Hi Oleg,
I love your patch! Perhaps something to improve:
[auto build test WARNING on mmotm/master]
url: https://github.com/0day-ci/linux/commits/Oleg-Nesterov/signal-simplify-set_user_sigmask-restore_user_sigmask/20190606-062512
base: git://git.cmpxchg.org/linux-mmotm.git master
config: m68k-allyesconfig (attached as .config)
compiler: m68k-linux-gcc (GCC) 7.4.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
GCC_VERSION=7.4.0 make.cross ARCH=m68k
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>
Note: it may well be a FALSE warning. FWIW you are at least aware of it now.
http://gcc.gnu.org/wiki/Better_Uninitialized_Warnings
All warnings (new ones prefixed by >>):
In file included from arch/m68k/include/asm/uaccess.h:5:0,
from include/linux/uaccess.h:11,
from include/asm-generic/termios.h:6,
from ./arch/m68k/include/generated/uapi/asm/termios.h:1,
from include/uapi/linux/termios.h:6,
from include/linux/tty.h:7,
from kernel/signal.c:26:
kernel/signal.c: In function 'set_user_sigmask':
>> arch/m68k/include/asm/uaccess_mm.h:191:2: warning: 'kmask' may be used uninitialized in this function [-Wmaybe-uninitialized]
asm volatile ("\n" \
^~~
kernel/signal.c:2960:12: note: 'kmask' was declared here
sigset_t *kmask;
^~~~~
vim +/kmask +191 arch/m68k/include/asm/uaccess_mm.h
7cefa5a0 arch/m68k/include/asm/uaccess_mm.h Al Viro 2017-03-20 189
7cefa5a0 arch/m68k/include/asm/uaccess_mm.h Al Viro 2017-03-20 190 #define ____constant_copy_from_user_asm(res, to, from, tmp, n1, n2, n3, s1, s2, s3)\
53617825 include/asm-m68k/uaccess.h Roman Zippel 2006-06-25 @191 asm volatile ("\n" \
e08d703c arch/m68k/include/asm/uaccess_mm.h Greg Ungerer 2011-10-14 192 "1: "MOVES"."#s1" (%2)+,%3\n" \
53617825 include/asm-m68k/uaccess.h Roman Zippel 2006-06-25 193 " move."#s1" %3,(%1)+\n" \
7cefa5a0 arch/m68k/include/asm/uaccess_mm.h Al Viro 2017-03-20 194 " .ifnc \""#s2"\",\"\"\n" \
e08d703c arch/m68k/include/asm/uaccess_mm.h Greg Ungerer 2011-10-14 195 "2: "MOVES"."#s2" (%2)+,%3\n" \
53617825 include/asm-m68k/uaccess.h Roman Zippel 2006-06-25 196 " move."#s2" %3,(%1)+\n" \
53617825 include/asm-m68k/uaccess.h Roman Zippel 2006-06-25 197 " .ifnc \""#s3"\",\"\"\n" \
e08d703c arch/m68k/include/asm/uaccess_mm.h Greg Ungerer 2011-10-14 198 "3: "MOVES"."#s3" (%2)+,%3\n" \
53617825 include/asm-m68k/uaccess.h Roman Zippel 2006-06-25 199 " move."#s3" %3,(%1)+\n" \
53617825 include/asm-m68k/uaccess.h Roman Zippel 2006-06-25 200 " .endif\n" \
7cefa5a0 arch/m68k/include/asm/uaccess_mm.h Al Viro 2017-03-20 201 " .endif\n" \
53617825 include/asm-m68k/uaccess.h Roman Zippel 2006-06-25 202 "4:\n" \
53617825 include/asm-m68k/uaccess.h Roman Zippel 2006-06-25 203 " .section __ex_table,\"a\"\n" \
53617825 include/asm-m68k/uaccess.h Roman Zippel 2006-06-25 204 " .align 4\n" \
53617825 include/asm-m68k/uaccess.h Roman Zippel 2006-06-25 205 " .long 1b,10f\n" \
7cefa5a0 arch/m68k/include/asm/uaccess_mm.h Al Viro 2017-03-20 206 " .ifnc \""#s2"\",\"\"\n" \
53617825 include/asm-m68k/uaccess.h Roman Zippel 2006-06-25 207 " .long 2b,20f\n" \
53617825 include/asm-m68k/uaccess.h Roman Zippel 2006-06-25 208 " .ifnc \""#s3"\",\"\"\n" \
53617825 include/asm-m68k/uaccess.h Roman Zippel 2006-06-25 209 " .long 3b,30f\n" \
53617825 include/asm-m68k/uaccess.h Roman Zippel 2006-06-25 210 " .endif\n" \
7cefa5a0 arch/m68k/include/asm/uaccess_mm.h Al Viro 2017-03-20 211 " .endif\n" \
53617825 include/asm-m68k/uaccess.h Roman Zippel 2006-06-25 212 " .previous\n" \
53617825 include/asm-m68k/uaccess.h Roman Zippel 2006-06-25 213 "\n" \
53617825 include/asm-m68k/uaccess.h Roman Zippel 2006-06-25 214 " .section .fixup,\"ax\"\n" \
53617825 include/asm-m68k/uaccess.h Roman Zippel 2006-06-25 215 " .even\n" \
7cefa5a0 arch/m68k/include/asm/uaccess_mm.h Al Viro 2017-03-20 216 "10: addq.l #"#n1",%0\n" \
7cefa5a0 arch/m68k/include/asm/uaccess_mm.h Al Viro 2017-03-20 217 " .ifnc \""#s2"\",\"\"\n" \
7cefa5a0 arch/m68k/include/asm/uaccess_mm.h Al Viro 2017-03-20 218 "20: addq.l #"#n2",%0\n" \
53617825 include/asm-m68k/uaccess.h Roman Zippel 2006-06-25 219 " .ifnc \""#s3"\",\"\"\n" \
7cefa5a0 arch/m68k/include/asm/uaccess_mm.h Al Viro 2017-03-20 220 "30: addq.l #"#n3",%0\n" \
7cefa5a0 arch/m68k/include/asm/uaccess_mm.h Al Viro 2017-03-20 221 " .endif\n" \
53617825 include/asm-m68k/uaccess.h Roman Zippel 2006-06-25 222 " .endif\n" \
53617825 include/asm-m68k/uaccess.h Roman Zippel 2006-06-25 223 " jra 4b\n" \
53617825 include/asm-m68k/uaccess.h Roman Zippel 2006-06-25 224 " .previous\n" \
53617825 include/asm-m68k/uaccess.h Roman Zippel 2006-06-25 225 : "+d" (res), "+&a" (to), "+a" (from), "=&d" (tmp) \
53617825 include/asm-m68k/uaccess.h Roman Zippel 2006-06-25 226 : : "memory")
53617825 include/asm-m68k/uaccess.h Roman Zippel 2006-06-25 227
:::::: The code at line 191 was first introduced by commit
:::::: 53617825ccf3ff8a71e6efcf3dcf58885ed6f3e5 [PATCH] m68k: fix uaccess.h for gcc-3.x
:::::: TO: Roman Zippel <zippel@linux-m68k.org>
:::::: CC: Linus Torvalds <torvalds@g5.osdl.org>
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 50791 bytes --]
next prev parent reply other threads:[~2019-06-06 0:15 UTC|newest]
Thread overview: 154+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-22 3:21 [PATCH v2] signal: Adjust error codes according to restore_user_sigmask() Deepa Dinamani
2019-05-22 15:05 ` Oleg Nesterov
2019-05-22 15:55 ` Deepa Dinamani
2019-05-22 16:14 ` Oleg Nesterov
2019-05-22 16:33 ` Deepa Dinamani
2019-05-23 9:03 ` David Laight
2019-05-23 14:59 ` Oleg Nesterov
2019-05-23 16:18 ` David Laight
2019-05-23 16:36 ` Oleg Nesterov
2019-05-23 16:56 ` David Laight
2019-05-23 18:06 ` Deepa Dinamani
2019-05-23 20:41 ` Deepa Dinamani
2019-05-23 21:06 ` Deepa Dinamani
2019-05-24 9:58 ` David Laight
2019-05-24 14:10 ` Oleg Nesterov
2019-05-24 15:16 ` Deepa Dinamani
2019-05-24 16:33 ` Oleg Nesterov
2019-05-24 17:01 ` Deepa Dinamani
2019-05-27 15:04 ` Oleg Nesterov
2019-05-28 20:47 ` Deepa Dinamani
2019-05-29 16:57 ` Oleg Nesterov
2019-05-29 18:42 ` Deepa Dinamani
2019-05-28 9:02 ` David Laight
2019-05-28 9:12 ` David Laight
2019-05-28 11:37 ` Deepa Dinamani
2019-05-28 12:04 ` David Laight
2019-05-24 14:19 ` Oleg Nesterov
2019-05-24 14:29 ` Deepa Dinamani
2019-05-24 14:51 ` Oleg Nesterov
2019-05-24 13:29 ` Oleg Nesterov
2019-05-24 14:59 ` David Laight
2019-05-24 15:09 ` David Laight
2019-05-24 15:46 ` Oleg Nesterov
2019-05-24 15:44 ` Oleg Nesterov
2019-05-24 16:40 ` David Laight
2019-05-23 14:33 ` Oleg Nesterov
2019-05-22 22:18 ` Chris Down
2019-05-22 22:52 ` Deepa Dinamani
2019-05-29 16:11 ` pselect/etc semantics (Was: [PATCH v2] signal: Adjust error codes according to restore_user_sigmask()) Oleg Nesterov
2019-05-29 16:54 ` David Laight
2019-05-29 18:50 ` Eric Wong
2019-05-30 9:34 ` David Laight
2019-05-30 13:04 ` pselect/etc semantics Eric W. Biederman
2019-05-29 16:56 ` pselect/etc semantics (Was: [PATCH v2] signal: Adjust error codes according to restore_user_sigmask()) Deepa Dinamani
2019-05-29 18:26 ` Deepa Dinamani
2019-05-29 22:32 ` Arnd Bergmann
2019-05-30 1:54 ` pselect/etc semantics Eric W. Biederman
2019-05-30 18:28 ` Arnd Bergmann
2019-05-30 14:40 ` pselect/etc semantics (Was: [PATCH v2] signal: Adjust error codes according to restore_user_sigmask()) Oleg Nesterov
2019-05-30 18:37 ` Arnd Bergmann
2019-05-30 13:01 ` pselect/etc semantics Eric W. Biederman
2019-05-30 15:18 ` David Laight
2019-05-30 16:13 ` Oleg Nesterov
2019-05-30 15:38 ` Eric W. Biederman
2019-05-30 15:48 ` Deepa Dinamani
2019-05-30 16:59 ` Deepa Dinamani
2019-05-30 16:08 ` Oleg Nesterov
2019-05-30 17:20 ` Eric W. Biederman
2019-05-30 16:22 ` David Laight
2019-05-30 15:57 ` Oleg Nesterov
2019-05-30 21:03 ` Eric Wong
2019-06-04 13:41 ` [PATCH] signal: remove the wrong signal_pending() check in restore_user_sigmask() Oleg Nesterov
2019-06-04 15:31 ` Eric W. Biederman
2019-06-04 15:31 ` Eric W. Biederman
2019-06-04 15:57 ` David Laight
2019-06-04 15:57 ` David Laight
2019-06-04 16:37 ` Arnd Bergmann
2019-06-04 18:14 ` Deepa Dinamani
2019-06-04 18:35 ` Eric Wong
2019-06-04 21:26 ` Linus Torvalds
2019-06-04 22:24 ` Eric Wong
2019-06-04 23:51 ` Eric W. Biederman
2019-06-05 9:04 ` Oleg Nesterov
2019-06-05 8:56 ` Oleg Nesterov
2019-06-05 9:02 ` David Laight
2019-06-05 9:25 ` Oleg Nesterov
2019-06-05 9:58 ` David Laight
2019-06-05 15:58 ` [PATCH -mm 0/1] signal: simplify set_user_sigmask/restore_user_sigmask Oleg Nesterov
2019-06-05 15:58 ` [PATCH -mm 1/1] " Oleg Nesterov
2019-06-06 0:14 ` kbuild test robot [this message]
2019-06-06 1:06 ` kbuild test robot
2019-06-06 7:25 ` Oleg Nesterov
2019-06-06 7:30 ` Sedat Dilek
2019-06-05 17:24 ` [PATCH -mm 0/1] " Linus Torvalds
2019-06-06 9:05 ` David Laight
2019-06-06 11:05 ` Oleg Nesterov
2019-06-06 11:29 ` David Laight
2019-06-06 12:41 ` Oleg Nesterov
2019-06-06 13:23 ` David Laight
2019-06-06 10:22 ` Oleg Nesterov
2019-06-06 11:32 ` [PATCH -mm V2 1/1] " Oleg Nesterov
2019-06-06 14:08 ` [PATCH 0/2] select: simplify the usage of restore_saved_sigmask_unless() Oleg Nesterov
2019-06-06 14:08 ` [PATCH 1/2] select: change do_poll() to return -ERESTARTNOHAND rather than -EINTR Oleg Nesterov
2019-06-07 18:05 ` Linus Torvalds
2019-06-06 14:09 ` [PATCH 2/2] select: shift restore_saved_sigmask_unless() into poll_select_copy_remaining() Oleg Nesterov
2019-06-07 21:39 ` [RFC PATCH 0/5]: Removing saved_sigmask Eric W. Biederman
2019-06-07 21:39 ` Eric W. Biederman
2019-06-07 21:41 ` [RFC PATCH 1/5] signal: Teach sigsuspend to use set_user_sigmask Eric W. Biederman
2019-06-07 21:41 ` Eric W. Biederman
2019-06-07 21:41 ` Eric W. Biederman
2019-06-07 22:07 ` Linus Torvalds
2019-06-07 22:07 ` Linus Torvalds
2019-06-10 16:22 ` Oleg Nesterov
2019-06-10 21:20 ` Eric W. Biederman
2019-06-11 9:52 ` David Laight
2019-06-11 11:14 ` David Laight
2019-06-12 12:55 ` Eric W. Biederman
2019-06-12 12:55 ` Eric W. Biederman
2019-06-12 12:55 ` Eric W. Biederman
2019-06-12 13:24 ` David Laight
2019-06-12 13:24 ` David Laight
2019-06-12 13:35 ` Oleg Nesterov
2019-06-12 13:35 ` Oleg Nesterov
2019-06-12 13:39 ` David Laight
2019-06-12 13:39 ` David Laight
2019-06-11 15:46 ` David Laight
2019-06-11 15:46 ` David Laight
2019-06-12 12:40 ` Eric W. Biederman
2019-06-12 12:40 ` Eric W. Biederman
2019-06-12 12:40 ` Eric W. Biederman
2019-06-12 13:45 ` Oleg Nesterov
2019-06-12 14:18 ` David Laight
2019-06-12 15:11 ` Eric W. Biederman
2019-06-12 15:11 ` Eric W. Biederman
2019-06-12 15:37 ` Oleg Nesterov
2019-06-12 15:37 ` Oleg Nesterov
2019-06-13 8:48 ` David Laight
2019-06-13 8:48 ` David Laight
2019-06-13 9:43 ` Oleg Nesterov
2019-06-13 9:43 ` Oleg Nesterov
2019-06-13 10:56 ` David Laight
2019-06-13 10:56 ` David Laight
2019-06-13 12:43 ` Oleg Nesterov
2019-06-13 12:43 ` Oleg Nesterov
2019-06-11 18:55 ` Oleg Nesterov
2019-06-11 19:02 ` Eric W. Biederman
2019-06-11 19:02 ` Eric W. Biederman
2019-06-12 8:39 ` David Laight
2019-06-12 13:09 ` Eric W. Biederman
2019-06-12 13:09 ` Eric W. Biederman
2019-06-12 13:09 ` Eric W. Biederman
2019-06-07 21:41 ` [RFC PATCH 2/5] signal/kvm: Stop using sigprocmask in kvm_sigset_(activate|deactivate) Eric W. Biederman
2019-06-07 21:41 ` Eric W. Biederman
2019-06-07 21:41 ` Eric W. Biederman
2019-06-07 21:42 ` [RFC PATCH 3/5] signal: Always keep real_blocked in sync with blocked Eric W. Biederman
2019-06-07 21:42 ` Eric W. Biederman
2019-06-07 21:42 ` Eric W. Biederman
2019-06-07 21:43 ` [RFC PATCH 4/5] signal: Remove saved_sigmask Eric W. Biederman
2019-06-07 21:43 ` Eric W. Biederman
2019-06-07 21:43 ` Eric W. Biederman
2019-06-07 21:44 ` [RFC PATCH 5/5] signal: Remove the unnecessary restore_sigmask flag Eric W. Biederman
2019-06-07 21:44 ` Eric W. Biederman
2019-06-07 21:44 ` Eric W. Biederman
2019-06-11 18:58 ` [RFC PATCH 0/5]: Removing saved_sigmask Oleg Nesterov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201906060849.y7IR5OFp%lkp@intel.com \
--to=lkp@intel.com \
--cc=David.Laight@ACULAB.COM \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=axboe@kernel.dk \
--cc=dave@stgolabs.net \
--cc=dbueso@suse.de \
--cc=deepa.kernel@gmail.com \
--cc=e@80x24.org \
--cc=ebiederm@xmission.com \
--cc=jbaron@akamai.com \
--cc=kbuild-all@01.org \
--cc=linux-aio@kvack.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oleg@redhat.com \
--cc=omar.kilani@gmail.com \
--cc=stable@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.