All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andi Shyti <andi.shyti@intel.com>
To: Petri Latvala <petri.latvala@intel.com>
Cc: igt-dev@lists.freedesktop.org, Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Subject: Re: [igt-dev] [PATCH i-g-t] perf_pmu: Remove redundant check for engine
Date: Thu, 6 Jun 2019 12:46:25 +0300	[thread overview]
Message-ID: <20190606094625.GA2629@intel.intel> (raw)
In-Reply-To: <20190605123815.28529-1-petri.latvala@intel.com>

Hi Petri,

On Wed, Jun 05, 2019 at 03:38:15PM +0300, Petri Latvala wrote:
> __for_each_physical_engine already iterates over only engines that
> exist, we don't need to check again that they exist.
> 
> Removing the check also makes their respective subtest_groups not
> needed.
> 
> Signed-off-by: Petri Latvala <petri.latvala@intel.com>
> Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> Cc: Andi Shyti <andi.shyti@intel.com>

looks good,

Tested-by: Andi Shyti <andi.shyti@intel.com>

Thanks,
Andi
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

  parent reply	other threads:[~2019-06-06  9:46 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-05 12:38 [igt-dev] [PATCH i-g-t] perf_pmu: Remove redundant check for engine Petri Latvala
2019-06-05 14:17 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2019-06-06  9:46 ` Andi Shyti [this message]
2019-06-06 23:37 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190606094625.GA2629@intel.intel \
    --to=andi.shyti@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=petri.latvala@intel.com \
    --cc=tvrtko.ursulin@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.