All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Andrea Parri <andrea.parri@amarulasolutions.com>,
	linux-kernel@vger.kernel.org, will.deacon@arm.com, arnd@arndb.de,
	jhansen@vmware.com, vdasa@vmware.com, aditr@vmware.com,
	Steven Rostedt <rostedt@goodmis.org>
Subject: Re: [PATCH] VMCI: Fixup atomic64_t abuse
Date: Thu, 6 Jun 2019 18:02:28 +0200	[thread overview]
Message-ID: <20190606160228.GA29583@kroah.com> (raw)
In-Reply-To: <20190606093428.GF3402@hirez.programming.kicks-ass.net>

On Thu, Jun 06, 2019 at 11:34:28AM +0200, Peter Zijlstra wrote:
> 
> The VMCI driver is abusing atomic64_t and atomic_t, there is no actual
> atomic RmW operations around.
> 
> Rewrite the code to use a regular u64 with READ_ONCE() and
> WRITE_ONCE() and a cast to 'unsigned long'. This fully preserves
> whatever broken there was (it's not endian-safe for starters, and also
> looks to be missing ordering).
> 
> Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
> ---
>  include/linux/vmw_vmci_defs.h |   30 ++++++++++--------------------
>  1 file changed, 10 insertions(+), 20 deletions(-)

Now applied.

It's pretty horrid code, at least it's a tiny bit better now...

thanks,

greg k-h

      parent reply	other threads:[~2019-06-06 16:02 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-06  9:34 [PATCH] VMCI: Fixup atomic64_t abuse Peter Zijlstra
2019-06-06 15:54 ` Jorgen Hansen
2019-06-06 16:03   ` Greg Kroah-Hartman
2019-06-06 17:03   ` Peter Zijlstra
2019-06-06 16:02 ` Greg Kroah-Hartman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190606160228.GA29583@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=aditr@vmware.com \
    --cc=andrea.parri@amarulasolutions.com \
    --cc=arnd@arndb.de \
    --cc=jhansen@vmware.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peterz@infradead.org \
    --cc=rostedt@goodmis.org \
    --cc=vdasa@vmware.com \
    --cc=will.deacon@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.