From: Sean Christopherson <sean.j.christopherson@intel.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org
Subject: Re: [PATCH] KVM: x86: introduce is_pae_paging
Date: Thu, 6 Jun 2019 10:20:34 -0700 [thread overview]
Message-ID: <20190606172033.GD23169@linux.intel.com> (raw)
In-Reply-To: <1559839972-124144-1-git-send-email-pbonzini@redhat.com>
On Thu, Jun 06, 2019 at 06:52:52PM +0200, Paolo Bonzini wrote:
> Checking for 32-bit PAE is quite common around code that fiddles with
> the PDPTRs. Add a function to compress all checks into a single
> invocation.
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
I considered adding this helper as well, but shied away because I thought
it might lead to incorrect code, e.g. using is_pae_paging() when is_pae()
is needed. But, looking at the patch, it's definitely cleaner, so:
Reviewed-by: Sean Christopherson <sean.j.christopherson@intel.com>
prev parent reply other threads:[~2019-06-06 17:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-06 16:52 [PATCH] KVM: x86: introduce is_pae_paging Paolo Bonzini
2019-06-06 17:20 ` Sean Christopherson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190606172033.GD23169@linux.intel.com \
--to=sean.j.christopherson@intel.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.