All of lore.kernel.org
 help / color / mirror / Atom feed
From: Adrian Bunk <bunk@stusta.de>
To: Richard Purdie <richard.purdie@linuxfoundation.org>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] Remove manual RDEPENDS from PN-ptest to PN package
Date: Thu, 6 Jun 2019 21:44:10 +0300	[thread overview]
Message-ID: <20190606184410.GA5907@localhost> (raw)
In-Reply-To: <a71198580613e3ad0d8ce05717e56a27db9a5e21.camel@linuxfoundation.org>

On Wed, Jun 05, 2019 at 08:10:31PM +0100, Richard Purdie wrote:
> On Wed, 2019-06-05 at 21:41 +0300, Adrian Bunk wrote:
>...
> > --- a/meta/recipes-devtools/elfutils/elfutils_0.176.bb
> > +++ b/meta/recipes-devtools/elfutils/elfutils_0.176.bb
> > @@ -44,7 +44,7 @@ inherit autotools gettext ptest
> >  
> >  EXTRA_OECONF = "--program-prefix=eu- --without-lzma"
> >  EXTRA_OECONF_append_class-native = " --without-bzlib"
> > -RDEPENDS_${PN}-ptest = "libasm libelf bash make coreutils ${PN}-binutils ${PN}"
> > +RDEPENDS_${PN}-ptest = "libasm libelf bash make coreutils ${PN}-binutils"
> 
> Won't that need a += there to preserve the class definition?

Nice catch, v2 sent.

> How was this tested?

It looked obviously correct (famous last words...),
and I trust that this is breakage that would be
caught on the autobuilder.

> Cheers,
> 
> Richard

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed



  reply	other threads:[~2019-06-06 18:44 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-05 18:41 [PATCH] Remove manual RDEPENDS from PN-ptest to PN package Adrian Bunk
2019-06-05 19:10 ` Richard Purdie
2019-06-06 18:44   ` Adrian Bunk [this message]
2019-06-06 22:47     ` richard.purdie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190606184410.GA5907@localhost \
    --to=bunk@stusta.de \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=richard.purdie@linuxfoundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.