From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, T_DKIMWL_WL_HIGH,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ECF6DC04AB5 for ; Thu, 6 Jun 2019 19:04:13 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CB61C2083D for ; Thu, 6 Jun 2019 19:04:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Qo3j/YCK"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="RxDmf2mc" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CB61C2083D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=YbXBQoazJrT4cwtWIi4BoIvz5wyDHxxPayOmSjYHRbs=; b=Qo3j/YCKFZ0Ja9 0tx/U8AhlP5nBBWnu4TmUnoXeep9FSAFj/dke+xekwWlEiDIXwTbRYq7qqYpF8zPYZ1SI9s/+Jiaj MXZ4T98yv5uxrBpewaO/0SfGVaEcIcf8GFqwcvV1GluIouMCzLD3WJBzxAQhbBuCb3dzHYO7dJ3XV Dj3MQOA9N11xB6snQUWlQ5gSTIzpNbHJDMjgoUvm64H9ZWCA+HbT2J7jEXnTdXELWXFreq/SwMbiw M2Ft+kuhZ9X/wVeeodBs2MlGH0jC+1wmDZbB/auIoMjhFYSC4f5UC8H+x8toPkZw8z8paD8GGQVGP EJgNKNtBXAGbaibA6auQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hYxgK-0003CT-QL; Thu, 06 Jun 2019 19:04:12 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hYxgH-0003BY-Do for linux-arm-kernel@lists.infradead.org; Thu, 06 Jun 2019 19:04:10 +0000 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D0A732083D; Thu, 6 Jun 2019 19:04:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1559847848; bh=nE5tGyT6iFVO9pBfrN6905TKjYR4oXGv9UpQLxq2xgY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=RxDmf2mcACTGIUiuRUAm1Ea0Trtu3Cn0u0iT4HNZ9Gh89PFTWYeZ+3wztGyJSKA1X AvUyB9vrGAXKCQ2o/hJ0pzjjaPBHCoPOSw3e84JQ5Qz9Y94alVllfuBMgDLvhMtdKj OQ0htRourVGkq0rT4gO/WsBOnzSNrAguP7YZ0HzQ= Date: Thu, 6 Jun 2019 21:04:06 +0200 From: Greg KH To: Dragan Cvetic Subject: Re: [PATCH V4 02/12] misc: xilinx-sdfec: add core driver Message-ID: <20190606190406.GA20166@kroah.com> References: <1558784245-108751-1-git-send-email-dragan.cvetic@xilinx.com> <1558784245-108751-3-git-send-email-dragan.cvetic@xilinx.com> <20190606132517.GA7943@kroah.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.12.0 (2019-05-25) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190606_120409_476599_817CB5F5 X-CRM114-Status: GOOD ( 10.42 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "mark.rutland@arm.com" , "devicetree@vger.kernel.org" , "arnd@arndb.de" , "linux-kernel@vger.kernel.org" , "robh+dt@kernel.org" , Michal Simek , Derek Kiernan , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Jun 06, 2019 at 06:16:48PM +0000, Dragan Cvetic wrote: > > > > > + > > > + misc_deregister(&xsdfec->miscdev); > > > + atomic_dec(&xsdfec_ndevs); > > > + return 0; > > > > You free nothing? > > > > You are leaking resources like crazy here, this is not ok at all. > > The managed resources are used. > Anyway, I'll test for memory leak and search for the answer. Oops, no, you are right, I missed the "devm" prefix on those calls. My fault. thanks, greg k-h _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg KH Subject: Re: [PATCH V4 02/12] misc: xilinx-sdfec: add core driver Date: Thu, 6 Jun 2019 21:04:06 +0200 Message-ID: <20190606190406.GA20166@kroah.com> References: <1558784245-108751-1-git-send-email-dragan.cvetic@xilinx.com> <1558784245-108751-3-git-send-email-dragan.cvetic@xilinx.com> <20190606132517.GA7943@kroah.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Dragan Cvetic Cc: "arnd@arndb.de" , Michal Simek , "linux-arm-kernel@lists.infradead.org" , "robh+dt@kernel.org" , "mark.rutland@arm.com" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Derek Kiernan List-Id: devicetree@vger.kernel.org On Thu, Jun 06, 2019 at 06:16:48PM +0000, Dragan Cvetic wrote: > > > > > + > > > + misc_deregister(&xsdfec->miscdev); > > > + atomic_dec(&xsdfec_ndevs); > > > + return 0; > > > > You free nothing? > > > > You are leaking resources like crazy here, this is not ok at all. > > The managed resources are used. > Anyway, I'll test for memory leak and search for the answer. Oops, no, you are right, I missed the "devm" prefix on those calls. My fault. thanks, greg k-h