All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Ahern <dsahern@kernel.org>
To: davem@davemloft.net, netdev@vger.kernel.org
Cc: idosch@mellanox.com, kafai@fb.com, weiwan@google.com,
	sbrivio@redhat.com, David Ahern <dsahern@gmail.com>
Subject: [PATCH v2 net-next 08/20] ipv6: Handle all fib6_nh in a nexthop in __ip6_route_redirect
Date: Fri,  7 Jun 2019 08:09:29 -0700	[thread overview]
Message-ID: <20190607150941.11371-9-dsahern@kernel.org> (raw)
In-Reply-To: <20190607150941.11371-1-dsahern@kernel.org>

From: David Ahern <dsahern@gmail.com>

Add a hook in __ip6_route_redirect to handle a nexthop struct in a
fib6_info. Use nexthop_for_each_fib6_nh and fib6_nh_redirect_match
to call ip6_redirect_nh_match for each fib6_nh looking for a match.

Signed-off-by: David Ahern <dsahern@gmail.com>
---
 net/ipv6/route.c | 39 +++++++++++++++++++++++++++++++++++----
 1 file changed, 35 insertions(+), 4 deletions(-)

diff --git a/net/ipv6/route.c b/net/ipv6/route.c
index 883997c591d7..20bb19d4141e 100644
--- a/net/ipv6/route.c
+++ b/net/ipv6/route.c
@@ -2791,6 +2791,21 @@ static bool ip6_redirect_nh_match(const struct fib6_result *res,
 	return true;
 }
 
+struct fib6_nh_rd_arg {
+	struct fib6_result	*res;
+	struct flowi6		*fl6;
+	const struct in6_addr	*gw;
+	struct rt6_info		**ret;
+};
+
+static int fib6_nh_redirect_match(struct fib6_nh *nh, void *_arg)
+{
+	struct fib6_nh_rd_arg *arg = _arg;
+
+	arg->res->nh = nh;
+	return ip6_redirect_nh_match(arg->res, arg->fl6, arg->gw, arg->ret);
+}
+
 /* Handle redirects */
 struct ip6rd_flowi {
 	struct flowi6 fl6;
@@ -2806,6 +2821,12 @@ static struct rt6_info *__ip6_route_redirect(struct net *net,
 	struct ip6rd_flowi *rdfl = (struct ip6rd_flowi *)fl6;
 	struct rt6_info *ret = NULL;
 	struct fib6_result res = {};
+	struct fib6_nh_rd_arg arg = {
+		.res = &res,
+		.fl6 = fl6,
+		.gw  = &rdfl->gateway,
+		.ret = &ret
+	};
 	struct fib6_info *rt;
 	struct fib6_node *fn;
 
@@ -2830,14 +2851,24 @@ static struct rt6_info *__ip6_route_redirect(struct net *net,
 restart:
 	for_each_fib6_node_rt_rcu(fn) {
 		res.f6i = rt;
-		res.nh = rt->fib6_nh;
-
 		if (fib6_check_expired(rt))
 			continue;
 		if (rt->fib6_flags & RTF_REJECT)
 			break;
-		if (ip6_redirect_nh_match(&res, fl6, &rdfl->gateway, &ret))
-			goto out;
+		if (unlikely(rt->nh)) {
+			if (nexthop_is_blackhole(rt->nh))
+				continue;
+			/* on match, res->nh is filled in and potentially ret */
+			if (nexthop_for_each_fib6_nh(rt->nh,
+						     fib6_nh_redirect_match,
+						     &arg))
+				goto out;
+		} else {
+			res.nh = rt->fib6_nh;
+			if (ip6_redirect_nh_match(&res, fl6, &rdfl->gateway,
+						  &ret))
+				goto out;
+		}
 	}
 
 	if (!rt)
-- 
2.11.0


  parent reply	other threads:[~2019-06-07 15:10 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-07 15:09 [PATCH v2 net-next 00/20] net: Enable nexthop objects with IPv4 and IPv6 routes David Ahern
2019-06-07 15:09 ` [PATCH v2 net-next 01/20] nexthops: Add ipv6 helper to walk all fib6_nh in a nexthop struct David Ahern
2019-06-07 15:09 ` [PATCH v2 net-next 02/20] ipv6: Handle all fib6_nh in a nexthop in fib6_drop_pcpu_from David Ahern
2019-06-07 15:09 ` [PATCH v2 net-next 03/20] ipv6: Handle all fib6_nh in a nexthop in rt6_device_match David Ahern
2019-06-07 15:09 ` [PATCH v2 net-next 04/20] ipv6: Handle all fib6_nh in a nexthop in __find_rr_leaf David Ahern
2019-06-07 15:09 ` [PATCH v2 net-next 05/20] ipv6: Handle all fib6_nh in a nexthop in rt6_nlmsg_size David Ahern
2019-06-07 15:09 ` [PATCH v2 net-next 06/20] ipv6: Handle all fib6_nh in a nexthop in fib6_info_uses_dev David Ahern
2019-06-07 15:09 ` [PATCH v2 net-next 07/20] ipv6: Handle all fib6_nh in a nexthop in exception handling David Ahern
2019-06-07 22:05   ` Wei Wang
2019-06-07 22:39     ` David Ahern
2019-06-07 15:09 ` David Ahern [this message]
2019-06-07 15:09 ` [PATCH v2 net-next 09/20] ipv6: Handle all fib6_nh in a nexthop in rt6_do_redirect David Ahern
2019-06-07 15:09 ` [PATCH v2 net-next 10/20] ipv6: Handle all fib6_nh in a nexthop in mtu updates David Ahern
2019-06-07 15:09 ` [PATCH v2 net-next 11/20] ipv4: Allow routes to use nexthop objects David Ahern
2019-06-07 15:09 ` [PATCH v2 net-next 12/20] ipv4: Optimization for fib_info lookup with nexthops David Ahern
2019-06-07 15:09 ` [PATCH v2 net-next 13/20] ipv6: Allow routes to use nexthop objects David Ahern
2019-06-07 15:09 ` [PATCH v2 net-next 14/20] nexthops: add support for replace David Ahern
2019-06-07 15:09 ` [PATCH v2 net-next 15/20] selftests: pmtu: Move running of test into a new function David Ahern
2019-06-07 15:09 ` [PATCH v2 net-next 16/20] selftests: pmtu: Move route installs to " David Ahern
2019-06-07 15:09 ` [PATCH v2 net-next 17/20] selftests: pmtu: Add support for routing via nexthop objects David Ahern
2019-06-07 15:09 ` [PATCH v2 net-next 18/20] selftests: icmp_redirect: " David Ahern
2019-06-07 15:09 ` [PATCH v2 net-next 19/20] selftests: Add test with multiple prefixes using single nexthop David Ahern
2019-06-07 15:09 ` [PATCH v2 net-next 20/20] selftests: Add version of router_multipath.sh using nexthop objects David Ahern

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190607150941.11371-9-dsahern@kernel.org \
    --to=dsahern@kernel.org \
    --cc=davem@davemloft.net \
    --cc=dsahern@gmail.com \
    --cc=idosch@mellanox.com \
    --cc=kafai@fb.com \
    --cc=netdev@vger.kernel.org \
    --cc=sbrivio@redhat.com \
    --cc=weiwan@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.