From: Eduardo Habkost <ehabkost@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>,
qemu-devel@nongnu.org, Cleber Rosa <crosa@redhat.com>
Cc: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
Subject: [Qemu-devel] [PULL 4/8] BootLinuxConsoleTest: Do not log empty lines
Date: Fri, 7 Jun 2019 18:15:40 -0300 [thread overview]
Message-ID: <20190607211544.7964-5-ehabkost@redhat.com> (raw)
In-Reply-To: <20190607211544.7964-1-ehabkost@redhat.com>
From: Philippe Mathieu-Daudé <f4bug@amsat.org>
Avoid to log empty lines in console debug logs.
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Message-Id: <20190520220635.10961-2-f4bug@amsat.org>
Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
Reviewed-by: Cleber Rosa <crosa@redhat.com>
Tested-by: Cleber Rosa <crosa@redhat.com>
Acked-by: Aleksandar Markovic <amarkovic@wavecomp.com>
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
---
tests/acceptance/boot_linux_console.py | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/tests/acceptance/boot_linux_console.py b/tests/acceptance/boot_linux_console.py
index 6aa084e049..e86e66900a 100644
--- a/tests/acceptance/boot_linux_console.py
+++ b/tests/acceptance/boot_linux_console.py
@@ -37,8 +37,10 @@ class BootLinuxConsole(Test):
console = self.vm.console_socket.makefile()
console_logger = logging.getLogger('console')
while True:
- msg = console.readline()
- console_logger.debug(msg.strip())
+ msg = console.readline().strip()
+ if not msg:
+ continue
+ console_logger.debug(msg)
if success_message in msg:
break
if failure_message in msg:
--
2.18.0.rc1.1.g3f1ff2140
next prev parent reply other threads:[~2019-06-07 21:22 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-07 21:15 [Qemu-devel] [PULL 0/8] Python queue, 2019-06-07 Eduardo Habkost
2019-06-07 21:15 ` [Qemu-devel] [PULL 1/8] tests/boot_linux_console: Let extract_from_deb handle various compressions Eduardo Habkost
2019-06-07 21:15 ` [Qemu-devel] [PULL 2/8] Deprecate Python 2 support Eduardo Habkost
2019-06-07 21:15 ` [Qemu-devel] [PULL 3/8] configure: Require python3 >= 3.5 Eduardo Habkost
2019-06-07 21:15 ` Eduardo Habkost [this message]
2019-06-07 21:15 ` [Qemu-devel] [PULL 5/8] BootLinuxConsoleTest: Test the SmartFusion2 board Eduardo Habkost
2019-06-07 21:15 ` [Qemu-devel] [PULL 6/8] BootLinuxConsoleTest: Test nanoMIPS kernels on the I7200 CPU Eduardo Habkost
2019-06-07 21:15 ` [Qemu-devel] [PULL 7/8] BootLinuxConsoleTest: Run kerneltests BusyBox on Malta Eduardo Habkost
2019-06-07 21:15 ` [Qemu-devel] [PULL 8/8] travis: Make check-acceptance job more verbose Eduardo Habkost
2019-06-10 21:03 ` Wainer dos Santos Moschetta
2019-06-10 12:58 ` [Qemu-devel] [PULL 0/8] Python queue, 2019-06-07 Peter Maydell
2019-06-10 13:11 ` Eduardo Habkost
2019-06-10 13:21 ` Peter Maydell
2019-06-10 16:57 ` [Qemu-devel] Ubuntu Trusty as supported build platform (was Re: [PULL 0/8] Python queue, 2019-06-07) Eduardo Habkost
2019-06-10 17:12 ` [Qemu-devel] [PULL 0/8] Python queue, 2019-06-07 Daniel P. Berrangé
2019-06-10 17:15 ` Peter Maydell
2019-06-10 17:30 ` Daniel P. Berrangé
2019-06-10 17:38 ` Peter Maydell
2019-06-10 17:40 ` Daniel P. Berrangé
2019-06-11 15:50 ` Peter Maydell
2019-06-11 16:03 ` Eduardo Habkost
2019-06-11 16:07 ` Peter Maydell
2019-06-11 17:12 ` Eduardo Habkost
2019-09-17 13:57 ` Kevin Wolf
2019-09-17 21:48 ` Eduardo Habkost
2019-09-17 23:10 ` John Snow
2019-09-17 23:37 ` Eduardo Habkost
2019-09-18 7:50 ` Kevin Wolf
2019-07-01 22:25 ` [Qemu-devel] Python 2 in tests/vm (was Re: [PULL 0/8] Python queue, 2019-06-07) Eduardo Habkost
2019-09-17 23:31 ` Eduardo Habkost
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190607211544.7964-5-ehabkost@redhat.com \
--to=ehabkost@redhat.com \
--cc=crosa@redhat.com \
--cc=f4bug@amsat.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.