From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 288B0C2BCA1 for ; Fri, 7 Jun 2019 23:12:36 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DB3FA204FD for ; Fri, 7 Jun 2019 23:12:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="VMk2GOPg"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="L+DoBBYW" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DB3FA204FD Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=itYaJb5WfbN8H2QP5ETE9+qCnL6xqP/kChX+1XHvdLA=; b=VMk2GOPgoDugpA nSeea7+rsnw7zaShZ5tA4wAp7qk/gmUaz1b+lf/UY3kti1PAlzeZ8so3GpHSWiR74WV+SEubiiUb2 k5Z5mOtgEMDOhe1oFYG+ENsLYeHDX9ov2VBsZ79PDXI/s6TH+mgWx+eyewzjFStu7Zq6ZegMsP2wP OLNrVrqgWwUuMT9mlpJRlGWg0li00Wf4d4Striyh0KIHIvlfK51y6ll7qXVLFjlP+q+/mZR1Rv9My pe9G1NFVYjZxOJEGNZ+5tqzVsJxbC7ict6LpDmNGEV+qLxqDS0Jh611gWY1FgFOTHFDRt7klKKayS jqENsHhiKBXdBhBbGGQg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hZO28-00026v-K2; Fri, 07 Jun 2019 23:12:28 +0000 Received: from mail-wm1-x341.google.com ([2a00:1450:4864:20::341]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hZO0x-0000wr-9A for linux-arm-kernel@lists.infradead.org; Fri, 07 Jun 2019 23:11:16 +0000 Received: by mail-wm1-x341.google.com with SMTP id u8so3304270wmm.1 for ; Fri, 07 Jun 2019 16:11:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=7GEHwh/r4T7qgHwLm9BpliTLYMp1uwbqc4fRyWp+9LU=; b=L+DoBBYW26kUIiCrZIML4fSKfVB4+Han2fYg+Y+AEfOvdl6df+liQaUdhkPwlO/6Sf pRl9IKkOjj7XH+t7RhROSpgvi7iJ/cGIrO5K8x2XUaeBtCIlCN69lBw3xJGH0SCWdiTX 3/Drvnay9CxdWDckD/1+NYBBoK0hkiW9wwCfEan0KIFCVtSgVGWhkkYuA4IVk6aO7/uw MSTuWMTP/BV2TLHL92zr7hK0rMHELO7ZjE35vSj9ASO3Xvkj8gj0+fCDol/d4lKNp26J bWllR9eNc40qX/5xhp9XWmMYN6Pr/pCpzLnzIQFczG2w2E7FfYajR75sYXUxGsMbJfni uECg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=7GEHwh/r4T7qgHwLm9BpliTLYMp1uwbqc4fRyWp+9LU=; b=ky4ex4kmYgOsstpuUPHlXPYqCnHUMFFfuvTJis8cIvvWDFQH0+Y1qavgAGJKGKfGCV DIJDnG8ifAoKlqqZITCiRwYjrbQ/i5Gd6egW/u9xxc3NiCEjOVMzPF+U2N6z646Wv5nL QWORo+IdUqgVOWTx7+UtkMfd0RDY8oBd33CcuDKfJzU8Aop+I0c+ZLuyOi3veNP9dPgs +ScjqF4xdAuXo/Oqz5TxDHriFWZnCHIIJ3mCPyR5hcDy32Fi6gz9VNjlRE4iK+48kXqM r7yxR4F8E5mdjxtVhnk8Woj7HlOe1VpPbExWQcMiAwchNLOPEkRzf/a5pGxYX+IwwJrD bw8Q== X-Gm-Message-State: APjAAAWrV9d8p4VX1kPn6ovUMx/Q7ZCj2RAQNh6LYjxF9mb1Vr8RNinW vgNUqopcjJq1yp5R78Mpcug= X-Google-Smtp-Source: APXvYqwUfHoRNiyI8qxZ99qGY5vY4n9q91qmbDFEOvJJaMrhrSb6D3nxxuEgESrd+BAF3/p7lUwjyQ== X-Received: by 2002:a1c:1d83:: with SMTP id d125mr5140296wmd.63.1559949073446; Fri, 07 Jun 2019 16:11:13 -0700 (PDT) Received: from localhost.localdomain ([2a01:e0a:1f1:d0f0::4e2b:d7ca]) by smtp.gmail.com with ESMTPSA id h84sm4108559wmf.43.2019.06.07.16.11.12 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Fri, 07 Jun 2019 16:11:12 -0700 (PDT) From: =?UTF-8?q?Cl=C3=A9ment=20P=C3=A9ron?= To: Mauro Carvalho Chehab , Rob Herring , Mark Rutland , Maxime Ripard , Chen-Yu Tsai Subject: [PATCH v5 04/13] media: rc: sunxi: Add RXSTA bits definition Date: Sat, 8 Jun 2019 01:10:51 +0200 Message-Id: <20190607231100.5894-5-peron.clem@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190607231100.5894-1-peron.clem@gmail.com> References: <20190607231100.5894-1-peron.clem@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190607_161115_365744_EC5E347C X-CRM114-Status: GOOD ( 13.08 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com, =?UTF-8?q?Cl=C3=A9ment=20P=C3=A9ron?= , linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org V2UgYXJlIHVzaW5nIFJYSU5UIGJpdHMgZGVmaW5pdGlvbiB3aGVuIGxvb2tpbmcgYXQgUlhTVEEg cmVnaXN0ZXIuCgpUaGVzZSBiaXRzIGFyZSBlcXVhbCBidXQgaXQncyBub3QgcmVhbGx5IHByb3Bl ci4KCkludHJvZHVjZSB0aGUgUlhTVEEgYml0cyBhbmQgdXNlIHRoZW0gdG8gaGF2ZSBjb2hlcmVu Y3kuCgpTaWduZWQtb2ZmLWJ5OiBDbMOpbWVudCBQw6lyb24gPHBlcm9uLmNsZW1AZ21haWwuY29t PgotLS0KIGRyaXZlcnMvbWVkaWEvcmMvc3VueGktY2lyLmMgfCAxOCArKysrKysrKysrKystLS0t LS0KIDEgZmlsZSBjaGFuZ2VkLCAxMiBpbnNlcnRpb25zKCspLCA2IGRlbGV0aW9ucygtKQoKZGlm ZiAtLWdpdCBhL2RyaXZlcnMvbWVkaWEvcmMvc3VueGktY2lyLmMgYi9kcml2ZXJzL21lZGlhL3Jj L3N1bnhpLWNpci5jCmluZGV4IDA1MDRlYmZjODMxZi4uNTY5MGQwYmQ1MWJjIDEwMDY0NAotLS0g YS9kcml2ZXJzL21lZGlhL3JjL3N1bnhpLWNpci5jCisrKyBiL2RyaXZlcnMvbWVkaWEvcmMvc3Vu eGktY2lyLmMKQEAgLTQ4LDExICs0OCwxMSBAQAogCiAvKiBSeCBJbnRlcnJ1cHQgRW5hYmxlICov CiAjZGVmaW5lIFNVTlhJX0lSX1JYSU5UX1JFRyAgICAweDJDCi0vKiBSeCBGSUZPIE92ZXJmbG93 ICovCisvKiBSeCBGSUZPIE92ZXJmbG93IEludGVycnVwdCBFbmFibGUgKi8KICNkZWZpbmUgUkVH X1JYSU5UX1JPSV9FTgkJQklUKDApCi0vKiBSeCBQYWNrZXQgRW5kICovCisvKiBSeCBQYWNrZXQg RW5kIEludGVycnVwdCBFbmFibGUgKi8KICNkZWZpbmUgUkVHX1JYSU5UX1JQRUlfRU4JCUJJVCgx KQotLyogUnggRklGTyBEYXRhIEF2YWlsYWJsZSAqLworLyogUnggRklGTyBEYXRhIEF2YWlsYWJs ZSBJbnRlcnJ1cHQgRW5hYmxlICovCiAjZGVmaW5lIFJFR19SWElOVF9SQUlfRU4JCUJJVCg0KQog CiAvKiBSeCBGSUZPIGF2YWlsYWJsZSBieXRlIGxldmVsICovCkBAIC02MCw2ICs2MCwxMiBAQAog CiAvKiBSeCBJbnRlcnJ1cHQgU3RhdHVzICovCiAjZGVmaW5lIFNVTlhJX0lSX1JYU1RBX1JFRyAg ICAweDMwCisvKiBSeCBGSUZPIE92ZXJmbG93ICovCisjZGVmaW5lIFJFR19SWFNUQV9ST0kJCQlS RUdfUlhJTlRfUk9JX0VOCisvKiBSeCBQYWNrZXQgRW5kICovCisjZGVmaW5lIFJFR19SWFNUQV9S UEUJCQlSRUdfUlhJTlRfUlBFSV9FTgorLyogUnggRklGTyBEYXRhIEF2YWlsYWJsZSAqLworI2Rl ZmluZSBSRUdfUlhTVEFfUkEJCQlSRUdfUlhJTlRfUkFJX0VOCiAvKiBSWCBGSUZPIEdldCBBdmFp bGFibGUgQ291bnRlciAqLwogI2RlZmluZSBSRUdfUlhTVEFfR0VUX0FDKHZhbCkgKCgodmFsKSA+ PiA4KSAmIChpci0+Zmlmb19zaXplICogMiAtIDEpKQogLyogQ2xlYXIgYWxsIGludGVycnVwdCBz dGF0dXMgdmFsdWUgKi8KQEAgLTExOSw3ICsxMjUsNyBAQCBzdGF0aWMgaXJxcmV0dXJuX3Qgc3Vu eGlfaXJfaXJxKGludCBpcnFubywgdm9pZCAqZGV2X2lkKQogCS8qIGNsZWFuIGFsbCBwZW5kaW5n IHN0YXR1c2VzICovCiAJd3JpdGVsKHN0YXR1cyB8IFJFR19SWFNUQV9DTEVBUkFMTCwgaXItPmJh c2UgKyBTVU5YSV9JUl9SWFNUQV9SRUcpOwogCi0JaWYgKHN0YXR1cyAmIChSRUdfUlhJTlRfUkFJ X0VOIHwgUkVHX1JYSU5UX1JQRUlfRU4pKSB7CisJaWYgKHN0YXR1cyAmIChSRUdfUlhTVEFfUkEg fCBSRUdfUlhTVEFfUlBFKSkgewogCQkvKiBIb3cgbWFueSBtZXNzYWdlcyBpbiBmaWZvICovCiAJ CXJjICA9IFJFR19SWFNUQV9HRVRfQUMoc3RhdHVzKTsKIAkJLyogU2FuaXR5IGNoZWNrICovCkBA IC0xMzUsOSArMTQxLDkgQEAgc3RhdGljIGlycXJldHVybl90IHN1bnhpX2lyX2lycShpbnQgaXJx bm8sIHZvaWQgKmRldl9pZCkKIAkJfQogCX0KIAotCWlmIChzdGF0dXMgJiBSRUdfUlhJTlRfUk9J X0VOKSB7CisJaWYgKHN0YXR1cyAmIFJFR19SWFNUQV9ST0kpIHsKIAkJaXJfcmF3X2V2ZW50X3Jl c2V0KGlyLT5yYyk7Ci0JfSBlbHNlIGlmIChzdGF0dXMgJiBSRUdfUlhJTlRfUlBFSV9FTikgewor CX0gZWxzZSBpZiAoc3RhdHVzICYgUkVHX1JYU1RBX1JQRSkgewogCQlpcl9yYXdfZXZlbnRfc2V0 X2lkbGUoaXItPnJjLCB0cnVlKTsKIAkJaXJfcmF3X2V2ZW50X2hhbmRsZShpci0+cmMpOwogCX0K LS0gCjIuMjAuMQoKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMu aW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZv L2xpbnV4LWFybS1rZXJuZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?q?Cl=C3=A9ment=20P=C3=A9ron?= Subject: [PATCH v5 04/13] media: rc: sunxi: Add RXSTA bits definition Date: Sat, 8 Jun 2019 01:10:51 +0200 Message-ID: <20190607231100.5894-5-peron.clem@gmail.com> References: <20190607231100.5894-1-peron.clem@gmail.com> Reply-To: peron.clem-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Return-path: Sender: linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org In-Reply-To: <20190607231100.5894-1-peron.clem-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , To: Mauro Carvalho Chehab , Rob Herring , Mark Rutland , Maxime Ripard , Chen-Yu Tsai Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-media-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, =?UTF-8?q?Cl=C3=A9ment=20P=C3=A9ron?= List-Id: devicetree@vger.kernel.org We are using RXINT bits definition when looking at RXSTA register. These bits are equal but it's not really proper. Introduce the RXSTA bits and use them to have coherency. Signed-off-by: Cl=C3=A9ment P=C3=A9ron --- drivers/media/rc/sunxi-cir.c | 18 ++++++++++++------ 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/drivers/media/rc/sunxi-cir.c b/drivers/media/rc/sunxi-cir.c index 0504ebfc831f..5690d0bd51bc 100644 --- a/drivers/media/rc/sunxi-cir.c +++ b/drivers/media/rc/sunxi-cir.c @@ -48,11 +48,11 @@ =20 /* Rx Interrupt Enable */ #define SUNXI_IR_RXINT_REG 0x2C -/* Rx FIFO Overflow */ +/* Rx FIFO Overflow Interrupt Enable */ #define REG_RXINT_ROI_EN BIT(0) -/* Rx Packet End */ +/* Rx Packet End Interrupt Enable */ #define REG_RXINT_RPEI_EN BIT(1) -/* Rx FIFO Data Available */ +/* Rx FIFO Data Available Interrupt Enable */ #define REG_RXINT_RAI_EN BIT(4) =20 /* Rx FIFO available byte level */ @@ -60,6 +60,12 @@ =20 /* Rx Interrupt Status */ #define SUNXI_IR_RXSTA_REG 0x30 +/* Rx FIFO Overflow */ +#define REG_RXSTA_ROI REG_RXINT_ROI_EN +/* Rx Packet End */ +#define REG_RXSTA_RPE REG_RXINT_RPEI_EN +/* Rx FIFO Data Available */ +#define REG_RXSTA_RA REG_RXINT_RAI_EN /* RX FIFO Get Available Counter */ #define REG_RXSTA_GET_AC(val) (((val) >> 8) & (ir->fifo_size * 2 - 1)) /* Clear all interrupt status value */ @@ -119,7 +125,7 @@ static irqreturn_t sunxi_ir_irq(int irqno, void *dev_id= ) /* clean all pending statuses */ writel(status | REG_RXSTA_CLEARALL, ir->base + SUNXI_IR_RXSTA_REG); =20 - if (status & (REG_RXINT_RAI_EN | REG_RXINT_RPEI_EN)) { + if (status & (REG_RXSTA_RA | REG_RXSTA_RPE)) { /* How many messages in fifo */ rc =3D REG_RXSTA_GET_AC(status); /* Sanity check */ @@ -135,9 +141,9 @@ static irqreturn_t sunxi_ir_irq(int irqno, void *dev_id= ) } } =20 - if (status & REG_RXINT_ROI_EN) { + if (status & REG_RXSTA_ROI) { ir_raw_event_reset(ir->rc); - } else if (status & REG_RXINT_RPEI_EN) { + } else if (status & REG_RXSTA_RPE) { ir_raw_event_set_idle(ir->rc, true); ir_raw_event_handle(ir->rc); } --=20 2.20.1 --=20 You received this message because you are subscribed to the Google Groups "= linux-sunxi" group. To unsubscribe from this group and stop receiving emails from it, send an e= mail to linux-sunxi+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org To view this discussion on the web, visit https://groups.google.com/d/msgid= /linux-sunxi/20190607231100.5894-5-peron.clem%40gmail.com. For more options, visit https://groups.google.com/d/optout. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 70389C2BCA1 for ; Fri, 7 Jun 2019 23:12:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 45E4420825 for ; Fri, 7 Jun 2019 23:12:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="L+DoBBYW" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731865AbfFGXMH (ORCPT ); Fri, 7 Jun 2019 19:12:07 -0400 Received: from mail-wm1-f68.google.com ([209.85.128.68]:50859 "EHLO mail-wm1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731388AbfFGXLP (ORCPT ); Fri, 7 Jun 2019 19:11:15 -0400 Received: by mail-wm1-f68.google.com with SMTP id c66so3500476wmf.0; Fri, 07 Jun 2019 16:11:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=7GEHwh/r4T7qgHwLm9BpliTLYMp1uwbqc4fRyWp+9LU=; b=L+DoBBYW26kUIiCrZIML4fSKfVB4+Han2fYg+Y+AEfOvdl6df+liQaUdhkPwlO/6Sf pRl9IKkOjj7XH+t7RhROSpgvi7iJ/cGIrO5K8x2XUaeBtCIlCN69lBw3xJGH0SCWdiTX 3/Drvnay9CxdWDckD/1+NYBBoK0hkiW9wwCfEan0KIFCVtSgVGWhkkYuA4IVk6aO7/uw MSTuWMTP/BV2TLHL92zr7hK0rMHELO7ZjE35vSj9ASO3Xvkj8gj0+fCDol/d4lKNp26J bWllR9eNc40qX/5xhp9XWmMYN6Pr/pCpzLnzIQFczG2w2E7FfYajR75sYXUxGsMbJfni uECg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=7GEHwh/r4T7qgHwLm9BpliTLYMp1uwbqc4fRyWp+9LU=; b=FE7bjhZZU3fBPWaguXgyY23ae1nvPUorh+eucO1V4TTekWx3o/sDHK8K2++AoUENfO w+n78L3Dvxu5R9gIo/YLH7SjvI2PKmCBXPtMS5tP3ethXpnRUkxmSosb4sZVDs3Vo5Qw 11kya/1LLsuJPOOKlOOB5kf9Jvy7ffraSmklT8JkKZaw9oF+RT/VVp5h0VOfw0VlhAt8 f3frrakiKnFnlrmBcRUeBcilbxq6+s9x05bnArUtBbQ96Ew3oFyPViduPz9m9tqpqvIB 0iYvsmU0xQc0uEn5+hCo8sIyiNLz4W2V2ZO5RtnUOY1Mi2xF+wjyprkb5jAGK+FcwmAr El7A== X-Gm-Message-State: APjAAAX16nrpnTEFsUdtYpTrF2jCMIJ0SOWu1+OzYY6AufZZHJfAx56X DS5QHPtXB/qvBpA+gAWAXAA= X-Google-Smtp-Source: APXvYqwUfHoRNiyI8qxZ99qGY5vY4n9q91qmbDFEOvJJaMrhrSb6D3nxxuEgESrd+BAF3/p7lUwjyQ== X-Received: by 2002:a1c:1d83:: with SMTP id d125mr5140296wmd.63.1559949073446; Fri, 07 Jun 2019 16:11:13 -0700 (PDT) Received: from localhost.localdomain ([2a01:e0a:1f1:d0f0::4e2b:d7ca]) by smtp.gmail.com with ESMTPSA id h84sm4108559wmf.43.2019.06.07.16.11.12 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Fri, 07 Jun 2019 16:11:12 -0700 (PDT) From: =?UTF-8?q?Cl=C3=A9ment=20P=C3=A9ron?= To: Mauro Carvalho Chehab , Rob Herring , Mark Rutland , Maxime Ripard , Chen-Yu Tsai Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org, =?UTF-8?q?Cl=C3=A9ment=20P=C3=A9ron?= Subject: [PATCH v5 04/13] media: rc: sunxi: Add RXSTA bits definition Date: Sat, 8 Jun 2019 01:10:51 +0200 Message-Id: <20190607231100.5894-5-peron.clem@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190607231100.5894-1-peron.clem@gmail.com> References: <20190607231100.5894-1-peron.clem@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org We are using RXINT bits definition when looking at RXSTA register. These bits are equal but it's not really proper. Introduce the RXSTA bits and use them to have coherency. Signed-off-by: Clément Péron --- drivers/media/rc/sunxi-cir.c | 18 ++++++++++++------ 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/drivers/media/rc/sunxi-cir.c b/drivers/media/rc/sunxi-cir.c index 0504ebfc831f..5690d0bd51bc 100644 --- a/drivers/media/rc/sunxi-cir.c +++ b/drivers/media/rc/sunxi-cir.c @@ -48,11 +48,11 @@ /* Rx Interrupt Enable */ #define SUNXI_IR_RXINT_REG 0x2C -/* Rx FIFO Overflow */ +/* Rx FIFO Overflow Interrupt Enable */ #define REG_RXINT_ROI_EN BIT(0) -/* Rx Packet End */ +/* Rx Packet End Interrupt Enable */ #define REG_RXINT_RPEI_EN BIT(1) -/* Rx FIFO Data Available */ +/* Rx FIFO Data Available Interrupt Enable */ #define REG_RXINT_RAI_EN BIT(4) /* Rx FIFO available byte level */ @@ -60,6 +60,12 @@ /* Rx Interrupt Status */ #define SUNXI_IR_RXSTA_REG 0x30 +/* Rx FIFO Overflow */ +#define REG_RXSTA_ROI REG_RXINT_ROI_EN +/* Rx Packet End */ +#define REG_RXSTA_RPE REG_RXINT_RPEI_EN +/* Rx FIFO Data Available */ +#define REG_RXSTA_RA REG_RXINT_RAI_EN /* RX FIFO Get Available Counter */ #define REG_RXSTA_GET_AC(val) (((val) >> 8) & (ir->fifo_size * 2 - 1)) /* Clear all interrupt status value */ @@ -119,7 +125,7 @@ static irqreturn_t sunxi_ir_irq(int irqno, void *dev_id) /* clean all pending statuses */ writel(status | REG_RXSTA_CLEARALL, ir->base + SUNXI_IR_RXSTA_REG); - if (status & (REG_RXINT_RAI_EN | REG_RXINT_RPEI_EN)) { + if (status & (REG_RXSTA_RA | REG_RXSTA_RPE)) { /* How many messages in fifo */ rc = REG_RXSTA_GET_AC(status); /* Sanity check */ @@ -135,9 +141,9 @@ static irqreturn_t sunxi_ir_irq(int irqno, void *dev_id) } } - if (status & REG_RXINT_ROI_EN) { + if (status & REG_RXSTA_ROI) { ir_raw_event_reset(ir->rc); - } else if (status & REG_RXINT_RPEI_EN) { + } else if (status & REG_RXSTA_RPE) { ir_raw_event_set_idle(ir->rc, true); ir_raw_event_handle(ir->rc); } -- 2.20.1