From: Jonathan Cameron <jic23@kernel.org>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Dirk Eibach <eibach@gdsys.de>,
"linux-hwmon@vger.kernel.org" <linux-hwmon@vger.kernel.org>,
"linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>
Subject: Re: Removing ADS1015 driver from hwmon subsystem
Date: Sat, 8 Jun 2019 11:01:43 +0100 [thread overview]
Message-ID: <20190608110143.48a221bb@archlinux> (raw)
In-Reply-To: <4aaa9d0c-2ed9-ccd2-2d84-a5bda4ea4a23@roeck-us.net>
On Fri, 7 Jun 2019 18:13:27 -0700
Guenter Roeck <linux@roeck-us.net> wrote:
> Hi all,
>
> there are currently two drivers for ADS1015 in the linux kernel:
>
> drivers/iio/adc/ti-ads1015.c
> drivers/hwmon/ads1015.c
>
> The driver in the iio subsystem provides more flexible support for
> the chip's capabilities. Even if the hwmon driver is removed,
> the iio->hwmon bridge can still be used and would provide the same
> information as before to the user. Existing devicetree entries
> for ads1015 both point to the iio driver. The platform include file
> is only included by the drivers, but not from any platform code.
>
> With that in mind, keeping the hwmon driver around does not really
> add value. I suggest to remove it. Are there any objections or
> concerns ?
It is probably not worth the dance of creating a stub driver
in hwmon to bring up the iio->hwmon bridge but that might be
an option if anyone minds just dropping the ads1015 hwmon driver.
Thanks,
Jonathan
>
> Thanks,
> Guenter
prev parent reply other threads:[~2019-06-08 10:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-08 1:13 Removing ADS1015 driver from hwmon subsystem Guenter Roeck
2019-06-08 10:01 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190608110143.48a221bb@archlinux \
--to=jic23@kernel.org \
--cc=eibach@gdsys.de \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux@roeck-us.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.