From: Jonathan Cameron <jic23@jic23.retrosnub.co.uk>
To: Alexandru Ardelean <alexandru.ardelean@analog.com>
Cc: <linux-iio@vger.kernel.org>
Subject: Re: [PATCH] staging: iio: ad2s1210: Remove platform data NULL check in probe
Date: Sat, 8 Jun 2019 12:58:33 +0100 [thread overview]
Message-ID: <20190608125833.7794417b@archlinux> (raw)
In-Reply-To: <20190606103409.28160-1-alexandru.ardelean@analog.com>
On Thu, 6 Jun 2019 13:34:09 +0300
Alexandru Ardelean <alexandru.ardelean@analog.com> wrote:
> The driver only needs to access GPIOs via GPIOLIB. And SPI can be
> configured via device-tree or ACPI.
>
> The platform data is a remnant from another time, and should not cause the
> driver to error out during probing if it is NULL.
> Also, it's not used.
>
> Signed-off-by: Alexandru Ardelean <alexandru.ardelean@analog.com>
Applied to the togreg branch of iio.git and pushed out as testing for
the autobuilders to do not much with it.
Thanks,
Jonathan
> ---
> drivers/staging/iio/resolver/ad2s1210.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/staging/iio/resolver/ad2s1210.c b/drivers/staging/iio/resolver/ad2s1210.c
> index b6be0bc202f5..0c1bd108c386 100644
> --- a/drivers/staging/iio/resolver/ad2s1210.c
> +++ b/drivers/staging/iio/resolver/ad2s1210.c
> @@ -647,9 +647,6 @@ static int ad2s1210_probe(struct spi_device *spi)
> struct ad2s1210_state *st;
> int ret;
>
> - if (!spi->dev.platform_data)
> - return -EINVAL;
> -
> indio_dev = devm_iio_device_alloc(&spi->dev, sizeof(*st));
> if (!indio_dev)
> return -ENOMEM;
prev parent reply other threads:[~2019-06-08 11:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-06 10:34 [PATCH] staging: iio: ad2s1210: Remove platform data NULL check in probe Alexandru Ardelean
2019-06-08 11:58 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190608125833.7794417b@archlinux \
--to=jic23@jic23.retrosnub.co.uk \
--cc=alexandru.ardelean@analog.com \
--cc=linux-iio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.