All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@jic23.retrosnub.co.uk>
To: Alexandru Ardelean <alexandru.ardelean@analog.com>
Cc: <linux-iio@vger.kernel.org>
Subject: Re: [PATCH] iio: ad_sigma_delta: return directly in ad_sd_buffer_postenable()
Date: Sat, 8 Jun 2019 15:10:53 +0100	[thread overview]
Message-ID: <20190608151053.7d09c1b3@archlinux> (raw)
In-Reply-To: <20190530072541.22268-1-alexandru.ardelean@analog.com>

On Thu, 30 May 2019 10:25:41 +0300
Alexandru Ardelean <alexandru.ardelean@analog.com> wrote:

> There is nothing being done after the `err_predisable` label, so just
> remove it.
> 
> Signed-off-by: Alexandru Ardelean <alexandru.ardelean@analog.com>
applied.

Thanks,

Jonathan

> ---
>  drivers/iio/adc/ad_sigma_delta.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/iio/adc/ad_sigma_delta.c b/drivers/iio/adc/ad_sigma_delta.c
> index a4310600a853..ec0e38566ece 100644
> --- a/drivers/iio/adc/ad_sigma_delta.c
> +++ b/drivers/iio/adc/ad_sigma_delta.c
> @@ -358,7 +358,7 @@ static int ad_sd_buffer_postenable(struct iio_dev *indio_dev)
>  	ret = ad_sigma_delta_set_channel(sigma_delta,
>  		indio_dev->channels[channel].address);
>  	if (ret)
> -		goto err_predisable;
> +		return ret;
>  
>  	spi_bus_lock(sigma_delta->spi->master);
>  	sigma_delta->bus_locked = true;
> @@ -375,7 +375,6 @@ static int ad_sd_buffer_postenable(struct iio_dev *indio_dev)
>  
>  err_unlock:
>  	spi_bus_unlock(sigma_delta->spi->master);
> -err_predisable:
>  
>  	return ret;
>  }


      reply	other threads:[~2019-06-08 14:10 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-30  7:25 [PATCH] iio: ad_sigma_delta: return directly in ad_sd_buffer_postenable() Alexandru Ardelean
2019-06-08 14:10 ` Jonathan Cameron [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190608151053.7d09c1b3@archlinux \
    --to=jic23@jic23.retrosnub.co.uk \
    --cc=alexandru.ardelean@analog.com \
    --cc=linux-iio@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.