From: Andrew Lunn <andrew@lunn.ch>
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: Jose Abreu <Jose.Abreu@synopsys.com>,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
Joao Pinto <Joao.Pinto@synopsys.com>,
"David S . Miller" <davem@davemloft.net>,
Giuseppe Cavallaro <peppe.cavallaro@st.com>,
Alexandre Torgue <alexandre.torgue@st.com>,
Russell King <linux@armlinux.org.uk>,
Heiner Kallweit <hkallweit1@gmail.com>
Subject: Re: [RFC net-next 2/2] net: stmmac: Convert to phylink
Date: Sat, 8 Jun 2019 20:46:01 +0200 [thread overview]
Message-ID: <20190608184601.GA22700@lunn.ch> (raw)
In-Reply-To: <34db7462-4f5a-155a-d230-e4c90cee1ce3@gmail.com>
> I am not exactly sure removing this is strictly equivalent here, but the
> diff makes it hard to review.
Yes, diff is doing a poor job here. I already asked Jose if a better
diff could be produced by passing extra options.
> - add support for PHYLINK (parts of this patch) but without plugging it
> into the probe/connect path just yet
I don't think this is going to make the diff any better.
I might actually just apply the patches and look at the resulting
files.
Andrew
prev parent reply other threads:[~2019-06-08 18:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-05 13:30 [RFC net-next 0/2] net: stmmac: Convert to phylink Jose Abreu
2019-06-06 11:26 ` Jose Abreu
2019-06-05 13:30 ` [RFC net-next 1/2] net: stmmac: Prepare to convert " Jose Abreu
2019-06-06 11:26 ` Jose Abreu
2019-06-05 13:30 ` [RFC net-next 2/2] net: stmmac: Convert " Jose Abreu
2019-06-06 11:26 ` Jose Abreu
2019-06-08 3:58 ` Florian Fainelli
2019-06-08 18:46 ` Andrew Lunn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190608184601.GA22700@lunn.ch \
--to=andrew@lunn.ch \
--cc=Joao.Pinto@synopsys.com \
--cc=Jose.Abreu@synopsys.com \
--cc=alexandre.torgue@st.com \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.