From: David Ahern <dsahern@kernel.org>
To: davem@davemloft.net, netdev@vger.kernel.org
Cc: idosch@mellanox.com, kafai@fb.com, weiwan@google.com,
sbrivio@redhat.com, David Ahern <dsahern@gmail.com>
Subject: [PATCH v4 net-next 02/20] ipv6: Handle all fib6_nh in a nexthop in fib6_drop_pcpu_from
Date: Sat, 8 Jun 2019 14:53:23 -0700 [thread overview]
Message-ID: <20190608215341.26592-3-dsahern@kernel.org> (raw)
In-Reply-To: <20190608215341.26592-1-dsahern@kernel.org>
From: David Ahern <dsahern@gmail.com>
Use nexthop_for_each_fib6_nh to walk all fib6_nh in a nexthop when
dropping 'from' reference in pcpu routes.
Signed-off-by: David Ahern <dsahern@gmail.com>
---
net/ipv6/ip6_fib.c | 31 +++++++++++++++++++++++++++----
1 file changed, 27 insertions(+), 4 deletions(-)
diff --git a/net/ipv6/ip6_fib.c b/net/ipv6/ip6_fib.c
index 17dcc916eb63..1cce2082279c 100644
--- a/net/ipv6/ip6_fib.c
+++ b/net/ipv6/ip6_fib.c
@@ -906,19 +906,42 @@ static void __fib6_drop_pcpu_from(struct fib6_nh *fib6_nh,
}
}
+struct fib6_nh_pcpu_arg {
+ struct fib6_info *from;
+ const struct fib6_table *table;
+};
+
+static int fib6_nh_drop_pcpu_from(struct fib6_nh *nh, void *_arg)
+{
+ struct fib6_nh_pcpu_arg *arg = _arg;
+
+ __fib6_drop_pcpu_from(nh, arg->from, arg->table);
+ return 0;
+}
+
static void fib6_drop_pcpu_from(struct fib6_info *f6i,
const struct fib6_table *table)
{
- struct fib6_nh *fib6_nh;
-
/* Make sure rt6_make_pcpu_route() wont add other percpu routes
* while we are cleaning them here.
*/
f6i->fib6_destroying = 1;
mb(); /* paired with the cmpxchg() in rt6_make_pcpu_route() */
- fib6_nh = f6i->fib6_nh;
- __fib6_drop_pcpu_from(fib6_nh, f6i, table);
+ if (f6i->nh) {
+ struct fib6_nh_pcpu_arg arg = {
+ .from = f6i,
+ .table = table
+ };
+
+ nexthop_for_each_fib6_nh(f6i->nh, fib6_nh_drop_pcpu_from,
+ &arg);
+ } else {
+ struct fib6_nh *fib6_nh;
+
+ fib6_nh = f6i->fib6_nh;
+ __fib6_drop_pcpu_from(fib6_nh, f6i, table);
+ }
}
static void fib6_purge_rt(struct fib6_info *rt, struct fib6_node *fn,
--
2.11.0
next prev parent reply other threads:[~2019-06-08 22:22 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-08 21:53 [PATCH v4 net-next 00/20] net: Enable nexthop objects with IPv4 and IPv6 routes David Ahern
2019-06-08 21:53 ` [PATCH v4 net-next 01/20] nexthops: Add ipv6 helper to walk all fib6_nh in a nexthop struct David Ahern
2019-06-08 21:53 ` David Ahern [this message]
2019-06-08 21:53 ` [PATCH v4 net-next 03/20] ipv6: Handle all fib6_nh in a nexthop in rt6_device_match David Ahern
2019-06-08 21:53 ` [PATCH v4 net-next 04/20] ipv6: Handle all fib6_nh in a nexthop in __find_rr_leaf David Ahern
2019-06-08 21:53 ` [PATCH v4 net-next 05/20] ipv6: Handle all fib6_nh in a nexthop in rt6_nlmsg_size David Ahern
2019-06-08 21:53 ` [PATCH v4 net-next 06/20] ipv6: Handle all fib6_nh in a nexthop in fib6_info_uses_dev David Ahern
2019-06-08 21:53 ` [PATCH v4 net-next 07/20] ipv6: Handle all fib6_nh in a nexthop in exception handling David Ahern
2019-06-08 21:53 ` [PATCH v4 net-next 08/20] ipv6: Handle all fib6_nh in a nexthop in __ip6_route_redirect David Ahern
2019-06-08 21:53 ` [PATCH v4 net-next 09/20] ipv6: Handle all fib6_nh in a nexthop in rt6_do_redirect David Ahern
2019-06-08 21:53 ` [PATCH v4 net-next 10/20] ipv6: Handle all fib6_nh in a nexthop in mtu updates David Ahern
2019-06-08 21:53 ` [PATCH v4 net-next 11/20] ipv4: Allow routes to use nexthop objects David Ahern
2019-06-08 21:53 ` [PATCH v4 net-next 12/20] ipv4: Optimization for fib_info lookup with nexthops David Ahern
2019-06-08 21:53 ` [PATCH v4 net-next 13/20] ipv6: Allow routes to use nexthop objects David Ahern
2019-06-08 21:53 ` [PATCH v4 net-next 14/20] nexthops: add support for replace David Ahern
2019-06-08 21:53 ` [PATCH v4 net-next 15/20] selftests: pmtu: Move running of test into a new function David Ahern
2019-06-08 21:53 ` [PATCH v4 net-next 16/20] selftests: pmtu: Move route installs to " David Ahern
2019-06-08 21:53 ` [PATCH v4 net-next 17/20] selftests: pmtu: Add support for routing via nexthop objects David Ahern
2019-06-08 21:53 ` [PATCH v4 net-next 18/20] selftests: icmp_redirect: " David Ahern
2019-06-08 21:53 ` [PATCH v4 net-next 19/20] selftests: Add test with multiple prefixes using single nexthop David Ahern
2019-06-08 21:53 ` [PATCH v4 net-next 20/20] selftests: Add version of router_multipath.sh using nexthop objects David Ahern
2019-06-10 5:11 ` [PATCH v4 net-next 00/20] net: Enable nexthop objects with IPv4 and IPv6 routes Wei Wang
2019-06-10 18:06 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190608215341.26592-3-dsahern@kernel.org \
--to=dsahern@kernel.org \
--cc=davem@davemloft.net \
--cc=dsahern@gmail.com \
--cc=idosch@mellanox.com \
--cc=kafai@fb.com \
--cc=netdev@vger.kernel.org \
--cc=sbrivio@redhat.com \
--cc=weiwan@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.