From: "Michael Büsch" <m@bues.ch>
To: H Buus <ubuntu@hbuus.com>
Cc: Kalle Valo <kvalo@codeaurora.org>,
Michael Chan <michael.chan@broadcom.com>,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: Should b44_init lead to WARN_ON in drivers/ssb/driver_gpio.c:464?
Date: Sun, 9 Jun 2019 23:57:11 +0200 [thread overview]
Message-ID: <20190609235711.481bbac9@wiggum> (raw)
In-Reply-To: <946c86bf-7e90-a981-b9fc-757adb98adfa@hbuus.com>
[-- Attachment #1: Type: text/plain, Size: 752 bytes --]
On Sun, 9 Jun 2019 17:44:10 -0400
H Buus <ubuntu@hbuus.com> wrote:
> I have an old 32 bit laptop with a BCM4401-B0 100Base-TX ethernet
> controller. For every kernel from 4.19-rc1 going forward, I get a
> warning and call trace within a few seconds of start up (see dmesg
> snippet below). I have traced it to a specific commit (see commit
> below). On the face of it, I would think it is a regression, but it
> doesn't seem to cause a problem, since networking over ethernet is working.
This warning is not a problem. The commit just exposes a warning, that
has always been there.
I suggest we just remove the WARN_ON from ssb_gpio_init and
ssb_gpio_unregister.
I don't see a reason to throw a warning in that case.
--
Michael
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2019-06-09 22:31 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-09 21:44 Should b44_init lead to WARN_ON in drivers/ssb/driver_gpio.c:464? H Buus
2019-06-09 21:57 ` Michael Büsch [this message]
2019-06-10 0:13 ` Larry Finger
2019-06-10 5:40 ` H Buus
2019-06-10 6:51 ` Michael Büsch
2019-06-10 18:49 ` [PATCH] ssb/gpio: Remove unnecessary WARN_ON from driver_gpio Michael Büsch
2019-06-10 19:16 ` Larry Finger
2019-06-11 4:56 ` H Buus
2019-06-25 5:07 ` Kalle Valo
2019-06-25 12:10 ` Jonas Gorski
2019-06-25 12:24 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190609235711.481bbac9@wiggum \
--to=m@bues.ch \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
--cc=michael.chan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=ubuntu@hbuus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.