All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: "Simon Sandström" <simon@nikanor.nu>
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/7] staging: kpc2000: use __func__ in debug messages in core.c
Date: Mon, 10 Jun 2019 09:49:40 +0200	[thread overview]
Message-ID: <20190610074940.GC24746@kroah.com> (raw)
In-Reply-To: <20190610072009.w5scsjb2aqcxm2l2@dev.nikanor.nu>

On Mon, Jun 10, 2019 at 09:20:09AM +0200, Simon Sandström wrote:
> On 06/06, Greg KH wrote:
> > On Tue, Jun 04, 2019 at 12:29:13AM +0200, Simon Sandström wrote:
> > >  
> > > -	dev_dbg(&pdev->dev, "kp2000_pcie_probe(pdev = [%p], id = [%p])\n",
> > > -		pdev, id);
> > > +	dev_dbg(&pdev->dev, "%s(pdev = [%p], id = [%p])\n",
> > > +		__func__, pdev, id);
> > 
> > debugging lines that say "called this function!" can all be removed, as
> > we have ftrace in the kernel tree, we can use that instead.  I'll take
> > this, but feel free to clean them up as follow-on patches.
> > 
> > thanks,
> > 
> > greg k-h
> 
> Can they be removed even if they print function arguments or other
> variables?

Of course!

  reply	other threads:[~2019-06-10  7:49 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-03 22:29 [PATCH 0/7] staging: kpc2000: various minor checkpatch fixes Simon Sandström
2019-06-03 22:29 ` [PATCH 1/7] staging: kpc2000: simplify comparisons to NULL in core.c Simon Sandström
2019-06-03 22:29 ` [PATCH 2/7] staging: kpc2000: remove unnecessary parentheses " Simon Sandström
2019-06-03 22:29 ` [PATCH 3/7] staging: kpc2000: remove unnecessary oom message " Simon Sandström
2019-06-03 22:29 ` [PATCH 4/7] staging: kpc2000: use __func__ in debug messages " Simon Sandström
2019-06-06 12:55   ` Greg KH
2019-06-10  7:20     ` Simon Sandström
2019-06-10  7:49       ` Greg KH [this message]
2019-06-03 22:29 ` [PATCH 5/7] staging: kpc2000: remove unnecessary include " Simon Sandström
2019-06-03 22:29 ` [PATCH 6/7] staging: kpc2000: use sizeof(var) in kzalloc call Simon Sandström
2019-06-03 22:29 ` [PATCH 7/7] staging: kpc2000: fix incorrect code comment in core.c Simon Sandström
2019-06-06 11:34   ` Dan Carpenter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190610074940.GC24746@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=devel@driverdev.osuosl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=simon@nikanor.nu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.