From: Andrew Lunn <andrew@lunn.ch>
To: David Miller <davem@davemloft.net>
Cc: sameehj@amazon.com, netdev@vger.kernel.org, dwmw@amazon.com,
zorik@amazon.com, matua@amazon.com, saeedb@amazon.com,
msw@amazon.com, aliguori@amazon.com, nafea@amazon.com,
gtzalik@amazon.com, netanel@amazon.com, alisaidi@amazon.com,
benh@amazon.com, akiyano@amazon.com
Subject: Re: [PATCH V2 net-next 4/6] net: ena: allow queue allocation backoff when low on memory
Date: Mon, 10 Jun 2019 18:36:59 +0200 [thread overview]
Message-ID: <20190610163659.GL28724@lunn.ch> (raw)
In-Reply-To: <20190610.091840.690511717716268814.davem@davemloft.net>
On Mon, Jun 10, 2019 at 09:18:40AM -0700, David Miller wrote:
> From: <sameehj@amazon.com>
> Date: Mon, 10 Jun 2019 14:19:16 +0300
>
> > +static inline void set_io_rings_size(struct ena_adapter *adapter,
> > + int new_tx_size, int new_rx_size)
>
> Please do not ever use inline in foo.c files, let the compiler decide.
Hi David
It looks like a few got passed review:
~/linux/drivers/net/ethernet/amazon/ena$ grep inline *.c
ena_com.c:static inline int ena_com_mem_addr_set(struct ena_com_dev *ena_dev,
ena_com.c:static inline void comp_ctxt_release(struct ena_com_admin_queue *queue,
ena_com.c:static inline int ena_com_init_comp_ctxt(struct ena_com_admin_queue *queue)
ena_eth_com.c:static inline struct ena_eth_io_rx_cdesc_base *ena_com_get_next_rx_cdesc(
ena_eth_com.c:static inline void *get_sq_desc_regular_queue(struct ena_com_io_sq *io_sq)
ena_eth_com.c:static inline int ena_com_write_bounce_buffer_to_dev(struct ena_com_io_sq *io_sq,
ena_eth_com.c:static inline int ena_com_write_header_to_bounce(struct ena_com_io_sq *io_sq,
ena_eth_com.c:static inline void *get_sq_desc_llq(struct ena_com_io_sq *io_sq)
ena_eth_com.c:static inline int ena_com_close_bounce_buffer(struct ena_com_io_sq *io_sq)
ena_eth_com.c:static inline void *get_sq_desc(struct ena_com_io_sq *io_sq)
ena_eth_com.c:static inline int ena_com_sq_update_llq_tail(struct ena_com_io_sq *io_sq)
ena_eth_com.c:static inline int ena_com_sq_update_tail(struct ena_com_io_sq *io_sq)
ena_eth_com.c:static inline struct ena_eth_io_rx_cdesc_base *
ena_eth_com.c:static inline u16 ena_com_cdesc_rx_pkt_get(struct ena_com_io_cq *io_cq,
ena_eth_com.c:static inline int ena_com_create_and_store_tx_meta_desc(struct ena_com_io_sq *io_sq,
ena_eth_com.c:static inline void ena_com_rx_set_flags(struct ena_com_rx_ctx *ena_rx_ctx,
ena_netdev.c:static inline int validate_rx_req_id(struct ena_ring *rx_ring, u16 req_id)
ena_netdev.c:static inline int ena_alloc_rx_page(struct ena_ring *rx_ring,
ena_netdev.c:static inline void ena_unmap_tx_skb(struct ena_ring *tx_ring,
ena_netdev.c:static inline void ena_rx_checksum(struct ena_ring *rx_ring,
ena_netdev.c:inline void ena_adjust_intr_moderation(struct ena_ring *rx_ring,
ena_netdev.c:static inline void ena_unmask_interrupt(struct ena_ring *tx_ring,
ena_netdev.c:static inline void ena_update_ring_numa_node(struct ena_ring *tx_ring,
ena_netdev.c:static inline void set_default_llq_configurations(struct ena_llq_configurations *llq_config)
Andrew
next prev parent reply other threads:[~2019-06-10 16:37 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-10 11:19 [PATCH V2 net-next 0/6] Support for dynamic queue size changes sameehj
2019-06-10 11:19 ` [PATCH V2 net-next 1/6] net: ena: add MAX_QUEUES_EXT get feature admin command sameehj
2019-06-10 11:19 ` [PATCH V2 net-next 2/6] net: ena: enable negotiating larger Rx ring size sameehj
2019-06-10 11:19 ` [PATCH V2 net-next 3/6] net: ena: make ethtool show correct current and max queue sizes sameehj
2019-06-10 11:19 ` [PATCH V2 net-next 4/6] net: ena: allow queue allocation backoff when low on memory sameehj
2019-06-10 16:18 ` David Miller
2019-06-10 16:36 ` Andrew Lunn [this message]
2019-06-10 16:38 ` David Miller
2019-06-10 17:10 ` Bshara, Nafea
2019-06-10 11:19 ` [PATCH V2 net-next 5/6] net: ena: add ethtool function for changing io queue sizes sameehj
2019-06-10 11:19 ` [PATCH V2 net-next 6/6] net: ena: update driver version from 2.0.3 to 2.1.0 sameehj
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190610163659.GL28724@lunn.ch \
--to=andrew@lunn.ch \
--cc=akiyano@amazon.com \
--cc=aliguori@amazon.com \
--cc=alisaidi@amazon.com \
--cc=benh@amazon.com \
--cc=davem@davemloft.net \
--cc=dwmw@amazon.com \
--cc=gtzalik@amazon.com \
--cc=matua@amazon.com \
--cc=msw@amazon.com \
--cc=nafea@amazon.com \
--cc=netanel@amazon.com \
--cc=netdev@vger.kernel.org \
--cc=saeedb@amazon.com \
--cc=sameehj@amazon.com \
--cc=zorik@amazon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.