From: Eric Biggers <ebiggers@kernel.org>
To: Mimi Zohar <zohar@linux.ibm.com>
Cc: syzbot <syzbot+e1374b2ec8f6a25ab2e5@syzkaller.appspotmail.com>,
akpm@linux-foundation.org, aneesh.kumar@linux.ibm.com,
dan.j.williams@intel.com, ira.weiny@intel.com, jack@suse.cz,
jhubbard@nvidia.com, jmorris@namei.org, keith.busch@intel.com,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
linux-security-module@vger.kernel.org, richard.weiyang@gmail.com,
rppt@linux.ibm.com, serge@hallyn.com, sfr@canb.auug.org.au,
syzkaller-bugs@googlegroups.com, willy@infradead.org
Subject: [IMA] Re: possible deadlock in get_user_pages_unlocked (2)
Date: Mon, 10 Jun 2019 12:06:23 -0700 [thread overview]
Message-ID: <20190610190622.GI63833@gmail.com> (raw)
In-Reply-To: <0000000000001d42b5058a895703@google.com>
On Tue, Jun 04, 2019 at 06:16:00PM -0700, syzbot wrote:
> syzbot has bisected this bug to:
>
> commit 69d61f577d147b396be0991b2ac6f65057f7d445
> Author: Mimi Zohar <zohar@linux.ibm.com>
> Date: Wed Apr 3 21:47:46 2019 +0000
>
> ima: verify mprotect change is consistent with mmap policy
>
> bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=1055a2f2a00000
> start commit: 56b697c6 Add linux-next specific files for 20190604
> git tree: linux-next
> final crash: https://syzkaller.appspot.com/x/report.txt?x=1255a2f2a00000
> console output: https://syzkaller.appspot.com/x/log.txt?x=1455a2f2a00000
> kernel config: https://syzkaller.appspot.com/x/.config?x=4248d6bc70076f7d
> dashboard link: https://syzkaller.appspot.com/bug?extid=e1374b2ec8f6a25ab2e5
> syz repro: https://syzkaller.appspot.com/x/repro.syz?x=165757eea00000
> C reproducer: https://syzkaller.appspot.com/x/repro.c?x=10dd3e86a00000
>
> Reported-by: syzbot+e1374b2ec8f6a25ab2e5@syzkaller.appspotmail.com
> Fixes: 69d61f577d14 ("ima: verify mprotect change is consistent with mmap
> policy")
>
> For information about bisection process see: https://goo.gl/tpsmEJ#bisection
>
Hi Mimi, it seems your change to call ima_file_mmap() from
security_file_mprotect() violates the locking order by taking i_rwsem while
mmap_sem is held.
- Eric
next prev parent reply other threads:[~2019-06-10 19:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-01 6:08 possible deadlock in get_user_pages_unlocked (2) syzbot
2019-06-04 21:19 ` syzbot
2019-06-05 1:16 ` syzbot
2019-06-10 19:06 ` Eric Biggers [this message]
2019-06-23 22:16 ` [IMA] " Eric Biggers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190610190622.GI63833@gmail.com \
--to=ebiggers@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=aneesh.kumar@linux.ibm.com \
--cc=dan.j.williams@intel.com \
--cc=ira.weiny@intel.com \
--cc=jack@suse.cz \
--cc=jhubbard@nvidia.com \
--cc=jmorris@namei.org \
--cc=keith.busch@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-security-module@vger.kernel.org \
--cc=richard.weiyang@gmail.com \
--cc=rppt@linux.ibm.com \
--cc=serge@hallyn.com \
--cc=sfr@canb.auug.org.au \
--cc=syzbot+e1374b2ec8f6a25ab2e5@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
--cc=willy@infradead.org \
--cc=zohar@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.