From: Andrew Lunn <andrew@lunn.ch>
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: netdev@vger.kernel.org, ioana.ciornei@nxp.com, olteanv@gmail.com,
rmk+kernel@armlinux.org.uk,
Vivien Didelot <vivien.didelot@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net-next] net: dsa: Deal with non-existing PHY/fixed-link
Date: Mon, 10 Jun 2019 23:15:34 +0200 [thread overview]
Message-ID: <20190610211534.GD2191@lunn.ch> (raw)
In-Reply-To: <20190610193150.22231-1-f.fainelli@gmail.com>
On Mon, Jun 10, 2019 at 12:31:49PM -0700, Florian Fainelli wrote:
> We need to specifically deal with phylink_of_phy_connect() returning
> -ENODEV, because this can happen when a CPU/DSA port does connect
> neither to a PHY, nor has a fixed-link property. This is a valid use
> case that is permitted by the binding and indicates to the switch:
> auto-configure port with maximum capabilities.
>
> Fixes: 0e27921816ad ("net: dsa: Use PHYLINK for the CPU/DSA ports")
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Hi Florian
This fixes the regression.
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
But i wonder if we want to add in
(dsa_is_cpu_port(ds, port) || dsa_is_dsa_port(ds, port) i.e. force a
user port to have some form of PHY?
Andrew
next prev parent reply other threads:[~2019-06-10 21:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-10 19:31 [PATCH net-next] net: dsa: Deal with non-existing PHY/fixed-link Florian Fainelli
2019-06-10 19:53 ` Vladimir Oltean
2019-06-10 20:49 ` Ioana Ciornei
2019-06-10 21:11 ` Andrew Lunn
2019-06-10 21:15 ` Andrew Lunn [this message]
2019-06-12 18:01 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190610211534.GD2191@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=ioana.ciornei@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=rmk+kernel@armlinux.org.uk \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.