From: Stephen Hemminger <stephen@networkplumber.org>
To: "Sanford, Robert" <rsanford@akamai.com>
Cc: "erik.g.carrillo@intel.com" <erik.g.carrillo@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [RFC] rte_timer: add rte_timer_next_ticks
Date: Tue, 11 Jun 2019 07:27:26 -0700 [thread overview]
Message-ID: <20190611072726.0350a663@hermes.lan> (raw)
In-Reply-To: <83AA51E6-C1D2-4E09-B240-88326ECFD853@akamai.com>
On Tue, 11 Jun 2019 13:37:33 +0000
"Sanford, Robert" <rsanford@akamai.com> wrote:
> Hi Stephen,
>
> The code seems fine. My only comment is that there is not a blank line before the new code, in both the .c and .h.
>
> --
> Regards
Where, I see the blank line between functions and checkpatch is happy.
next prev parent reply other threads:[~2019-06-11 14:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-10 22:44 [dpdk-dev] [RFC] rte_timer: add rte_timer_next_ticks Stephen Hemminger
2019-06-11 13:37 ` Sanford, Robert
2019-06-11 14:27 ` Stephen Hemminger [this message]
2019-06-11 14:45 ` Sanford, Robert
2019-06-12 18:19 ` Carrillo, Erik G
2019-12-17 0:55 ` [dpdk-dev] [PATCH v1] " Stephen Hemminger
2019-12-20 22:43 ` Carrillo, Erik G
2020-01-20 0:38 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190611072726.0350a663@hermes.lan \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=erik.g.carrillo@intel.com \
--cc=rsanford@akamai.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.