All of lore.kernel.org
 help / color / mirror / Atom feed
From: "SZEDER Gábor" <szeder.dev@gmail.com>
To: Christian Couder <christian.couder@gmail.com>
Cc: git@vger.kernel.org, "Junio C Hamano" <gitster@pobox.com>,
	"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
	"Jonathan Tan" <jonathantanmy@google.com>,
	"Christian Couder" <chriscool@tuxfamily.org>
Subject: Re: [PATCH v2 2/3] t: add t0016-oidmap.sh
Date: Tue, 11 Jun 2019 12:12:50 +0200	[thread overview]
Message-ID: <20190611101250.GE4012@szeder.dev> (raw)
In-Reply-To: <20190611082325.28878-3-chriscool@tuxfamily.org>

On Tue, Jun 11, 2019 at 10:23:24AM +0200, Christian Couder wrote:
> diff --git a/t/t0016-oidmap.sh b/t/t0016-oidmap.sh
> new file mode 100755
> index 0000000000..cbd2cb71d6
> --- /dev/null
> +++ b/t/t0016-oidmap.sh
> @@ -0,0 +1,100 @@
> +#!/bin/sh
> +
> +test_description='test oidmap'
> +. ./test-lib.sh
> +
> +# This purposefully is very similar to t0011-hashmap.sh
> +
> +test_oidmap() {
> +	echo "$1" | test-tool oidmap $3 > actual &&

Style nit: space between redirection op and filename ;)


  reply	other threads:[~2019-06-11 10:12 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-11  8:23 [PATCH v2 0/3] Test oidmap Christian Couder
2019-06-11  8:23 ` [PATCH v2 1/3] t/helper: add test-oidmap.c Christian Couder
2019-06-11  8:23 ` [PATCH v2 2/3] t: add t0016-oidmap.sh Christian Couder
2019-06-11 10:12   ` SZEDER Gábor [this message]
2019-06-12 17:09     ` Christian Couder
2019-06-11  8:23 ` [PATCH v2 3/3] oidmap: use sha1hash() instead of static hash() function Christian Couder
2019-06-11 10:12 ` [PATCH v2 0/3] Test oidmap SZEDER Gábor

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190611101250.GE4012@szeder.dev \
    --to=szeder.dev@gmail.com \
    --cc=avarab@gmail.com \
    --cc=chriscool@tuxfamily.org \
    --cc=christian.couder@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=jonathantanmy@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.