Re: [PATCH] riscv: export flush_icache_all

[Christoph Hellwig <hch@lst.de>]

NAK.  There is no point to export a symbol that should not generally
exported just for a tester.

I think the right answer is to just don't allow a modular build of
lkdtm.

On Tue, Jun 11, 2019 at 12:24:32PM +0200, Andreas Schwab wrote:
> Before 58de77545e53 ("riscv: move flush_icache_{all,mm} to cacheflush.c"),
> flush_icache_all was a macro, but it is used by a module:
> 
>   ERROR: "flush_icache_all" [drivers/misc/lkdtm/lkdtm.ko] undefined!
> 
> Signed-off-by: Andreas Schwab <schwab@suse.de>
> ---
>  arch/riscv/mm/cacheflush.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/riscv/mm/cacheflush.c b/arch/riscv/mm/cacheflush.c
> index 9ebcff8ba263..4a2e5bf8b21a 100644
> --- a/arch/riscv/mm/cacheflush.c
> +++ b/arch/riscv/mm/cacheflush.c
> @@ -14,6 +14,7 @@ void flush_icache_all(void)
>  {
>  	sbi_remote_fence_i(NULL);
>  }
> +EXPORT_SYMBOL(flush_icache_all);
>  
>  /*
>   * Performs an icache flush for the given MM context.  RISC-V has no direct
> -- 
> 2.22.0
---end quoted text---

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv