All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2/2] package/gerbera: add upstream patch to fix find_program with taglib-config
Date: Tue, 11 Jun 2019 17:08:04 +0200	[thread overview]
Message-ID: <20190611170804.0e17d415@windsurf> (raw)
In-Reply-To: <e198cc50-3e78-b2df-ccc1-269af7fad363@mind.be>

On Tue, 11 Jun 2019 00:33:31 +0200
Arnout Vandecappelle <arnout@mind.be> wrote:

> > ++            if (CMAKE_CROSSCOMPILING)
> > ++              set(CMAKE_FIND_ROOT_PATH_MODE_PROGRAM ONLY)  
> 
>  Again, this is wrong IMO. The executables in the sysroot are not supposed to be
> executed on the host.
> 
>  What we really should do is to copy those config scripts to some other
> location, and add that to the PATH.

Not so simple: what do you do to differentiate between foo-config
describing foo for the host and foo-config describing foo for the
target ?

Yes, you could install the foo-config in a different directory than
$(HOST_DIR)/bin, but what if some package needs both foo-config for the
host and foo-config for the target, when building its code for the
target ?

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

  reply	other threads:[~2019-06-11 15:08 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-10 21:20 [Buildroot] [PATCH 0/2] Fix linking gerbera with taglib Jörg Krause
2019-06-10 21:20 ` [Buildroot] [PATCH 1/2] package/taglib: add upstream patch to fix taglib-config Jörg Krause
2019-06-10 22:25   ` Arnout Vandecappelle
2019-06-16 13:24     ` Jörg Krause
2019-06-18  9:31       ` Arnout Vandecappelle
2019-06-23 21:00   ` Peter Korsgaard
2019-06-10 21:20 ` [Buildroot] [PATCH 2/2] package/gerbera: add upstream patch to fix find_program with taglib-config Jörg Krause
2019-06-10 22:33   ` Arnout Vandecappelle
2019-06-11 15:08     ` Thomas Petazzoni [this message]
2019-06-23 20:56   ` Peter Korsgaard
2019-06-10 22:20 ` [Buildroot] [PATCH 0/2] Fix linking gerbera with taglib Arnout Vandecappelle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190611170804.0e17d415@windsurf \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.