From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 36A5DC4321A for ; Tue, 11 Jun 2019 17:18:58 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0DC592086D for ; Tue, 11 Jun 2019 17:18:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0DC592086D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:33188 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hakQC-0001Yc-Se for qemu-devel@archiver.kernel.org; Tue, 11 Jun 2019 13:18:56 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:57651) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hakKg-0007bV-Ez for qemu-devel@nongnu.org; Tue, 11 Jun 2019 13:13:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hakKe-0002go-FU for qemu-devel@nongnu.org; Tue, 11 Jun 2019 13:13:14 -0400 Received: from mx1.redhat.com ([209.132.183.28]:60530) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hakKe-0002gA-9k for qemu-devel@nongnu.org; Tue, 11 Jun 2019 13:13:12 -0400 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id BCEC4309266E; Tue, 11 Jun 2019 17:12:59 +0000 (UTC) Received: from localhost (ovpn-116-9.gru2.redhat.com [10.97.116.9]) by smtp.corp.redhat.com (Postfix) with ESMTP id F0B8119C70; Tue, 11 Jun 2019 17:12:58 +0000 (UTC) Date: Tue, 11 Jun 2019 14:12:57 -0300 From: Eduardo Habkost To: Peter Maydell Message-ID: <20190611171257.GI5927@habkost.net> References: <20190607211544.7964-1-ehabkost@redhat.com> <20190611160329.GH5927@habkost.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.43]); Tue, 11 Jun 2019 17:12:59 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: Re: [Qemu-devel] [PULL 0/8] Python queue, 2019-06-07 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: QEMU Developers , Cleber Rosa Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Tue, Jun 11, 2019 at 05:07:55PM +0100, Peter Maydell wrote: > On Tue, 11 Jun 2019 at 17:03, Eduardo Habkost wrote: > > > > On Tue, Jun 11, 2019 at 04:50:34PM +0100, Peter Maydell wrote: > > > On Mon, 10 Jun 2019 at 13:58, Peter Maydell wrote: > > > > Hi. This fails to build on one of my buildtest machines: > > > > > > > > ERROR: Cannot use 'python3', Python 2 >= 2.7 or Python 3 >= 3.5 is required. > > > > Use --python=/path/to/python to specify a supported Python. > > > > > > > > The machine has python 2.7.6 and 3.4.3. (It's an Ubuntu trusty > > > > box; it's one of the gcc compile farm machines so upgrades to its > > > > OS are not really under my control.) > > > > > > Rereading this, I realise that either the check or the error > > > message is wrong here. The machine has 2.7.6, which satisfies > > > "python 2 >= 2.7", so we should be OK to build. The bug > > > seems to be that we say "prefer python3 over plain python > > > on python2" early, but don't revisit that decision if the > > > python3 we found isn't actually good enough for us. > > > > Right. The error message is technically correct, but misleading. > > python3 is too old, but python2 would work. > > > > We can make configure not use python3 by default if it's too old, > > and fall back to python2 in this case. > > Sounds good. Since I have now managed to get my alternate > aarch64 box set up, how about I apply this pullreq and you > send a followup patch which does the fallback to python/python2 ? I will remove the python2/python3 patches and send a new pull request. -- Eduardo