From: Nathan Chancellor <natechancellor@gmail.com>
To: Nathan Huckleberry <nhuck@google.com>
Cc: agross@kernel.org, david.brown@linaro.org,
mturquette@baylibre.com, sboyd@kernel.org,
linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
linux-kernel@vger.kernel.org, clang-built-linux@googlegroups.com
Subject: Re: [PATCH] clk: qcom: Fix -Wunused-const-variable
Date: Tue, 11 Jun 2019 14:22:11 -0700 [thread overview]
Message-ID: <20190611212211.GA6815@archlinux-epyc> (raw)
In-Reply-To: <20190611211134.96159-1-nhuck@google.com>
On Tue, Jun 11, 2019 at 02:11:34PM -0700, Nathan Huckleberry wrote:
> Clang produces the following warning
>
> drivers/clk/qcom/gcc-msm8996.c:133:32: warning: unused variable
> 'gcc_xo_gpll0_gpll2_gpll3_gpll0_early_div_map' [-Wunused-const-variable]
> static const struct
> parent_map gcc_xo_gpll0_gpll2_gpll3_gpll0_early_div_map[] =
> { ^drivers/clk/qcom/gcc-msm8996.c:141:27: warning: unused variable
> 'gcc_xo_gpll0_gpll2_gpll3_gpll0_early_div' [-Wunused-const-variable] static
> const char * const gcc_xo_gpll0_gpll2_gpll3_gpll0_early_div[] = { ^
> drivers/clk/qcom/gcc-msm8996.c:187:32: warning: unused variable
> 'gcc_xo_gpll0_gpll2_gpll3_gpll1_gpll4_gpll0_early_div_map'
> [-Wunused-const-variable] static const struct parent_map
> gcc_xo_gpll0_gpll2_gpll3_gpll1_gpll4_gpll0_early_div_map[] = { ^
> drivers/clk/qcom/gcc-msm8996.c:197:27: warning: unused variable
> 'gcc_xo_gpll0_gpll2_gpll3_gpll1_gpll4_gpll0_early_div'
> [-Wunused-const-variable] static const char * const
> gcc_xo_gpll0_gpll2_gpll3_gpll1_gpll4_gpll0_early_div[] = {
>
> It looks like these were never used.
>
> Fixes: b1e010c0730a ("clk: qcom: Add MSM8996 Global Clock Control (GCC) driver")
> Cc: clang-built-linux@googlegroups.com
> Link: https://github.com/ClangBuiltLinux/linux/issues/518
> Suggested-by: Nathan Chancellor <natechancellor@gmail.com>
> Signed-off-by: Nathan Huckleberry <nhuck@google.com>
LGTM, this doesn't introduce any warnings/errors on arm32 or arm64 for
me.
Reviewed-by: Nathan Chancellor <natechancellor@gmail.com>
> ---
> drivers/clk/qcom/gcc-msm8996.c | 36 ----------------------------------
> 1 file changed, 36 deletions(-)
>
> diff --git a/drivers/clk/qcom/gcc-msm8996.c b/drivers/clk/qcom/gcc-msm8996.c
> index d2f39a972cad..d004cdaa0e39 100644
> --- a/drivers/clk/qcom/gcc-msm8996.c
> +++ b/drivers/clk/qcom/gcc-msm8996.c
> @@ -130,22 +130,6 @@ static const char * const gcc_xo_gpll0_gpll4_gpll0_early_div[] = {
> "gpll0_early_div"
> };
>
> -static const struct parent_map gcc_xo_gpll0_gpll2_gpll3_gpll0_early_div_map[] = {
> - { P_XO, 0 },
> - { P_GPLL0, 1 },
> - { P_GPLL2, 2 },
> - { P_GPLL3, 3 },
> - { P_GPLL0_EARLY_DIV, 6 }
> -};
> -
> -static const char * const gcc_xo_gpll0_gpll2_gpll3_gpll0_early_div[] = {
> - "xo",
> - "gpll0",
> - "gpll2",
> - "gpll3",
> - "gpll0_early_div"
> -};
> -
> static const struct parent_map gcc_xo_gpll0_gpll1_early_div_gpll1_gpll4_gpll0_early_div_map[] = {
> { P_XO, 0 },
> { P_GPLL0, 1 },
> @@ -184,26 +168,6 @@ static const char * const gcc_xo_gpll0_gpll2_gpll3_gpll1_gpll2_early_gpll0_early
> "gpll0_early_div"
> };
>
> -static const struct parent_map gcc_xo_gpll0_gpll2_gpll3_gpll1_gpll4_gpll0_early_div_map[] = {
> - { P_XO, 0 },
> - { P_GPLL0, 1 },
> - { P_GPLL2, 2 },
> - { P_GPLL3, 3 },
> - { P_GPLL1, 4 },
> - { P_GPLL4, 5 },
> - { P_GPLL0_EARLY_DIV, 6 }
> -};
> -
> -static const char * const gcc_xo_gpll0_gpll2_gpll3_gpll1_gpll4_gpll0_early_div[] = {
> - "xo",
> - "gpll0",
> - "gpll2",
> - "gpll3",
> - "gpll1",
> - "gpll4",
> - "gpll0_early_div"
> -};
> -
> static struct clk_fixed_factor xo = {
> .mult = 1,
> .div = 1,
> --
> 2.22.0.rc2.383.gf4fbbf30c2-goog
>
next prev parent reply other threads:[~2019-06-11 21:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-11 21:11 [PATCH] clk: qcom: Fix -Wunused-const-variable Nathan Huckleberry
2019-06-11 21:22 ` Nathan Chancellor [this message]
2019-06-25 22:49 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190611212211.GA6815@archlinux-epyc \
--to=natechancellor@gmail.com \
--cc=agross@kernel.org \
--cc=clang-built-linux@googlegroups.com \
--cc=david.brown@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=nhuck@google.com \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.