From: Wolfram Sang <wsa@the-dreams.de>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Linux Next Mailing List <linux-next@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Ruslan Babayev <ruslan@babayev.com>,
Andrew de Quincey <adq_dvb@lidskialf.net>,
Mauro Carvalho Chehab <mchehab@infradead.org>
Subject: Re: linux-next: build warning after merge of the i2c tree
Date: Wed, 12 Jun 2019 10:19:29 +0200 [thread overview]
Message-ID: <20190612081929.GA1687@kunai> (raw)
In-Reply-To: <20190611102528.44ad5783@canb.auug.org.au>
[-- Attachment #1: Type: text/plain, Size: 1319 bytes --]
On Tue, Jun 11, 2019 at 10:25:28AM +1000, Stephen Rothwell wrote:
> Hi Wolfram,
>
> After merging the i2c tree, today's linux-next build (x86_64 allmodconfig)
> produced this warning:
>
> drivers/media/dvb-frontends/tua6100.c: In function 'tua6100_set_params':
> drivers/media/dvb-frontends/tua6100.c:71: warning: "_P" redefined
> #define _P 32
>
> In file included from include/acpi/platform/aclinux.h:54,
> from include/acpi/platform/acenv.h:152,
> from include/acpi/acpi.h:22,
> from include/linux/acpi.h:21,
> from include/linux/i2c.h:17,
> from drivers/media/dvb-frontends/tua6100.h:22,
> from drivers/media/dvb-frontends/tua6100.c:24:
> include/linux/ctype.h:14: note: this is the location of the previous definition
> #define _P 0x10 /* punct */
>
> Exposed by commit
>
> 5213d7efc8ec ("i2c: acpi: export i2c_acpi_find_adapter_by_handle")
>
> Since that included <linux/acpi.h> from <linux/i2c.h>
>
> Originally introduced by commit
>
> 00be2e7c6415 ("V4L/DVB (4606): Add driver for TUA6100")
>
> The _P in <linux/ctype.h> has existed since before git.
I suggest to fix the driver by adding a TUA6100_ prefix to the defines.
I can cook up a patch for that.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2019-06-12 8:19 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-11 0:25 linux-next: build warning after merge of the i2c tree Stephen Rothwell
2019-06-12 8:19 ` Wolfram Sang [this message]
2019-06-12 11:02 ` Mauro Carvalho Chehab
2019-06-12 11:09 ` Wolfram Sang
2019-06-12 11:48 ` Mauro Carvalho Chehab
2019-06-12 12:04 ` Wolfram Sang
2019-06-12 12:32 ` Mauro Carvalho Chehab
2019-06-12 13:15 ` Stephen Rothwell
2019-06-12 13:24 ` Wolfram Sang
2019-06-12 11:25 ` [PATCH] media: tua6100: Remove some ugly defines Mauro Carvalho Chehab
2019-06-12 12:01 ` Wolfram Sang
2019-06-18 21:38 ` Wolfram Sang
2019-07-08 9:25 ` Wolfram Sang
-- strict thread matches above, loose matches on Subject: below --
2025-01-15 5:31 linux-next: build warning after merge of the i2c tree Stephen Rothwell
2025-01-15 7:32 ` Wolfram Sang
2024-11-28 2:07 Stephen Rothwell
2024-11-28 6:42 ` Wolfram Sang
2021-08-18 6:29 Stephen Rothwell
2021-08-18 6:54 ` Jie Deng
2021-08-18 7:04 ` Stephen Rothwell
2021-08-18 7:13 ` Jie Deng
2019-08-02 3:21 Stephen Rothwell
2019-08-02 6:04 ` Uwe Kleine-König
2017-06-05 1:11 Stephen Rothwell
2017-06-15 1:34 ` Stephen Rothwell
2017-06-15 7:02 ` Wolfram Sang
2017-06-15 8:48 ` Stephen Rothwell
2014-03-06 2:50 Stephen Rothwell
2010-03-28 23:54 Stephen Rothwell
2010-03-29 13:21 ` Jean Delvare
2010-03-29 14:12 ` Stephen Rothwell
2010-02-17 0:38 Stephen Rothwell
2010-02-17 8:34 ` Jean Delvare
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190612081929.GA1687@kunai \
--to=wsa@the-dreams.de \
--cc=adq_dvb@lidskialf.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=mchehab@infradead.org \
--cc=ruslan@babayev.com \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.