From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Maya Erez <merez@codeaurora.org>, Kalle Valo <kvalo@codeaurora.org>
Cc: "David S. Miller" <davem@davemloft.net>,
linux-wireless@vger.kernel.org, wil6210@qti.qualcomm.com
Subject: Re: [PATCH] wireless: wil6210: no need to check return value of debugfs_create functions
Date: Wed, 12 Jun 2019 12:09:31 +0200 [thread overview]
Message-ID: <20190612100931.GA19472@kroah.com> (raw)
In-Reply-To: <20190612100717.GA19167@kroah.com>
On Wed, Jun 12, 2019 at 12:07:17PM +0200, Greg Kroah-Hartman wrote:
> On Tue, Jun 11, 2019 at 09:10:24PM +0200, Greg Kroah-Hartman wrote:
> > When calling debugfs functions, there is no need to ever check the
> > return value. The function can work or not, but the code logic should
> > never do something different based on this.
> >
> > Cc: Maya Erez <merez@codeaurora.org>
> > Cc: Kalle Valo <kvalo@codeaurora.org>
> > Cc: "David S. Miller" <davem@davemloft.net>
> > Cc: linux-wireless@vger.kernel.org
> > Cc: wil6210@qti.qualcomm.com
> > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > ---
> > drivers/net/wireless/ath/wil6210/debugfs.c | 80 ++++++----------------
> > 1 file changed, 22 insertions(+), 58 deletions(-)
>
> Oops, 0-day finally woke up and shows I messed this patch up. Please
> drop it, I will submit a v2 soon.
{sigh}, no, that was a different patch that broke things. This pathc is
fine, please consider it as-is.
I'll go get more coffee...
greg k-h
next prev parent reply other threads:[~2019-06-12 10:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-11 19:10 [PATCH] wireless: wil6210: no need to check return value of debugfs_create functions Greg Kroah-Hartman
2019-06-12 10:07 ` Greg Kroah-Hartman
2019-06-12 10:09 ` Greg Kroah-Hartman [this message]
2019-06-23 12:55 ` merez
2019-06-27 17:48 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190612100931.GA19472@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=davem@davemloft.net \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
--cc=merez@codeaurora.org \
--cc=wil6210@qti.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.