From: Kishon Vijay Abraham I <kishon@ti.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>, <kishon@ti.com>
Cc: <linux-kernel@vger.kernel.org>
Subject: [PATCH 1/6] phy: qcom-qusb2: fix missing assignment of ret when calling clk_prepare_enable
Date: Wed, 12 Jun 2019 15:57:58 +0530 [thread overview]
Message-ID: <20190612102803.25398-2-kishon@ti.com> (raw)
In-Reply-To: <20190612102803.25398-1-kishon@ti.com>
From: Colin Ian King <colin.king@canonical.com>
The error return from the call to clk_prepare_enable is not being assigned
to variable ret even though ret is being used to check if the call failed.
Fix this by adding in the missing assignment.
Addresses-Coverity: ("Logically dead code")
Fixes: 891a96f65ac3 ("phy: qcom-qusb2: Add support for runtime PM")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
---
drivers/phy/qualcomm/phy-qcom-qusb2.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/phy/qualcomm/phy-qcom-qusb2.c b/drivers/phy/qualcomm/phy-qcom-qusb2.c
index 1cbf1d6f28ce..bf94a52d3087 100644
--- a/drivers/phy/qualcomm/phy-qcom-qusb2.c
+++ b/drivers/phy/qualcomm/phy-qcom-qusb2.c
@@ -564,7 +564,7 @@ static int __maybe_unused qusb2_phy_runtime_resume(struct device *dev)
}
if (!qphy->has_se_clk_scheme) {
- clk_prepare_enable(qphy->ref_clk);
+ ret = clk_prepare_enable(qphy->ref_clk);
if (ret) {
dev_err(dev, "failed to enable ref clk, %d\n", ret);
goto disable_ahb_clk;
--
2.17.1
next prev parent reply other threads:[~2019-06-12 10:29 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-12 10:27 [GIT PULL v2] PHY: for 5.2-rc Kishon Vijay Abraham I
2019-06-12 10:27 ` Kishon Vijay Abraham I [this message]
2019-06-12 10:27 ` [PATCH 2/6] phy: renesas: rcar-gen2: Fix memory leak at error paths Kishon Vijay Abraham I
2019-06-12 10:28 ` [PATCH 3/6] phy: usb: phy-brcm-usb: Remove sysfs attributes upon driver removal Kishon Vijay Abraham I
2019-06-12 10:28 ` [PATCH 4/6] dt-bindings: phy: tegra-xusb: List PLL power supplies Kishon Vijay Abraham I
2019-06-12 10:28 ` [PATCH 5/6] phy: tegra: xusb: Add Tegra124 " Kishon Vijay Abraham I
2019-06-12 10:28 ` [PATCH 6/6] phy: tegra: xusb: Add Tegra210 " Kishon Vijay Abraham I
2019-06-21 6:11 ` [GIT PULL v2] PHY: for 5.2-rc Kishon Vijay Abraham I
2019-06-21 6:40 ` Greg Kroah-Hartman
2019-06-21 7:20 ` Kishon Vijay Abraham I
2019-06-27 13:16 ` Kishon Vijay Abraham I
2019-07-01 10:14 ` Greg Kroah-Hartman
2019-07-01 10:31 ` Kishon Vijay Abraham I
2019-07-01 13:06 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190612102803.25398-2-kishon@ti.com \
--to=kishon@ti.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.