From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 608DEC31E46 for ; Wed, 12 Jun 2019 10:40:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2F79120874 for ; Wed, 12 Jun 2019 10:40:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1560336007; bh=olJE88EuGPDle+9Tm9CK1rEMk80N8UpsGxLJZzTv3x0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=dSYSrjRqHpANRcJL4Kz3gVLyLmqYZPmypF6T6VRJ1BbSHfb5kRVc1A8xlMRPlgpR8 ko6G9skcWGDvEhEUskhmDgj9rB2aJRKLA/nUe2t46Bah9Uv88PeFLxLXc6J31Ly4ju iRNlcjCDv+jz7ZZpmWqseHOrELE12YjOjIt54z/8= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2436837AbfFLKkG (ORCPT ); Wed, 12 Jun 2019 06:40:06 -0400 Received: from mail.kernel.org ([198.145.29.99]:47910 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389150AbfFLKkG (ORCPT ); Wed, 12 Jun 2019 06:40:06 -0400 Received: from dragon (li1264-180.members.linode.com [45.79.165.180]) (using TLSv1.2 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 0327E2082C; Wed, 12 Jun 2019 10:39:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1560336005; bh=olJE88EuGPDle+9Tm9CK1rEMk80N8UpsGxLJZzTv3x0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=rqSGJ26WhA1epEd5iGa6+JzbWjQ8AyZF8ksDozVUYo1vXzZ1K7aEeze82ZJa1JjQB BNZU7J5vrqlC3YpGiTfgCyhGB+NnChrdzCZupgVC2hVkdmJy+fipdid2cOkE1tvqt0 P40EJtFCyc0BT0Au2KyU+1wmtXHN0JS9rs7oBZWY= Date: Wed, 12 Jun 2019 18:39:27 +0800 From: Shawn Guo To: Horia =?utf-8?Q?Geant=C4=83?= Cc: Herbert Xu , "David S. Miller" , Sascha Hauer , Rob Herring , Mark Rutland , Aymen Sghaier , Iuliana Prodan , Franck Lenormand , linux-crypto@vger.kernel.org, Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ARM: dts: imx7ulp: add crypto support Message-ID: <20190612103926.GE11086@dragon> References: <20190606080255.25504-1-horia.geanta@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20190606080255.25504-1-horia.geanta@nxp.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Thu, Jun 06, 2019 at 11:02:55AM +0300, Horia Geantă wrote: > From: Iuliana Prodan > > Add crypto node in device tree for CAAM support. > > Noteworthy is that on 7ulp the interrupt line is shared > between the two job rings. > > Signed-off-by: Iuliana Prodan > Signed-off-by: Franck LENORMAND > Signed-off-by: Horia Geantă > --- > > I've just realized that this patch should be merged through the crypto tree, > else bisectability could be affected due to cryptodev-2.6 > commit 385cfc84a5a8 ("crypto: caam - disable some clock checks for iMX7ULP") > ( https://patchwork.kernel.org/patch/10970017/ ) > which should come first. I'm not sure I follow it. This is a new device added to imx7ulp DT. It's never worked before on imx7ulp. How would it affect git bisect? Shawn > > arch/arm/boot/dts/imx7ulp.dtsi | 23 +++++++++++++++++++++++ > 1 file changed, 23 insertions(+) > > diff --git a/arch/arm/boot/dts/imx7ulp.dtsi b/arch/arm/boot/dts/imx7ulp.dtsi > index d6b711011cba..e20483714be5 100644 > --- a/arch/arm/boot/dts/imx7ulp.dtsi > +++ b/arch/arm/boot/dts/imx7ulp.dtsi > @@ -100,6 +100,29 @@ > reg = <0x40000000 0x800000>; > ranges; > > + crypto: crypto@40240000 { > + compatible = "fsl,sec-v4.0"; > + #address-cells = <1>; > + #size-cells = <1>; > + reg = <0x40240000 0x10000>; > + ranges = <0 0x40240000 0x10000>; > + clocks = <&pcc2 IMX7ULP_CLK_CAAM>, > + <&scg1 IMX7ULP_CLK_NIC1_BUS_DIV>; > + clock-names = "aclk", "ipg"; > + > + sec_jr0: jr0@1000 { > + compatible = "fsl,sec-v4.0-job-ring"; > + reg = <0x1000 0x1000>; > + interrupts = ; > + }; > + > + sec_jr1: jr1@2000 { > + compatible = "fsl,sec-v4.0-job-ring"; > + reg = <0x2000 0x1000>; > + interrupts = ; > + }; > + }; > + > lpuart4: serial@402d0000 { > compatible = "fsl,imx7ulp-lpuart"; > reg = <0x402d0000 0x1000>; > -- > 2.17.1 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8F310C31E46 for ; Wed, 12 Jun 2019 10:40:20 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 681BD2082C for ; Wed, 12 Jun 2019 10:40:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="H0SZq65V"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="rqSGJ26W" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 681BD2082C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=/Dr4CRlsTsP4cdQ5zAVmuSb9gRH0lNmQokmont084nI=; b=H0SZq65VeQapLX FoNSY3lCuZXfrZyeQeRLWIravKtonhoz7wnyld8RpL47DkhqaUOq2mQYNMFtJMfq8Qh03LHc8dlnW tpt7O9NReqQcYQDCYALo6/ptIWeqzA73NdXWvYg0ITDigWP3bpEaYOeQutM2lR2DcfI+2+JprEE/s vPe4w59vGA+t+3FqJ3BYsf20JpnHJpWMQMlFQEtmlNgU8oPStvH7qDJqR987C7B2jZ+F+Is+LZBV9 WgZ3JqPKdfI2xtdOJlSD3/HpTpSGSILIq+8gj6u0BmFtjOlVbOFkCbj9e8rqKLZrAIcsOzMt1f3Wp grk+LQmZgKHsurVHuXLA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hb0fq-0004Np-7B; Wed, 12 Jun 2019 10:40:10 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hb0fm-000414-5t for linux-arm-kernel@lists.infradead.org; Wed, 12 Jun 2019 10:40:08 +0000 Received: from dragon (li1264-180.members.linode.com [45.79.165.180]) (using TLSv1.2 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 0327E2082C; Wed, 12 Jun 2019 10:39:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1560336005; bh=olJE88EuGPDle+9Tm9CK1rEMk80N8UpsGxLJZzTv3x0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=rqSGJ26WhA1epEd5iGa6+JzbWjQ8AyZF8ksDozVUYo1vXzZ1K7aEeze82ZJa1JjQB BNZU7J5vrqlC3YpGiTfgCyhGB+NnChrdzCZupgVC2hVkdmJy+fipdid2cOkE1tvqt0 P40EJtFCyc0BT0Au2KyU+1wmtXHN0JS9rs7oBZWY= Date: Wed, 12 Jun 2019 18:39:27 +0800 From: Shawn Guo To: Horia =?utf-8?Q?Geant=C4=83?= Subject: Re: [PATCH] ARM: dts: imx7ulp: add crypto support Message-ID: <20190612103926.GE11086@dragon> References: <20190606080255.25504-1-horia.geanta@nxp.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190606080255.25504-1-horia.geanta@nxp.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190612_034006_437498_43D1AE66 X-CRM114-Status: GOOD ( 17.85 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, Aymen Sghaier , Herbert Xu , Iuliana Prodan , Sascha Hauer , linux-kernel@vger.kernel.org, Franck Lenormand , Rob Herring , linux-crypto@vger.kernel.org, Pengutronix Kernel Team , Fabio Estevam , "David S. Miller" , linux-arm-kernel@lists.infradead.org, NXP Linux Team Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gVGh1LCBKdW4gMDYsIDIwMTkgYXQgMTE6MDI6NTVBTSArMDMwMCwgSG9yaWEgR2VhbnTEgyB3 cm90ZToKPiBGcm9tOiBJdWxpYW5hIFByb2RhbiA8aXVsaWFuYS5wcm9kYW5AbnhwLmNvbT4KPiAK PiBBZGQgY3J5cHRvIG5vZGUgaW4gZGV2aWNlIHRyZWUgZm9yIENBQU0gc3VwcG9ydC4KPiAKPiBO b3Rld29ydGh5IGlzIHRoYXQgb24gN3VscCB0aGUgaW50ZXJydXB0IGxpbmUgaXMgc2hhcmVkCj4g YmV0d2VlbiB0aGUgdHdvIGpvYiByaW5ncy4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBJdWxpYW5hIFBy b2RhbiA8aXVsaWFuYS5wcm9kYW5AbnhwLmNvbT4KPiBTaWduZWQtb2ZmLWJ5OiBGcmFuY2sgTEVO T1JNQU5EIDxmcmFuY2subGVub3JtYW5kQG54cC5jb20+Cj4gU2lnbmVkLW9mZi1ieTogSG9yaWEg R2VhbnTEgyA8aG9yaWEuZ2VhbnRhQG54cC5jb20+Cj4gLS0tCj4gCj4gSSd2ZSBqdXN0IHJlYWxp emVkIHRoYXQgdGhpcyBwYXRjaCBzaG91bGQgYmUgbWVyZ2VkIHRocm91Z2ggdGhlIGNyeXB0byB0 cmVlLAo+IGVsc2UgYmlzZWN0YWJpbGl0eSBjb3VsZCBiZSBhZmZlY3RlZCBkdWUgdG8gY3J5cHRv ZGV2LTIuNgo+IGNvbW1pdCAzODVjZmM4NGE1YTggKCJjcnlwdG86IGNhYW0gLSBkaXNhYmxlIHNv bWUgY2xvY2sgY2hlY2tzIGZvciBpTVg3VUxQIikKPiAoIGh0dHBzOi8vcGF0Y2h3b3JrLmtlcm5l bC5vcmcvcGF0Y2gvMTA5NzAwMTcvICkKPiB3aGljaCBzaG91bGQgY29tZSBmaXJzdC4KCkknbSBu b3Qgc3VyZSBJIGZvbGxvdyBpdC4gIFRoaXMgaXMgYSBuZXcgZGV2aWNlIGFkZGVkIHRvIGlteDd1 bHAgRFQuCkl0J3MgbmV2ZXIgd29ya2VkIGJlZm9yZSBvbiBpbXg3dWxwLiAgSG93IHdvdWxkIGl0 IGFmZmVjdCBnaXQgYmlzZWN0PwoKU2hhd24KCj4gCj4gIGFyY2gvYXJtL2Jvb3QvZHRzL2lteDd1 bHAuZHRzaSB8IDIzICsrKysrKysrKysrKysrKysrKysrKysrCj4gIDEgZmlsZSBjaGFuZ2VkLCAy MyBpbnNlcnRpb25zKCspCj4gCj4gZGlmZiAtLWdpdCBhL2FyY2gvYXJtL2Jvb3QvZHRzL2lteDd1 bHAuZHRzaSBiL2FyY2gvYXJtL2Jvb3QvZHRzL2lteDd1bHAuZHRzaQo+IGluZGV4IGQ2YjcxMTAx MWNiYS4uZTIwNDgzNzE0YmU1IDEwMDY0NAo+IC0tLSBhL2FyY2gvYXJtL2Jvb3QvZHRzL2lteDd1 bHAuZHRzaQo+ICsrKyBiL2FyY2gvYXJtL2Jvb3QvZHRzL2lteDd1bHAuZHRzaQo+IEBAIC0xMDAs NiArMTAwLDI5IEBACj4gIAkJcmVnID0gPDB4NDAwMDAwMDAgMHg4MDAwMDA+Owo+ICAJCXJhbmdl czsKPiAgCj4gKwkJY3J5cHRvOiBjcnlwdG9ANDAyNDAwMDAgewo+ICsJCQljb21wYXRpYmxlID0g ImZzbCxzZWMtdjQuMCI7Cj4gKwkJCSNhZGRyZXNzLWNlbGxzID0gPDE+Owo+ICsJCQkjc2l6ZS1j ZWxscyA9IDwxPjsKPiArCQkJcmVnID0gPDB4NDAyNDAwMDAgMHgxMDAwMD47Cj4gKwkJCXJhbmdl cyA9IDwwIDB4NDAyNDAwMDAgMHgxMDAwMD47Cj4gKwkJCWNsb2NrcyA9IDwmcGNjMiBJTVg3VUxQ X0NMS19DQUFNPiwKPiArCQkJCSA8JnNjZzEgSU1YN1VMUF9DTEtfTklDMV9CVVNfRElWPjsKPiAr CQkJY2xvY2stbmFtZXMgPSAiYWNsayIsICJpcGciOwo+ICsKPiArCQkJc2VjX2pyMDoganIwQDEw MDAgewo+ICsJCQkJY29tcGF0aWJsZSA9ICJmc2wsc2VjLXY0LjAtam9iLXJpbmciOwo+ICsJCQkJ cmVnID0gPDB4MTAwMCAweDEwMDA+Owo+ICsJCQkJaW50ZXJydXB0cyA9IDxHSUNfU1BJIDU0IElS UV9UWVBFX0xFVkVMX0hJR0g+Owo+ICsJCQl9Owo+ICsKPiArCQkJc2VjX2pyMToganIxQDIwMDAg ewo+ICsJCQkJY29tcGF0aWJsZSA9ICJmc2wsc2VjLXY0LjAtam9iLXJpbmciOwo+ICsJCQkJcmVn ID0gPDB4MjAwMCAweDEwMDA+Owo+ICsJCQkJaW50ZXJydXB0cyA9IDxHSUNfU1BJIDU0IElSUV9U WVBFX0xFVkVMX0hJR0g+Owo+ICsJCQl9Owo+ICsJCX07Cj4gKwo+ICAJCWxwdWFydDQ6IHNlcmlh bEA0MDJkMDAwMCB7Cj4gIAkJCWNvbXBhdGlibGUgPSAiZnNsLGlteDd1bHAtbHB1YXJ0IjsKPiAg CQkJcmVnID0gPDB4NDAyZDAwMDAgMHgxMDAwPjsKPiAtLSAKPiAyLjE3LjEKPiAKCl9fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwg bWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8v bGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK