From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg Kroah-Hartman Subject: Re: [PATCH 3/8] platform: x86: dell-laptop: no need to check return value of debugfs_create functions Date: Wed, 12 Jun 2019 14:47:13 +0200 Message-ID: <20190612124713.GA27788@kroah.com> References: <20190612121258.19535-1-gregkh@linuxfoundation.org> <20190612121258.19535-3-gregkh@linuxfoundation.org> <20190612122105.miyyfkmae24kddwt@pali> <20190612123604.GB25718@kroah.com> <20190612124411.nbjslftjtc72a25v@pali> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Return-path: Content-Disposition: inline In-Reply-To: <20190612124411.nbjslftjtc72a25v@pali> Sender: linux-kernel-owner@vger.kernel.org To: Pali =?iso-8859-1?Q?Roh=E1r?= Cc: dvhart@infradead.org, andy@infradead.org, Matthew Garrett , platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org List-Id: platform-driver-x86.vger.kernel.org On Wed, Jun 12, 2019 at 02:44:11PM +0200, Pali Rohár wrote: > On Wednesday 12 June 2019 14:36:04 Greg Kroah-Hartman wrote: > > On Wed, Jun 12, 2019 at 02:21:05PM +0200, Pali Rohár wrote: > > > On Wednesday 12 June 2019 14:12:53 Greg Kroah-Hartman wrote: > > > > When calling debugfs functions, there is no need to ever check the > > > > return value. The function can work or not, but the code logic should > > > > never do something different based on this. > > > > > > > > Cc: Matthew Garrett > > > > Cc: "Pali Rohár" > > > > Cc: Darren Hart > > > > Cc: Andy Shevchenko > > > > Cc: platform-driver-x86@vger.kernel.org > > > > Cc: linux-kernel@vger.kernel.org > > > > Signed-off-by: Greg Kroah-Hartman > > > > --- > > > > drivers/platform/x86/dell-laptop.c | 5 ++--- > > > > 1 file changed, 2 insertions(+), 3 deletions(-) > > > > > > > > diff --git a/drivers/platform/x86/dell-laptop.c b/drivers/platform/x86/dell-laptop.c > > > > index a561f653cf13..94a2f259031c 100644 > > > > --- a/drivers/platform/x86/dell-laptop.c > > > > +++ b/drivers/platform/x86/dell-laptop.c > > > > @@ -2176,9 +2176,8 @@ static int __init dell_init(void) > > > > kbd_led_init(&platform_device->dev); > > > > > > > > dell_laptop_dir = debugfs_create_dir("dell_laptop", NULL); > > > > - if (dell_laptop_dir != NULL) > > > > - debugfs_create_file("rfkill", 0444, dell_laptop_dir, NULL, > > > > - &dell_debugfs_fops); > > > > + debugfs_create_file("rfkill", 0444, dell_laptop_dir, NULL, > > > > + &dell_debugfs_fops); > > > > > > Hi! > > > > > > So... debugfs_create_dir() can return NULL, right? > > > > Nope. > > Yea, now I see implementation. It does not return NULL on error, but > rather ERR_PTR. > > So dell_laptop_dir is always not-NULL. And that check was wrong. > > You can add my > Reviewed-by: Pali Rohár Thanks! greg k-h