From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 87230C31E46 for ; Wed, 12 Jun 2019 13:26:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 620D620866 for ; Wed, 12 Jun 2019 13:26:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1560346011; bh=NM/4gZb0J83hRo3GjTDGogF0kEC8Qio6Tsc1tV61U7I=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=XI6rBc+SlyBetWXm6xecboIrcZPCqRYrOAJINFNj3bCToKM3kc6LkpVEKUTdynx1h jvnN5JSE/amQHJs1pKEjruSZN9udNXC0YD++/BPYJp0ZHWCPnUjMbejh6qbLF+UQu0 QAGGjDZwiu2sQpVKVjXY9zn9sQDc2YAT7oQa8n7U= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729330AbfFLN0q (ORCPT ); Wed, 12 Jun 2019 09:26:46 -0400 Received: from mail.kernel.org ([198.145.29.99]:52822 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728977AbfFLN0q (ORCPT ); Wed, 12 Jun 2019 09:26:46 -0400 Received: from dragon (li1264-180.members.linode.com [45.79.165.180]) (using TLSv1.2 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1AA9920866; Wed, 12 Jun 2019 13:26:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1560346004; bh=NM/4gZb0J83hRo3GjTDGogF0kEC8Qio6Tsc1tV61U7I=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ZAdGtljkJqX9KUoyGddtloo7a1KIXSmwkorvJ1FPH3hECWiB47rEz7umtF889uIAZ st0rPgwtAxNI94JP0sCnAgXqVXDyiC7py8EiUaaxv68/0vjtWCdC3f9Mualy5WGo+9 R5yCVVLPx60K93T53td5GSOXDr5RpZ+qnUz/Dc8M= Date: Wed, 12 Jun 2019 21:26:02 +0800 From: Shawn Guo To: Horia Geanta Cc: Herbert Xu , "David S. Miller" , Sascha Hauer , Rob Herring , Mark Rutland , Aymen Sghaier , Iuliana Prodan , Franck Lenormand , "linux-crypto@vger.kernel.org" , Pengutronix Kernel Team , Fabio Estevam , dl-linux-imx , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] ARM: dts: imx7ulp: add crypto support Message-ID: <20190612132600.GI11086@dragon> References: <20190606080255.25504-1-horia.geanta@nxp.com> <20190612103926.GE11086@dragon> <20190612130602.GH11086@dragon> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Wed, Jun 12, 2019 at 01:15:46PM +0000, Horia Geanta wrote: > On 6/12/2019 4:06 PM, Shawn Guo wrote: > > On Wed, Jun 12, 2019 at 11:45:18AM +0000, Horia Geanta wrote: > >> On 6/12/2019 1:40 PM, Shawn Guo wrote: > >>> On Thu, Jun 06, 2019 at 11:02:55AM +0300, Horia Geantă wrote: > >>>> From: Iuliana Prodan > >>>> > >>>> Add crypto node in device tree for CAAM support. > >>>> > >>>> Noteworthy is that on 7ulp the interrupt line is shared > >>>> between the two job rings. > >>>> > >>>> Signed-off-by: Iuliana Prodan > >>>> Signed-off-by: Franck LENORMAND > >>>> Signed-off-by: Horia Geantă > >>>> --- > >>>> > >>>> I've just realized that this patch should be merged through the crypto tree, > >>>> else bisectability could be affected due to cryptodev-2.6 > >>>> commit 385cfc84a5a8 ("crypto: caam - disable some clock checks for iMX7ULP") > >>>> ( https://patchwork.kernel.org/patch/10970017/ ) > >>>> which should come first. > >>> > >>> I'm not sure I follow it. This is a new device added to imx7ulp DT. > >>> It's never worked before on imx7ulp. How would it affect git bisect? > >>> > >> Driver corresponding to this device (drivers/crypto/caam) has to be updated > >> before adding the node in DT. > >> Is there any guarantee wrt. merge order of the crypto and DT trees? > > > > Do not merge DT changes until driver part hits mainline. > > > That would mean driver changes would be merged in v5.3 and DT node in v5.4. It's quite normal that dependent changes land on mainline in multiple cycles. > > Would going through the crypto tree with this patch be such a big issue? The only issue would be the potential merge conflict. > I don't think it's the first time (relatively small) DT patches > are merged via other trees. Yes, it happens from time to time depending on maintainer's style. I'm fine with the DT changes going through other subsystem tree, if the subsystem maintainer wants to and is willing to take the risk of merge conflict between his tree and arm-soc tree. Shawn From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C4EF3C31E46 for ; Wed, 12 Jun 2019 13:26:49 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9F85B20866 for ; Wed, 12 Jun 2019 13:26:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="QoB7tjzP"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="ZAdGtljk" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9F85B20866 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=DIrBDZQ3aBWKsukpV34EY/T6XCBYl8katzGBv2keUSo=; b=QoB7tjzPXSPX9i tpaA1bU1GRP7OgLJOk7RPr3So8fQLyAOE/KImopMmDsTerLIBKAHUME3obVWhUM8ih9CV+0DrXZwA k4w1eeI9WM6lbnOr0T8s3XtfYJ2/0GgfiCL8ZMaLU2QCY7KWWAPmgRTlujexcz3Z1EuFlKolvpSBK LwiaKTix8ntO3Ot1SEq09nVVX6qDD0wy0w+BbVfa0oALMqLDXOcxwMhKXKsa4h03NZx5I839WR1Lt d4KPt/4f2QnxUUF/TfOIGho0tV3tDL6mX4/NB8Gz8yolk865E1t1jFbxEbLimXxKmMXfcCpCV2UGK T5eRNb1WbRm9Lq9VGF9g==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hb3H6-0004Ps-UM; Wed, 12 Jun 2019 13:26:48 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hb3H3-0004PR-9g for linux-arm-kernel@lists.infradead.org; Wed, 12 Jun 2019 13:26:46 +0000 Received: from dragon (li1264-180.members.linode.com [45.79.165.180]) (using TLSv1.2 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1AA9920866; Wed, 12 Jun 2019 13:26:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1560346004; bh=NM/4gZb0J83hRo3GjTDGogF0kEC8Qio6Tsc1tV61U7I=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ZAdGtljkJqX9KUoyGddtloo7a1KIXSmwkorvJ1FPH3hECWiB47rEz7umtF889uIAZ st0rPgwtAxNI94JP0sCnAgXqVXDyiC7py8EiUaaxv68/0vjtWCdC3f9Mualy5WGo+9 R5yCVVLPx60K93T53td5GSOXDr5RpZ+qnUz/Dc8M= Date: Wed, 12 Jun 2019 21:26:02 +0800 From: Shawn Guo To: Horia Geanta Subject: Re: [PATCH] ARM: dts: imx7ulp: add crypto support Message-ID: <20190612132600.GI11086@dragon> References: <20190606080255.25504-1-horia.geanta@nxp.com> <20190612103926.GE11086@dragon> <20190612130602.GH11086@dragon> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190612_062645_378254_FCFE0EB0 X-CRM114-Status: GOOD ( 18.38 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , "devicetree@vger.kernel.org" , Aymen Sghaier , Herbert Xu , Iuliana Prodan , Sascha Hauer , "linux-kernel@vger.kernel.org" , Franck Lenormand , Rob Herring , "linux-crypto@vger.kernel.org" , Pengutronix Kernel Team , Fabio Estevam , "David S. Miller" , "linux-arm-kernel@lists.infradead.org" , dl-linux-imx Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gV2VkLCBKdW4gMTIsIDIwMTkgYXQgMDE6MTU6NDZQTSArMDAwMCwgSG9yaWEgR2VhbnRhIHdy b3RlOgo+IE9uIDYvMTIvMjAxOSA0OjA2IFBNLCBTaGF3biBHdW8gd3JvdGU6Cj4gPiBPbiBXZWQs IEp1biAxMiwgMjAxOSBhdCAxMTo0NToxOEFNICswMDAwLCBIb3JpYSBHZWFudGEgd3JvdGU6Cj4g Pj4gT24gNi8xMi8yMDE5IDE6NDAgUE0sIFNoYXduIEd1byB3cm90ZToKPiA+Pj4gT24gVGh1LCBK dW4gMDYsIDIwMTkgYXQgMTE6MDI6NTVBTSArMDMwMCwgSG9yaWEgR2VhbnTEgyB3cm90ZToKPiA+ Pj4+IEZyb206IEl1bGlhbmEgUHJvZGFuIDxpdWxpYW5hLnByb2RhbkBueHAuY29tPgo+ID4+Pj4K PiA+Pj4+IEFkZCBjcnlwdG8gbm9kZSBpbiBkZXZpY2UgdHJlZSBmb3IgQ0FBTSBzdXBwb3J0Lgo+ ID4+Pj4KPiA+Pj4+IE5vdGV3b3J0aHkgaXMgdGhhdCBvbiA3dWxwIHRoZSBpbnRlcnJ1cHQgbGlu ZSBpcyBzaGFyZWQKPiA+Pj4+IGJldHdlZW4gdGhlIHR3byBqb2IgcmluZ3MuCj4gPj4+Pgo+ID4+ Pj4gU2lnbmVkLW9mZi1ieTogSXVsaWFuYSBQcm9kYW4gPGl1bGlhbmEucHJvZGFuQG54cC5jb20+ Cj4gPj4+PiBTaWduZWQtb2ZmLWJ5OiBGcmFuY2sgTEVOT1JNQU5EIDxmcmFuY2subGVub3JtYW5k QG54cC5jb20+Cj4gPj4+PiBTaWduZWQtb2ZmLWJ5OiBIb3JpYSBHZWFudMSDIDxob3JpYS5nZWFu dGFAbnhwLmNvbT4KPiA+Pj4+IC0tLQo+ID4+Pj4KPiA+Pj4+IEkndmUganVzdCByZWFsaXplZCB0 aGF0IHRoaXMgcGF0Y2ggc2hvdWxkIGJlIG1lcmdlZCB0aHJvdWdoIHRoZSBjcnlwdG8gdHJlZSwK PiA+Pj4+IGVsc2UgYmlzZWN0YWJpbGl0eSBjb3VsZCBiZSBhZmZlY3RlZCBkdWUgdG8gY3J5cHRv ZGV2LTIuNgo+ID4+Pj4gY29tbWl0IDM4NWNmYzg0YTVhOCAoImNyeXB0bzogY2FhbSAtIGRpc2Fi bGUgc29tZSBjbG9jayBjaGVja3MgZm9yIGlNWDdVTFAiKQo+ID4+Pj4gKCBodHRwczovL3BhdGNo d29yay5rZXJuZWwub3JnL3BhdGNoLzEwOTcwMDE3LyApCj4gPj4+PiB3aGljaCBzaG91bGQgY29t ZSBmaXJzdC4KPiA+Pj4KPiA+Pj4gSSdtIG5vdCBzdXJlIEkgZm9sbG93IGl0LiAgVGhpcyBpcyBh IG5ldyBkZXZpY2UgYWRkZWQgdG8gaW14N3VscCBEVC4KPiA+Pj4gSXQncyBuZXZlciB3b3JrZWQg YmVmb3JlIG9uIGlteDd1bHAuICBIb3cgd291bGQgaXQgYWZmZWN0IGdpdCBiaXNlY3Q/Cj4gPj4+ Cj4gPj4gRHJpdmVyIGNvcnJlc3BvbmRpbmcgdG8gdGhpcyBkZXZpY2UgKGRyaXZlcnMvY3J5cHRv L2NhYW0pIGhhcyB0byBiZSB1cGRhdGVkCj4gPj4gYmVmb3JlIGFkZGluZyB0aGUgbm9kZSBpbiBE VC4KPiA+PiBJcyB0aGVyZSBhbnkgZ3VhcmFudGVlIHdydC4gbWVyZ2Ugb3JkZXIgb2YgdGhlIGNy eXB0byBhbmQgRFQgdHJlZXM/Cj4gPiAKPiA+IERvIG5vdCBtZXJnZSBEVCBjaGFuZ2VzIHVudGls IGRyaXZlciBwYXJ0IGhpdHMgbWFpbmxpbmUuCj4gPiAKPiBUaGF0IHdvdWxkIG1lYW4gZHJpdmVy IGNoYW5nZXMgd291bGQgYmUgbWVyZ2VkIGluIHY1LjMgYW5kIERUIG5vZGUgaW4gdjUuNC4KCkl0 J3MgcXVpdGUgbm9ybWFsIHRoYXQgZGVwZW5kZW50IGNoYW5nZXMgbGFuZCBvbiBtYWlubGluZSBp biBtdWx0aXBsZQpjeWNsZXMuCgo+IAo+IFdvdWxkIGdvaW5nIHRocm91Z2ggdGhlIGNyeXB0byB0 cmVlIHdpdGggdGhpcyBwYXRjaCBiZSBzdWNoIGEgYmlnIGlzc3VlPwoKVGhlIG9ubHkgaXNzdWUg d291bGQgYmUgdGhlIHBvdGVudGlhbCBtZXJnZSBjb25mbGljdC4KCj4gSSBkb24ndCB0aGluayBp dCdzIHRoZSBmaXJzdCB0aW1lIChyZWxhdGl2ZWx5IHNtYWxsKSBEVCBwYXRjaGVzCj4gYXJlIG1l cmdlZCB2aWEgb3RoZXIgdHJlZXMuCgpZZXMsIGl0IGhhcHBlbnMgZnJvbSB0aW1lIHRvIHRpbWUg ZGVwZW5kaW5nIG9uIG1haW50YWluZXIncyBzdHlsZS4gSSdtCmZpbmUgd2l0aCB0aGUgRFQgY2hh bmdlcyBnb2luZyB0aHJvdWdoIG90aGVyIHN1YnN5c3RlbSB0cmVlLCBpZiB0aGUKc3Vic3lzdGVt IG1haW50YWluZXIgd2FudHMgdG8gYW5kIGlzIHdpbGxpbmcgdG8gdGFrZSB0aGUgcmlzayBvZiBt ZXJnZQpjb25mbGljdCBiZXR3ZWVuIGhpcyB0cmVlIGFuZCBhcm0tc29jIHRyZWUuCgpTaGF3bgoK X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJt LWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3Jn Cmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtl cm5lbAo=