From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v2] syscalls/ioctl_ns0[156]: align stack and wait for child
Date: Wed, 12 Jun 2019 17:21:51 +0200 [thread overview]
Message-ID: <20190612152151.GC3048@rei.lan> (raw)
In-Reply-To: <278919491.27726511.1560349549390.JavaMail.zimbra@redhat.com>
Hi!
> Default alignment is not enough:
> Alignment: 2 * sizeof(size_t) (default)
> (i.e., 8 byte alignment with 4byte size_t). This suffices for
> nearly all current machines and C compilers. However, you can
> define MALLOC_ALIGNMENT to be wider than this if necessary.
>
> I'm guessing most of tests cross M_MMAP_THRESHOLD, and get page alignment
> from mmap. But should we rely on that?
>
> How about posix_memalign()?
I guess that we need to fix the ltp_clone_malloc() function as well, we
should probably add a helper to allocate memory to the clone library
which would make use of the posix_memalign() and make use of it
internally as well...
--
Cyril Hrubis
chrubis@suse.cz
prev parent reply other threads:[~2019-06-12 15:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-11 10:25 [LTP] [PATCH v2] syscalls/ioctl_ns0[156]: align stack and wait for child Jan Stancek
2019-06-12 1:28 ` Li Wang
2019-06-12 13:59 ` Cyril Hrubis
2019-06-12 14:25 ` Jan Stancek
2019-06-12 15:21 ` Cyril Hrubis [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190612152151.GC3048@rei.lan \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.