From: Sean Christopherson <sean.j.christopherson@intel.com>
To: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Cc: linux-sgx@vger.kernel.org, Dave Hansen <dave.hansen@intel.com>,
Cedric Xing <cedric.xing@intel.com>,
Andy Lutomirski <luto@kernel.org>,
Jethro Beekman <jethro@fortanix.com>,
"Dr . Greg Wettstein" <greg@enjellic.com>
Subject: Re: [PATCH 7/7] x86/sgx: Add a reserved field to sgx_enclave_add_region to drop 'packed'
Date: Wed, 12 Jun 2019 08:23:42 -0700 [thread overview]
Message-ID: <20190612152341.GE20308@linux.intel.com> (raw)
In-Reply-To: <20190612151439.GA5723@linux.intel.com>
On Wed, Jun 12, 2019 at 06:14:39PM +0300, Jarkko Sakkinen wrote:
> On Wed, Jun 05, 2019 at 12:48:45PM -0700, Sean Christopherson wrote:
> > A reserved field could prove useful in the future, and packed structs
> > can result in inefficiencies due to its impact on alignment.
> >
> > Signed-off-by: Sean Christopherson <sean.j.christopherson@intel.com>
>
> Rather should extend mrmask just to 32 bits.
I considered that option, but extending mrmask would probably confusing
to userspace, e.g. we'd have to document that bits 31:15 are ignored.
next prev parent reply other threads:[~2019-06-12 15:23 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-05 19:48 [PATCH 0/7] x86/sgx: Clean up and enhance add pages ioctl Sean Christopherson
2019-06-05 19:48 ` [PATCH 1/7] x86/sgx: Remove dead code to handle non-existent IOR ioctl Sean Christopherson
2019-06-05 19:48 ` [PATCH 2/7] x86/sgx: Remove unnecessary @cmd parameter from ioctl helpers Sean Christopherson
2019-06-05 19:48 ` [PATCH 3/7] x86/sgx: Let ioctl helpers do copy to/from user Sean Christopherson
2019-06-05 19:48 ` [PATCH 4/7] x86/sgx: Allow userspace to add multiple pages in single ioctl() Sean Christopherson
2019-06-06 15:47 ` Jarkko Sakkinen
2019-06-13 0:43 ` Jethro Beekman
2019-06-13 16:51 ` Sean Christopherson
2019-06-13 19:05 ` Andy Lutomirski
2019-06-13 19:15 ` Sean Christopherson
2019-06-13 19:45 ` Xing, Cedric
2019-06-05 19:48 ` [PATCH 5/7] x86/sgx: Add flag to zero added region instead of copying from source Sean Christopherson
2019-06-06 17:20 ` Andy Lutomirski
2019-06-06 17:32 ` Sean Christopherson
2019-06-07 19:32 ` Andy Lutomirski
2019-06-10 17:06 ` Jarkko Sakkinen
2019-06-10 18:09 ` Xing, Cedric
2019-06-10 18:41 ` Sean Christopherson
2019-06-10 18:53 ` Sean Christopherson
2019-06-13 0:38 ` Jethro Beekman
2019-06-13 13:46 ` Sean Christopherson
2019-06-13 16:16 ` Andy Lutomirski
2019-06-13 16:54 ` Sean Christopherson
2019-06-05 19:48 ` [PATCH 6/7] x86/sgx: Use the actual zero page as the source when adding zero pages Sean Christopherson
2019-06-05 19:48 ` [PATCH 7/7] x86/sgx: Add a reserved field to sgx_enclave_add_region to drop 'packed' Sean Christopherson
2019-06-05 19:59 ` Dave Hansen
2019-06-05 20:00 ` Andy Lutomirski
2019-06-12 15:14 ` Jarkko Sakkinen
2019-06-12 15:23 ` Sean Christopherson [this message]
2019-06-13 0:44 ` Jethro Beekman
2019-06-13 15:38 ` Jarkko Sakkinen
2019-06-12 15:16 ` [PATCH 0/7] x86/sgx: Clean up and enhance add pages ioctl Jarkko Sakkinen
2019-06-12 18:14 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190612152341.GE20308@linux.intel.com \
--to=sean.j.christopherson@intel.com \
--cc=cedric.xing@intel.com \
--cc=dave.hansen@intel.com \
--cc=greg@enjellic.com \
--cc=jarkko.sakkinen@linux.intel.com \
--cc=jethro@fortanix.com \
--cc=linux-sgx@vger.kernel.org \
--cc=luto@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.